From: Jason Merrill <jason@redhat.com>
To: Marek Polacek <polacek@redhat.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: C++ PATCH for c++/88196, ICE with class non-type template parameter
Date: Fri, 21 Dec 2018 02:51:00 -0000 [thread overview]
Message-ID: <bf7d121a-43f6-d167-f5a1-1875687e1715@redhat.com> (raw)
In-Reply-To: <20181220215403.GQ21364@redhat.com>
On 12/20/18 4:54 PM, Marek Polacek wrote:
> This testcase breaks in C++20 because convert_nontype_argument gets a PTRMEM_CST
> as the expression, and we're trying to convert it to a class type, which
> doesn't work, but because of the PTRMEM_CST check below we never diagnosed it.
>
> The comment says a PTRMEM_CST is a valid template argument for a parameter of
> pointer to member type, but it doesn't check that that's what we're converting
> it to. Fixed by adding such a check.
>
> Bootstrapped/regtested on x86_64-linux, ok for trunk?
OK.
Jason
prev parent reply other threads:[~2018-12-21 2:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-20 22:19 Marek Polacek
2018-12-21 2:51 ` Jason Merrill [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf7d121a-43f6-d167-f5a1-1875687e1715@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=polacek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).