From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 86085 invoked by alias); 12 Sep 2018 22:25:44 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 86076 invoked by uid 89); 12 Sep 2018 22:25:43 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=bld, H*Ad:D*dk, H*F:D*dk, parlance X-HELO: mail-lf1-f65.google.com Received: from mail-lf1-f65.google.com (HELO mail-lf1-f65.google.com) (209.85.167.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Sep 2018 22:25:41 +0000 Received: by mail-lf1-f65.google.com with SMTP id x207-v6so3099370lff.3 for ; Wed, 12 Sep 2018 15:25:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=6p3uU+wEXOsSWV+2sBD3ENcJAKFMj4U4+XrRODi+qCQ=; b=IOuAre/N/FrRg0nm1Li5ruSOoBVLgVKX2fIbcLmZvb1pISgDyIkaND15R++JqLISoQ qAArvmREUDQWD7f9OG7y8ThFoAN/59QzFJb5SvMz77JUAa9PoEM+Q/MiN/H3v7isOFSo uxcsIrW49ZygEDQEqH/lD7spW5m75oERtcK78= Return-Path: Received: from [192.168.0.189] (dhcp-5-186-115-161.cgn.ip.fibianet.dk. [5.186.115.161]) by smtp.gmail.com with ESMTPSA id u24-v6sm369113lji.4.2018.09.12.15.25.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Sep 2018 15:25:38 -0700 (PDT) Subject: Re: [PATCH] fixincludes: vxworks: regs.h: Guard include of vxTypesOld.h by !_ASMLANGUAGE To: Olivier Hainque Cc: gcc-patches@gcc.gnu.org, bkorb@gnu.org References: <20180627142715.10534-1-rv@rasmusvillemoes.dk> From: Rasmus Villemoes Message-ID: Date: Thu, 13 Sep 2018 00:46:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-09/txt/msg00660.txt.bz2 On 2018-09-05 11:38, Olivier Hainque wrote: > Hi Rasmus, > > I think we should either do a fixinclude that would "work" for > C and ASM (like #include vxCpu for ASM, vxTypesOld otherwise), or > simply remove this hack (just using the fixinclude parlance here). > > My inclination would be for the latter. > [snip] > > What happens on your end if you just remove the hack ? > Unfortunately, the libstdc++ build breaks: In file included from /usr/powerpc-wrs-vxworks/wind_base/target/h/regs.h:66:0, from /bld/vestas/auto/work.20180912.214646/gcc-build/gcc/include-fixed/setjmp.h:57, from /bld/vestas/auto/work.20180912.214646/gcc-build/powerpc-wrs-vxworks/libstdc++-v3/include/csetjmp:42, from /bld/vestas/auto/work.20180912.214646/gcc-src/libstdc++-v3/include/precompiled/stdc++.h:42: /usr/powerpc-wrs-vxworks/wind_base/target/h/arch/ppc/regsPpc.h:33:5: error: 'UINT32' does not name a type UINT32 cr; /* condition register */ ^~~~~~ I'm happy to add an include of vxCpu in the _ASMLANGUAGE case, along with a big comment. But, it's also a small enough patch that we can carry it internally, if you prefer that we don't touch this hack upstream. Thanks, Rasmus