From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29]) by sourceware.org (Postfix) with ESMTPS id 1CF613858C62 for ; Wed, 3 Jan 2024 20:14:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1CF613858C62 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1CF613858C62 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d29 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704312895; cv=none; b=srPliyOyL5UrljMTzDvpnGevj8AZpTkILT2NvdBOzuU5j8PyjgbrFTyI6ay2GVXuczhbD81676QH+kMNsi0VuvQ616JFyQqKYsg7M/eEtA3A3VTmvkx/ioLE6dXia2kHWQcVty3EOroDUXP0NqzKvCLfaWYNKOXgZf6nY2tlcLw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704312895; c=relaxed/simple; bh=z87w4bPwtxoa9MAI8EefmYIc99IvyUHf7qQdEiKCDsY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=bGwxK8AZA6Fn+P1HuHc5C1jIVta9fj+LeAWQXAU5Btxh/dnnY6AykhZsnwUO6DWTrEpglLyfzFISCyFkAfArv1PQiyuRFqLdrgX980DqyW1BoAqxM5qW4drVPO4QdnmrHDdLxmsx8AGNMCpeb7vFcyRGOJMIa2Wb8VjCr7eEu2A= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd29.google.com with SMTP id ca18e2360f4ac-7ba8e33dd0cso497556639f.0 for ; Wed, 03 Jan 2024 12:14:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704312893; x=1704917693; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=G2bcNQB3hpPYsjRSeU3hirdh4fgIEmO1mzwLonDGDtk=; b=Z+ba2QiH5/yNMBn06yvZjTMGUCN/TZ6l9Cf5ZEh4d3QV9Q9zyo2+s+JB8z2gtJ+D7B Grk+yw4AXEZ6bbmsJuAjRlD2JIVqEok9aNvct9hVYPgwyy6Osq2JUw3wsBrDONKwWnLi jEwgtWdcaN0Gr3GTOC1+0SQtpJXiOpvHdFrIJZDFSPdJemyjXXmJpuGonkTFk1wyWGXB iFCaviJB9Y2fuHD2DtOJxpLwVlcKts8L9BBfAZ+hddTOFdZU0Mg9CReWIGGtvneilrzF RK2l3DqLMninNNx6nM2J55YiQXMR3NrpF/igUPopo08F1U1Hup8QvLImKyX1pjWAZbLV 2rFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704312893; x=1704917693; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=G2bcNQB3hpPYsjRSeU3hirdh4fgIEmO1mzwLonDGDtk=; b=aRB5R3vurQMBUfjvsvq3yLNea6X61hH2RvjF6YOZZBAftSDe7CNz66LNaafePF1u6E 3HN3yCbcYuuj+4bxhBRR4bJvud7BfIRtg66Iw9AIvUY7Bbc1poEquTmP12RVTgWcQthH 7V1iq0KD3S8C8OpzTE/0gVwriReAqo+KClVHtEBi2G+PTu5J8VXXaZUPiLK4+krTXsg8 zHZudVVQZ2zzZ2vRKBX5vtgYF0Um3bgkxKJ1k8tQbVldB3J/GdAviQcfJTL1+IlmXrAx LKhq4Sm7LksYkEzg9UTnAap+8SVx8BIdx4WcUytqM4HCicVqxwDsT4kJzTKRiGXpPBfI 3SPQ== X-Gm-Message-State: AOJu0YxFLo0yGd/3k+fst08keEDVTsBHCIDngUm7ocUK4ULup5sxwQg3 fB9V3UwkQLnhomTmfqzhwpM= X-Google-Smtp-Source: AGHT+IH1EWQ6RzJH5lFc68H8r9bPjMnaQge8XmpCLapL4cJzdl5gV7ZzMbNC/4QpWwitAkkeAkWljA== X-Received: by 2002:a6b:6603:0:b0:7bb:eb7c:915d with SMTP id a3-20020a6b6603000000b007bbeb7c915dmr114205ioc.12.1704312893182; Wed, 03 Jan 2024 12:14:53 -0800 (PST) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id bq7-20020a056638468700b0046dd253eff8sm1028805jab.33.2024.01.03.12.14.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Jan 2024 12:14:52 -0800 (PST) Message-ID: Date: Wed, 3 Jan 2024 13:14:38 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFA] opts: -Werror=foo always implies -Wfoo [PR106213] Content-Language: en-US To: Jason Merrill , gcc-patches@gcc.gnu.org, Joseph Myers References: <20231219221731.2944661-1-jason@redhat.com> From: Jeff Law In-Reply-To: <20231219221731.2944661-1-jason@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SCC_BODY_URI_ONLY,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/19/23 15:17, Jason Merrill wrote: > Tested x86_64-pc-linux-gnu, OK for trunk? > > -- 8< -- > > -Werror=foo implying -Wfoo wasn't working for -Wdeprecated-copy-dtor, > because it is specified as the value 2 of warn_deprecated_copy, which shows > up as CLVC_EQUAL, which is not one of the three var_types handled by > control_warning_option. It seems to me that we can just unconditionally > handle_generated_option, and only have special argument handling for those > types. > > PR c++/106213 > > gcc/ChangeLog: > > * opts-common.cc (control_warning_option): Call > handle_generated_option for all cl_var_types. > > gcc/testsuite/ChangeLog: > > * g++.dg/cpp0x/depr-copy5.C: New test. OK jeff