From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 643B43858016 for ; Wed, 28 Sep 2022 16:48:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 643B43858016 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28SGOog8002095 for ; Wed, 28 Sep 2022 16:48:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=XHVMhj3N0Bxgnq8LugPRA/rmxHtn/1jlAaEks8w2KUA=; b=Bvwck62Cu7/a0cu9v2ANyD7+kjqM1rsI9vspGYjcXTgags9lTq/tgipY+awUsNcwmpdS b9p2icQH+o+v1fDSkkhDN+fq6qDa31LZ91JOH6iX8eUNpvtXpcYs9eng8E/Bc4CiTl6d W6sQZ5l6PXxclPWU+vyhBRKTsZ9LAw5KYVjrGbLWqhKdwN7zJA0B0HsT352nstFfMjBa qgFbqfS8Cp7tUtl2MIipO/2CD8DhawLJi75wkaU0xLBx71AuuBHi9yw7BosXFPYKOtKi pRW0aLnuKgoE+dy3P10vSbSBfwa2xmA+Zwi8/dOK52rRMXlqc79DTu65AymSxAad4Mj7 /Q== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3jvqxp4vw1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 28 Sep 2022 16:48:10 +0000 Received: from m0098417.ppops.net (m0098417.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 28SEvKK4007544 for ; Wed, 28 Sep 2022 16:48:10 GMT Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3jvqxp4vva-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Sep 2022 16:48:10 +0000 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 28SGa0T4020056; Wed, 28 Sep 2022 16:48:08 GMT Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by ppma06ams.nl.ibm.com with ESMTP id 3jss5j5h8c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Sep 2022 16:48:08 +0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 28SGm6Np4653702 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 28 Sep 2022 16:48:06 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3221DAE053; Wed, 28 Sep 2022 16:48:06 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EF711AE045; Wed, 28 Sep 2022 16:48:05 +0000 (GMT) Received: from [9.171.69.118] (unknown [9.171.69.118]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Wed, 28 Sep 2022 16:48:05 +0000 (GMT) Message-ID: Date: Wed, 28 Sep 2022 18:48:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [RFC] postreload cse'ing vector constants Content-Language: en-US To: "H.J. Lu" Cc: Jeff Law , gcc-patches@gcc.gnu.org References: <3b0984ef-c532-c29c-732a-1c9b569e134c@linux.ibm.com> <7ecca009-32ac-3b2f-e552-55414300113e@gmail.com> <70a54b9a-30ea-5673-3a41-9585b3abf627@linux.ibm.com> <5b687817-126e-d463-9d88-b3d7d2dad861@gmail.com> <7bd6cb29-a107-a7f2-463f-75bf811792a7@linux.ibm.com> From: Robin Dapp In-Reply-To: Content-Type: text/plain; charset=UTF-8 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: J1pBUCC0wn8-JqINyANNz2ZO_FQEzzmf X-Proofpoint-GUID: rNnHz6NQXBbOg7iWzuRfg5cJdoFCXAIp Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-28_07,2022-09-28_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 mlxlogscore=869 impostorscore=0 mlxscore=0 suspectscore=0 spamscore=0 priorityscore=1501 phishscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2209280099 X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,KAM_SHORT,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > I opened: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107061 The online docs for encodekey256 also say XMM4 through XMM6 are reserved for future usages and software should not rely upon them being zeroed. I believe we also zero there. > This sounds like an issue. So with your patch for encodekey128 the regression is gone and we zero (pxor) xmm0 in both versions. The case I outlined before does not actually happen since cprop_hardreg propagates the (newly) zeroed register to the use sites rather than zeroing every time. I guess this just leaves the situation where we implicitly know that a reg is zero and by rather zeroing another one we miss the cprop_hardreg opportunity. Not sure how common this is and if it's a blocker for this patch. No regressions on x86, aarch64, power9 and s390 now. Most likely we don't check to that granularity in the test suite and even here it was more of accidental hit.