From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2052.outbound.protection.outlook.com [40.107.22.52]) by sourceware.org (Postfix) with ESMTPS id 30B6B3858D1E for ; Tue, 4 Apr 2023 12:10:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 30B6B3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IiJMlxTQ7AsQMyJ12fDZeGgSryGasB8xASQ1X3aDLwA=; b=OcVUQe+j9I+eVuaa1OPPa9BNVSnk0W9CWUr0GwsNij93NEuyJ8RnNG9R544GsXp2pf0GWDEd6AJ+2EdfHazknl+Eecq6P3Hb5ASZPga9QQ8ccLze2Ad7+XZIhJ73VEpjwGJC+2WCFrGrFvvc5NeCFIWT9PTuewFBLWlXJsV4LEk= Received: from DB6P192CA0006.EURP192.PROD.OUTLOOK.COM (2603:10a6:4:b8::16) by PA4PR08MB7643.eurprd08.prod.outlook.com (2603:10a6:102:261::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Tue, 4 Apr 2023 12:10:39 +0000 Received: from DBAEUR03FT033.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:b8:cafe::56) by DB6P192CA0006.outlook.office365.com (2603:10a6:4:b8::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.29 via Frontend Transport; Tue, 4 Apr 2023 12:10:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT033.mail.protection.outlook.com (100.127.142.251) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.16 via Frontend Transport; Tue, 4 Apr 2023 12:10:39 +0000 Received: ("Tessian outbound 3570909035da:v136"); Tue, 04 Apr 2023 12:10:39 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 4dab451953569085 X-CR-MTA-TID: 64aa7808 Received: from d5cd263e9123.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 64480783-327E-465F-BDE7-0A2CA0628B35.1; Tue, 04 Apr 2023 12:10:32 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d5cd263e9123.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 04 Apr 2023 12:10:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gRHLCAAKK4cDRSHtkaJ+309xnlnT0PMmpajpSyx8ftvd05mavdPBVFzndAhbEi5KN99LejB/6NTpD4kbqe+66ncf91jmT0x29MTUUUeiBH0XxWghHVeXebeJgKbW6jNAr6vC+FRUEgBtwNdfvnkpYjpWRuvwDEBln61u6V2PoGYMU3c7Aq1EEGdkLPkmXacEvJY8+R79AuAcsYz6AobGdta0Ifozn/3G0d6ULugHqNp1S+arEVJcWlxtVXKkq9bRWGtL9Q8qIWmyhDurQnWCwsO4qpYTCPGYU7RXhIESs/HiT5HU7RTDY+Ki3jhuZugysOCoDzzfAk2WjPLeK/ZpYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IiJMlxTQ7AsQMyJ12fDZeGgSryGasB8xASQ1X3aDLwA=; b=B7/RBmJyegOZiZosz8tLZB6uuJRPlwEdazSzcRhs/xDHzUAAklZGByUIye+F5kuKTBPgVXpsiaASzNQarNHucBpbh+j7KXasMZ2ver5OKudnJkaQ6Jn+nKEe7qat2HcuSl7lE87Immd7iJ/WD2T17KZ2uMW88uJI2MiDpVMCM4OdfKQoTaxEPnDCsbEDRVrgaOgwYaq+tDjN3R7KfL/u/UAjgz4y9oBzcOKeCWjUsH+HOB8tZfVulbqw+k4LDjljpuExQAppNvCnvXttghO8RH+KQ9z1kw2+K2eKMEicdALsg+r9SwgzUiMhovMO3KMCyr9DNxNf6eC3e8xdrDaF8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IiJMlxTQ7AsQMyJ12fDZeGgSryGasB8xASQ1X3aDLwA=; b=OcVUQe+j9I+eVuaa1OPPa9BNVSnk0W9CWUr0GwsNij93NEuyJ8RnNG9R544GsXp2pf0GWDEd6AJ+2EdfHazknl+Eecq6P3Hb5ASZPga9QQ8ccLze2Ad7+XZIhJ73VEpjwGJC+2WCFrGrFvvc5NeCFIWT9PTuewFBLWlXJsV4LEk= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB9PR08MB6507.eurprd08.prod.outlook.com (2603:10a6:10:25a::6) by GV1PR08MB8689.eurprd08.prod.outlook.com (2603:10a6:150:82::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Tue, 4 Apr 2023 12:10:29 +0000 Received: from DB9PR08MB6507.eurprd08.prod.outlook.com ([fe80::9f9c:a12a:8291:5530]) by DB9PR08MB6507.eurprd08.prod.outlook.com ([fe80::9f9c:a12a:8291:5530%6]) with mapi id 15.20.6254.033; Tue, 4 Apr 2023 12:10:26 +0000 Message-ID: Date: Tue, 4 Apr 2023 13:10:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 From: Stamatis Markianos-Wright Subject: Re: arm: Fix MVE vcreate definition To: Kyrylo Tkachov , "gcc-patches@gcc.gnu.org" References: Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0688.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:37b::17) To DB9PR08MB6507.eurprd08.prod.outlook.com (2603:10a6:10:25a::6) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DB9PR08MB6507:EE_|GV1PR08MB8689:EE_|DBAEUR03FT033:EE_|PA4PR08MB7643:EE_ X-MS-Office365-Filtering-Correlation-Id: e822bbc2-b232-4181-09ba-08db35059ac6 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: d6Nh3f3qs5CS22gCwHdHFxKT4bQl8wIrTAlnEvVciSbStoTF8c7W4tTcrjL1x/suW2Y4XA11/KUNb0zA6eV0H0IeeNVlolKD28jg9d5NuPZFiHjyK5lKdXBa4fwseIwrRMctYfHDZYIzsk0f5LPf36j4QDwjLucnOChZDVG/GavdJrh4MdBE31APahINwoqVEcCWH/o8BEEHV9HDWC1peo2gdVaHWS3qeo/wcqWCRjXtbo3XmyAAT7t+6W4X7xMq+Gjk6hkQRGWgYYoUOacEn/y+Bv+t7jU+8MOmmNOHT0mXgt66VdOgFh+CbSlE/ecjvYOwlVAcN80sR6VYDwvvHpkt5V2D/oR4qZnNP7a1A/HDq3NFyfHu/edHuOBiVrwce+Fe7KnwhXFICxRCgQ+LEWwoqd9eeJ73MJCLrjYLGNPs7S2UZDDLeucyt3hYysRaOA6hezmFe8amaoViRRM3ikOeIJvxGuqowoVTkSuBgcA8SljAl2BkVlvrHclA6qLwgR42R3T7XOL3Hs4ABUmtlpXN068JJgkpukqZif1jyQsULzDsKsdqIbfZtJ3i1Kl0XfypKRtkCliGRmzLC16SuIo4ZILBvQBRvxp2vr0GukzA/gRWG/qRH09BfJpsG+y/UqYzShg68ZLfTP3ouGW1ugkhVqXulPq2s3bO2BT37yEBeVivzTZl3pOUvqqlZtj1 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR08MB6507.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(346002)(376002)(396003)(366004)(39860400002)(451199021)(83380400001)(2616005)(6486002)(966005)(6506007)(316002)(110136005)(6512007)(478600001)(186003)(26005)(53546011)(2906002)(5660300002)(38100700002)(66476007)(66946007)(66556008)(41300700001)(86362001)(8676002)(8936002)(31696002)(36756003)(84970400001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8689 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 99c7374f-a1ad-4ac2-21bb-08db350592bf X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TGEQr8vnNNLI1FC21yfCzHGAIi5tyEsv/jepN7nNypLXZ/757eBDAdW0dugdqb8Cgh122FYr0DtocGhPdIRZHRFR4flVPWgTGhjaD7GA1GFel1ZGREWh58UDpZgd1FmS1ZIVhg4N0UkrSipoEGGKJqItGLr2IeBXt/7q/FhvZ+0UtYXghm0HQYxTi6HmLwuMEJ4zTybUSnkt95KdvasnN5U7AAfBvwh8PxOh3iZJahcdta1f24hEgzc50ncUro/Mu1zlboKojGb+zsrk5c97u98b4q5v8Tpu6gXnWA7aW5t0vUlun5d3sCVt0TDaKGkglvT1OR+orlefMqjSdJgQpsXCBDUv4BiPG4cqj+wFf/mxlAnpPlQMJ+PsAUQeEqUd1L8bZ0ZwiZvR3wmRDq4H2Dt99cvDnU7TaxC4HsAmEUCtJX0pKytxAbdl3ik6wk513BMT1Ikd7dtdWtJ53RZ5hPVpBWK1tFxydxJvBtQy8iA9zAez3BdaDp/nHs7lBOuy9/slkUeXDQ6hq+mvxjeZ3rzCE8J31LZgK4sf3s5TesW09vF8sb0V5AJM/ox3ML+p0JDfiuYQNWkzAzJp/IkhdsPvUwivnPLO39uXJd/BKj+NC3TK1Bjq6SvE3uwGYzdMa/QOSaY74gGWniHw9pJMxEyT01i9cXuVTSQsCxjelKomfIwIHrx7V4Ej5AKpNkmTSrIatxR1Ra9MNI3OZqErzfFiKFig92QLQWIZH5/IYkXg3fnBPhmDxXsYgwHwSkAEzZmgSgUyYhF4i41YN1TcnA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(136003)(39860400002)(376002)(346002)(396003)(451199021)(46966006)(36840700001)(40470700004)(186003)(82310400005)(26005)(53546011)(6506007)(41300700001)(336012)(2616005)(6512007)(70586007)(316002)(478600001)(70206006)(110136005)(47076005)(8676002)(6486002)(36756003)(40460700003)(82740400003)(356005)(81166007)(86362001)(31696002)(2906002)(36860700001)(83380400001)(8936002)(5660300002)(84970400001)(31686004)(40480700001)(966005)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 12:10:39.0835 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e822bbc2-b232-4181-09ba-08db35059ac6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB7643 X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 29/03/2023 13:16, Kyrylo Tkachov wrote: >> -----Original Message----- >> From: Stam Markianos-Wright >> Sent: Wednesday, March 29, 2023 11:50 AM >> To:gcc-patches@gcc.gnu.org >> Cc: Kyrylo Tkachov >> Subject: arm: Fix MVE vcreate definition >> >> Hi all, >> >> I just found a bug that goes back to the initial merge of >> the MVE backend: The vcreate intrinsic has had it's vector >> lanes mixed up, compared to what was intended (as per >> the ACLE) definition. This is also a discrepancy with clang: >> https://godbolt.org/z/4n93e5aqj >> >> This patches simply switches the operands around and >> makes the tests more specific on the input registers >> (I do not touch the output Q regs as they vary based >> on softfp/hardfp or the input registers when the input >> is a constant, since, in that case, a single register >> is loaded with a constant and then the same register is >> used twice as "vmov q0[2], q0[0], r2, r2" and the reg >> num might also not always be guaranteed). >> >> No regressions on MVE tesctsuite configurations or in >> the CMSIS-NN testsuite. >> >> Ok for trunk? (Despite this being late in Stage 4, sorry >> about that!) > Ok, since this is a wrong-code fix. Thanks, applied as: 3f0ca7a3e4431534bff3b8eb73709cc822e489b0. > This needs backports as well, right? Indeed! I'm building up a larger list of commits that we're hoping to backport, so I will include this on that list. > Thanks, > Kyrill > >> Thanks, >> Stamatis Markianos-Wright >> >> gcc/ChangeLog: >> >>         * config/arm/mve.md (mve_vcvtq_n_to_f_): Swap >> operands. >>           (mve_vcreateq_f): Swap operands. >> >> gcc/testsuite/ChangeLog: >> >>         * gcc.target/arm/mve/intrinsics/vcreateq_f16.c: Tighten test. >>         * gcc.target/arm/mve/intrinsics/vcreateq_f32.c: Tighten test. >>         * gcc.target/arm/mve/intrinsics/vcreateq_s16.c: Tighten test. >>         * gcc.target/arm/mve/intrinsics/vcreateq_s32.c: Tighten test. >>         * gcc.target/arm/mve/intrinsics/vcreateq_s64.c: Tighten test. >>         * gcc.target/arm/mve/intrinsics/vcreateq_s8.c: Tighten test. >>         * gcc.target/arm/mve/intrinsics/vcreateq_u16.c: Tighten test. >>         * gcc.target/arm/mve/intrinsics/vcreateq_u32.c: Tighten test. >>         * gcc.target/arm/mve/intrinsics/vcreateq_u64.c: Tighten test. >>         * gcc.target/arm/mve/intrinsics/vcreateq_u8.c: Tighten test.