From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 71D283858D32 for ; Mon, 15 May 2023 06:46:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 71D283858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0353723.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34F6e7vx016583; Mon, 15 May 2023 06:46:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=obsQxI+MjxELeFnGkcTJquFACBEulA8R634NoG1TThg=; b=FBvyKou+iVmyS21wZ8aN+prl0DgbnxlhGlqPgiIvShxEpV/lAj8qez9dNh9F/zTfL1eW Fxaks6JIWL8FO8jRwP/9hBPJR5e4gBRM+F+0VxJ0h8ToQeRDtnFXCd9RO90ApH/kJ8mL mOIlQUDV3yP7DEuF1gQ/n3yLJASD2Ju+fSxzTzAf2ZEOGDgxbaodqb46t9XDZHtlC1qa 4PTXY+7VP5V3KoCw5oB1gUY01eKnKZRwqc7zzGnU3u9LfQvG8iMmNSUy8TkpBca6qRVJ Zj1siohGqy8tzxWWbqIoMDXbAVIHPVktcT5cB+Rsv5AiRyGuyERBr8HitjqvDvbzPMvW Kw== Received: from ppma05fra.de.ibm.com (6c.4a.5195.ip4.static.sl-reverse.com [149.81.74.108]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3qkdy9jqq7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 May 2023 06:46:28 +0000 Received: from pps.filterd (ppma05fra.de.ibm.com [127.0.0.1]) by ppma05fra.de.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 34F1dB9P030323; Mon, 15 May 2023 06:46:26 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma05fra.de.ibm.com (PPS) with ESMTPS id 3qj264rrhx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 May 2023 06:46:26 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 34F6kOf813828622 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 15 May 2023 06:46:24 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id ECA6620043; Mon, 15 May 2023 06:46:23 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2D29C20040; Mon, 15 May 2023 06:46:22 +0000 (GMT) Received: from [9.177.27.227] (unknown [9.177.27.227]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 15 May 2023 06:46:21 +0000 (GMT) Message-ID: Date: Mon, 15 May 2023 14:46:20 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] rs6000: Fix test gc.target/powerpc/rs600-fpint.c test options Content-Language: en-US To: Carl Love Cc: Peter Bergner , gcc-patches@gcc.gnu.org, Segher Boessenkool References: From: "Kewen.Lin" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: rT4PU5fIUi2GRKR7niyw3zdsgTmUDlLU X-Proofpoint-GUID: rT4PU5fIUi2GRKR7niyw3zdsgTmUDlLU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-05-15_04,2023-05-05_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 mlxscore=0 suspectscore=0 mlxlogscore=999 malwarescore=0 priorityscore=1501 impostorscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000 definitions=main-2305150058 X-Spam-Status: No, score=-14.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Carl, on 2023/4/14 03:42, Carl Love via Gcc-patches wrote: > > GCC maintainers: > > The following patch fixes the dg-options for test powerpc/rs600- > fpint.c. The test now works correctly on Power 10. The patch has been > tested on Power10 with no regressions. > > Please let me know if the patch is acceptable for mainline. Thanks. OK for trunk with one more comment added in commit log ... > > Carl > > --------------------------------- > rs6000: Fix test gc.target/powerpc/rs600-fpint.c test options > > The test compile option rs6000-*-* is outdated and no longer supported. > The powerpc*-*-* is the defualt, so it doesn't need to be specified. > The dg-options needs to specify an older processor to get the desired > behavior on recent processors. ... such as: ", since gfxopt is only off for very old CPUs, we don't guard stfiwx under it for recent processors and don't want to." Thanks for fixing! BR, Kewen > > This patch updates the test specifications so the test will run properly on > Power10LE. Tested on Power10 LE system with no regression test failures. > > gcc/testsuite/: > * gcc.target/powerpc/rs6000-fpint.c: Update dg-options, drop dg-do > compile specifier. > --- > gcc/testsuite/gcc.target/powerpc/rs6000-fpint.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/gcc/testsuite/gcc.target/powerpc/rs6000-fpint.c b/gcc/testsuite/gcc.target/powerpc/rs6000-fpint.c > index 410f780de8b..fdb0a371929 100644 > --- a/gcc/testsuite/gcc.target/powerpc/rs6000-fpint.c > +++ b/gcc/testsuite/gcc.target/powerpc/rs6000-fpint.c > @@ -1,5 +1,4 @@ > -/* { dg-do compile { target powerpc*-*-* rs6000-*-* } } */ > -/* { dg-options "-mno-powerpc-gfxopt" } */ > +/* { dg-options "-mno-powerpc-gfxopt -mdejagnu-cpu=power6" } */ > /* { dg-final { scan-assembler-not "stfiwx" } } */ > > /* A basic test of the old-style (not stfiwx) fp -> int conversion. */