From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71020 invoked by alias); 21 Jan 2018 14:43:48 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 71010 invoked by uid 89); 21 Jan 2018 14:43:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=blindly X-HELO: codesynthesis.com Received: from codesynthesis.com (HELO codesynthesis.com) (142.44.161.217) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 21 Jan 2018 14:43:45 +0000 Received: from brak.codesynthesis.com (unknown [66.251.163.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by codesynthesis.com (Postfix) with ESMTPSA id 05CDE5F3E7; Sun, 21 Jan 2018 14:43:43 +0000 (UTC) Received: by brak.codesynthesis.com (Postfix, from userid 1000) id B37361A800D1; Sun, 21 Jan 2018 16:43:38 +0200 (SAST) Date: Sun, 21 Jan 2018 18:30:00 -0000 From: Boris Kolpackov To: Ximin Luo Cc: gcc-patches@gcc.gnu.org, Joseph Myers , Martin Sebor , David Malcolm Subject: Re: [PATCH v3] Ability to remap file names in __FILE__, etc (PR other/70268) Message-ID: References: <1512575884.27881.141.camel@redhat.com> <46cf88dc-18e7-f20e-0d97-6ee8e0a33e18@gmail.com> <94bd2034-9157-da7f-cda3-04a8037f9e6d@pwned.gg> <9cfe030c-bfce-ba03-2005-bc157babffe3@pwned.gg> <627a7b2a-5aca-2e98-4700-8a39cfb1eede@pwned.gg> <3baf36b0-1325-98a8-ef3c-1805b2397bde@pwned.gg> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3baf36b0-1325-98a8-ef3c-1805b2397bde@pwned.gg> User-Agent: Mutt/1.5.24 (2015-08-30) X-SW-Source: 2018-01/txt/msg01833.txt.bz2 Ximin Luo writes: > -I to an absolute path is not that common for system / distro-built > stuff. Ok, thanks for clarifying. > In the cases that it occurs, indeed it could and should be fixed > by the package buildsystem, e.g. by stripping a prefix when they > add -I flags to CFLAGS. But that's a separate issue from what > we're talking about here. I believe it is the same issue: any package that blindly embeds information about how it was built into the result of the build does not care about reproducible builds. If others do agree that this should be "fixed" in GCC, then I would suggest that you add a separate option for the environment variable case (e.g., -ffile-prefix-map-env) and sidestep the whole "how to portably distinguish a path from an environment variable" issue. Boris