From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by sourceware.org (Postfix) with ESMTPS id C7DE13858C41 for ; Fri, 19 May 2023 17:04:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C7DE13858C41 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-64d293746e0so1916930b3a.2 for ; Fri, 19 May 2023 10:04:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684515846; x=1687107846; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KK5Pdml605i9FEgrUUKfEKAi+cSxLbW29SLF1jvnFAE=; b=bJRjwbOTcLuZfgHr8QhAQSdTG9eWKYsFMACjZVmzWdmAl2b4G7C3VszMVRvDriJ3rv T4By5aaMgzmGdAa1HorOoCKiEL3g8Vwnp1XEuE5efYX1vBeYS8cDVUe2HNxmHbysY2rB tCghiBxBf7q0DclV13tso5eGUDLYAWM4pAJQitJPsMhFZu+LtVnO4dB2EJ1CP6I0xQsD pxSYyOMCEselvga27pvrR8fa1tWWC89BwvoBo3lqq0fs+gOvgvvOjfGw4bIfNFmhopfa 87XUv4p/jq3AfIcHTFMxXuJEOyl0njcsoU2IX93htQlcY+OMMs1Ujv1lBHwOHilWsnVV iwYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684515846; x=1687107846; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KK5Pdml605i9FEgrUUKfEKAi+cSxLbW29SLF1jvnFAE=; b=Ze5bphWfvI6Kbax3eKHwk9NepbaSjIrtARm/1Clts8ZOQYShkmOFbxNYTXVS+9QA0c bpdariv/Lukem3dfFLEhExsYANnsp5MHBErNE618/jNIiZDxfgmEz6U2wWss15bUiA8N DbNf6lHantSy4QZmpUCb6XKqhl50+ui98xjREZV0IWBzcvh2REVm/7v8uh1yT8WGJ37Q QCtCxOwgPEzk/l0IrqayD3KjN3eYs7rsCRglPYbiG2/AiLyfWA5XIRVYTIjPuU3ProGU 3/w1Af/OEin+Nf9OMbfKi/g80xFbs7ff0hYmoNTCRhiD7L3ypoQwsZPsf6qoDQ6KWZ63 E8cA== X-Gm-Message-State: AC+VfDyAMY0idWaDWmW8dqLZYGqF4Col84kOQtt4czN1ZPJKGlld5t+v w4yguRozlEiN1jf+xo8Df5RxthoOM8I= X-Google-Smtp-Source: ACHHUZ5DdYONH5NY4+iP0g4za5eG5HOjMHJcrClIddiGG7ABQ0mSMLDaCXTZtu8INNB4BHAMGNOioQ== X-Received: by 2002:a05:6a20:e68e:b0:104:41a0:c51a with SMTP id mz14-20020a056a20e68e00b0010441a0c51amr2665463pzb.38.1684515845613; Fri, 19 May 2023 10:04:05 -0700 (PDT) Received: from ?IPV6:2601:681:8d00:265::f0a? ([2601:681:8d00:265::f0a]) by smtp.gmail.com with ESMTPSA id f12-20020a63e30c000000b004ff6b744248sm3330139pgh.48.2023.05.19.10.04.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 May 2023 10:04:04 -0700 (PDT) Message-ID: Date: Fri, 19 May 2023 11:04:03 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [patch,avr] PR105753: Fix ICE in add_clobbers. Content-Language: en-US To: Georg-Johann Lay , gcc-patches@gcc.gnu.org Cc: Denis Chertykov References: <94de26a3-c29c-6deb-59e2-da23411bef61@gjlay.de> From: Jeff Law In-Reply-To: <94de26a3-c29c-6deb-59e2-da23411bef61@gjlay.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/16/23 02:56, Georg-Johann Lay wrote: > This patch removes the superfluous parallel in [u]divmod patterns > in the AVR backend.  Effect of extra parallel is that add_clobbers > reaches gcc_unreachable() because the clobbers for [u]divmod are > missing.  The parallel around the parts of an insn pattern is > implicit if it has multiple parts like clobbers, so extra parallel > should be removed. > > Ok to apply? > > Johann > > -- > > gcc/ >     PR target/105753 >     * config/avr/avr.md (divmodpsi, udivmodpsi, divmodsi, udivmodsi): >     Remove superfluous "parallel" in insn pattern. >     ([u]divmod4): Tidy code.  Use gcc_unreachable() instead of >     printing error text to assembly. > > gcc/testsuite/ >     PR target/105753 >     * gcc.target/avr/torture/pr105753.c: New test. OK jeff