From: "Kewen.Lin" <linkw@linux.ibm.com>
To: Claudiu Zissulescu <Claudiu.Zissulescu@synopsys.com>
Cc: "gnu@amylaar.uk" <gnu@amylaar.uk>,
"andrew.burgess@embecosm.com" <andrew.burgess@embecosm.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: [PATCH 02/11 v2] arc: Remove define_insn_and_split *bbit_di
Date: Wed, 2 Jun 2021 15:43:47 +0800 [thread overview]
Message-ID: <c09e5fa0-02cb-0d0d-07ed-f291f30b064a@linux.ibm.com> (raw)
In-Reply-To: <MW2PR12MB23469CE5A0F3B34F9E3070E6CA3D9@MW2PR12MB2346.namprd12.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 494 bytes --]
Hi Claudiu,
on 2021/6/2 下午3:12, Claudiu Zissulescu wrote:
> Hi Kewen,
>
> Maybe it is best just to remove the pattern entirely, I couldn't exercise it myself. I was secretly hopping someone could do it.
> Please can you submit a patch which removes it if it is not too much trouble?
>
The patch v2 has been attached which removes define_insn_and_split "*bbit_di" as you suggested.
Does it look good to you?
BR,
Kewen
-----
gcc/ChangeLog:
* config/arc/arc.md (*bbit_di): Remove.
[-- Attachment #2: arc_v2.diff --]
[-- Type: text/plain, Size: 1419 bytes --]
diff --git a/gcc/config/arc/arc.md b/gcc/config/arc/arc.md
index b6f2d8e28be..a67bb581003 100644
--- a/gcc/config/arc/arc.md
+++ b/gcc/config/arc/arc.md
@@ -5016,34 +5016,6 @@ (define_insn "*bbit"
(if_then_else (match_test "get_attr_length (insn) == 6")
(const_string "true") (const_string "false")))])
-; ??? When testing a bit from a DImode register, combine creates a
-; zero_extract in DImode. This goes via an AND with a DImode constant,
-; so can only be observed on 64 bit hosts.
-(define_insn_and_split "*bbit_di"
- [(set (pc)
- (if_then_else
- (match_operator 3 "equality_comparison_operator"
- [(zero_extract:DI (match_operand:SI 1 "register_operand" "Rcqq,c")
- (const_int 1)
- (match_operand 2 "immediate_operand" "L,L"))
- (const_int 0)])
- (label_ref (match_operand 0 "" ""))
- (pc)))
- (clobber (reg:CC_ZN CC_REG))]
- "!CROSSING_JUMP_P (insn)"
- "#"
- ""
- [(parallel
- [(set (pc) (if_then_else (match_dup 3) (label_ref (match_dup 0)) (pc)))
- (clobber (reg:CC_ZN CC_REG))])]
-{
- rtx xtr;
-
- xtr = gen_rtx_ZERO_EXTRACT (SImode, operands[1], const1_rtx, operands[2]);
- operands[3] = gen_rtx_fmt_ee (GET_CODE (operands[3]), GET_MODE (operands[3]),
- xtr, const0_rtx);
-})
-
;; -------------------------------------------------------------------
;; Hardware loop
;; -------------------------------------------------------------------
next prev parent reply other threads:[~2021-06-02 7:43 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 5:04 [RFC/PATCH 00/11] Fix up some unexpected empty split conditions Kewen Lin
2021-06-02 5:04 ` [PATCH 01/11] gen: Emit error msg for empty split condition Kewen Lin
2021-06-02 7:04 ` Richard Biener
2021-06-02 7:27 ` Kewen.Lin
2021-06-02 7:43 ` Richard Biener
2021-06-02 8:18 ` Kewen.Lin
2021-06-02 23:35 ` Segher Boessenkool
2021-06-04 19:03 ` Martin Sebor
2021-06-04 19:37 ` Segher Boessenkool
2021-06-02 5:04 ` [PATCH 02/11] arc: Update unexpected " Kewen Lin
2021-06-02 6:52 ` Claudiu Zissulescu
2021-06-02 7:05 ` Kewen.Lin
2021-06-02 7:12 ` Claudiu Zissulescu
2021-06-02 7:43 ` Kewen.Lin [this message]
2021-06-02 8:33 ` [PATCH 02/11 v2] arc: Remove define_insn_and_split *bbit_di Claudiu Zissulescu
2021-06-02 5:04 ` [PATCH 03/11] arm: Update unexpected empty split condition Kewen Lin
2021-06-02 9:02 ` Kyrylo Tkachov
2021-06-02 5:04 ` [PATCH 04/11] cris: " Kewen Lin
2021-06-02 12:45 ` Hans-Peter Nilsson
2021-06-03 5:45 ` Kewen.Lin
2021-06-03 16:12 ` Hans-Peter Nilsson
2021-06-03 22:33 ` Hans-Peter Nilsson
2021-06-04 3:25 ` Kewen.Lin
2021-06-02 5:04 ` [PATCH 05/11] h8300: " Kewen Lin
2021-06-02 17:10 ` Jeff Law
2021-06-02 5:04 ` [PATCH 06/11] i386: " Kewen Lin
2021-06-02 6:28 ` Uros Bizjak
2021-06-02 5:04 ` [PATCH 07/11] m68k: " Kewen Lin
2021-06-02 17:08 ` Jeff Law
2021-06-02 5:04 ` [PATCH 08/11] mips: " Kewen Lin
2021-06-02 17:11 ` Jeff Law
2021-06-02 5:04 ` [PATCH 09/11] or1k: " Kewen Lin
2021-06-02 5:05 ` [PATCH 10/11] sh: " Kewen Lin
2021-06-02 5:17 ` Oleg Endo
2021-06-02 5:05 ` [PATCH 11/11] sparc: " Kewen Lin
2021-06-02 8:11 ` [RFC/PATCH 00/11] Fix up some unexpected empty split conditions Richard Sandiford
2021-06-02 8:37 ` Kewen.Lin
2021-06-02 9:13 ` Richard Sandiford
2021-06-02 10:01 ` Kewen.Lin
2021-06-02 10:12 ` Richard Biener
2021-06-02 17:32 ` Richard Sandiford
2021-06-02 18:25 ` Jeff Law
2021-06-02 23:52 ` Segher Boessenkool
2021-06-03 5:22 ` Kewen.Lin
2021-06-03 8:00 ` Segher Boessenkool
2021-06-03 9:18 ` Segher Boessenkool
2021-06-04 2:57 ` Kewen.Lin
2021-06-07 7:12 ` Richard Biener
2021-06-08 1:45 ` Kewen.Lin
2021-06-07 23:50 ` Segher Boessenkool
2021-06-08 2:09 ` Kewen.Lin
2021-06-08 7:08 ` Richard Biener
2021-06-08 12:30 ` Segher Boessenkool
2021-06-08 12:50 ` Richard Biener
2021-06-03 17:11 ` Jeff Law
2021-06-03 22:19 ` Segher Boessenkool
2021-06-03 8:05 ` Richard Sandiford
2021-06-03 10:01 ` Segher Boessenkool
2021-06-03 10:25 ` Richard Sandiford
2021-06-03 21:25 ` Segher Boessenkool
2021-06-03 21:34 ` Jakub Jelinek
2021-06-04 3:33 ` Kewen.Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c09e5fa0-02cb-0d0d-07ed-f291f30b064a@linux.ibm.com \
--to=linkw@linux.ibm.com \
--cc=Claudiu.Zissulescu@synopsys.com \
--cc=andrew.burgess@embecosm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gnu@amylaar.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).