public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Edwin Lu <ewlu@rivosinc.com>
To: Kito Cheng <kito.cheng@gmail.com>
Cc: gcc-patches@gcc.gnu.org, gnu-toolchain@rivosinc.com,
	rdapp.gcc@gmail.com, monk.chiang@sifive.com
Subject: Re: [Committed V2] RISC-V: Specify mtune and march for PR113742
Date: Wed, 21 Feb 2024 09:41:48 -0800	[thread overview]
Message-ID: <c0a72856-0a3c-42da-8067-4dd5cb3b8b35@rivosinc.com> (raw)
In-Reply-To: <CA+yXCZDNqcy_CjzD3df9+yPvg8V_G2ssaYVhSEffuJRECcFJZA@mail.gmail.com>

Committed

Edwin

On 2/20/2024 5:36 PM, Kito Cheng wrote:
> LGTM, thanks for fixing that issue :)
>
> On Wed, Feb 21, 2024 at 6:03 AM Edwin Lu <ewlu@rivosinc.com> wrote:
>> The testcase pr113742.c is failing for 32 bit targets due to the following cc1
>> error:
>> cc1: error: ABI requries '-march=rv64'
>>
>> Specify '-march=rv64gc' with '-mtune=sifive-p600-series'
>>
>> V1: https://gcc.gnu.org/pipermail/gcc-patches/2024-February/645609.html
>>
>>          PR target/113742
>>
>> gcc/testsuite/ChangeLog:
>>
>>          * gcc.target/riscv/pr113742.c: change mcpu to mtune and add march
>>
>> Signed-off-by: Edwin Lu <ewlu@rivosinc.com>
>> ---
>> V1: use require-effective-target
>> V2: switch to specifying march and mtune
>> ---
>>   gcc/testsuite/gcc.target/riscv/pr113742.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/gcc/testsuite/gcc.target/riscv/pr113742.c b/gcc/testsuite/gcc.target/riscv/pr113742.c
>> index ab8934c2a8a..573afd6f0ad 100644
>> --- a/gcc/testsuite/gcc.target/riscv/pr113742.c
>> +++ b/gcc/testsuite/gcc.target/riscv/pr113742.c
>> @@ -1,4 +1,4 @@
>> -//* { dg-do compile } */
>> -/* { dg-options "-O2 -finstrument-functions -mabi=lp64d -mcpu=sifive-p670" } */
>> +/* { dg-do compile } */
>> +/* { dg-options "-O2 -finstrument-functions -march=rv64gc -mabi=lp64d -mtune=sifive-p600-series" } */
>>
>>   void foo(void) {}
>> --
>> 2.34.1
>>

      reply	other threads:[~2024-02-21 17:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-20 22:03 [PATCH " Edwin Lu
2024-02-21  1:36 ` Kito Cheng
2024-02-21 17:41   ` Edwin Lu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0a72856-0a3c-42da-8067-4dd5cb3b8b35@rivosinc.com \
    --to=ewlu@rivosinc.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gnu-toolchain@rivosinc.com \
    --cc=kito.cheng@gmail.com \
    --cc=monk.chiang@sifive.com \
    --cc=rdapp.gcc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).