public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Georg-Johann Lay <avr@gjlay.de>
To: Bernd Schmidt <bschmidt@redhat.com>,
	gcc-patches <gcc-patches@gcc.gnu.org>
Cc: Mike Stump <mikestump@comcast.net>
Subject: Re: [patch,testsuite] Support dg-require-effective-target label_offsets.
Date: Fri, 28 Oct 2016 12:55:00 -0000	[thread overview]
Message-ID: <c0a9fb02-984d-c292-afc3-5b2ea427bc7d@gjlay.de> (raw)
In-Reply-To: <748e0c88-eb10-99eb-7905-f156574741dc@redhat.com>

On 27.10.2016 12:49, Bernd Schmidt wrote:
> On 10/27/2016 12:16 PM, Georg-Johann Lay wrote:
>> Now imagine some arithmetic like &&LAB2 - &&LAB1.  This might result in
>> one or two stub addresses, and difference between such addresses is a
>> complete different thing than the difference between the original
>> labels:  The result might differ in absolute value and in sign, i.e. you
>> can't even determine whether LAB1 or LAB2 comes first in the generated
>> code as the order of stubs might differ from the order of respective
>> labels.
>
> Ok, so you can't expect to use the value directly, but I think this is not too
> different from other targets. You still should be able to add the difference
> back to &&LAB1 and expect to get &&LAB2 or gs(&&LAB2). That's what the
> execution test does - why isn't this working?
>
> Bernd

Makes sense what you are writing...  Just replacing a label should not do any 
harm (except for ordering).  I had a deeper look into it and some tests are 
failing because of a missing Binutils support for special expressions, not 
because the tests don't work per se.  Patching the generated asm to results as 
would be provided by working Binutils make the test pass.

Johann


  reply	other threads:[~2016-10-28 12:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-26 14:46 Georg-Johann Lay
2016-10-26 16:51 ` Bernd Schmidt
2016-10-27 10:16   ` Georg-Johann Lay
2016-10-27 10:50     ` Bernd Schmidt
2016-10-28 12:55       ` Georg-Johann Lay [this message]
2016-10-28 15:58     ` Mike Stump
2016-11-03 15:25       ` Georg-Johann Lay
2016-11-04  2:48         ` Mike Stump
2016-11-04  9:36           ` Georg-Johann Lay
2016-11-04 21:04             ` Mike Stump
2016-11-04  5:19         ` Senthil Kumar Selvaraj
2016-11-04  9:49           ` Georg-Johann Lay
2016-11-17 13:49             ` Senthil Kumar Selvaraj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0a9fb02-984d-c292-afc3-5b2ea427bc7d@gjlay.de \
    --to=avr@gjlay.de \
    --cc=bschmidt@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=mikestump@comcast.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).