From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 372B03858D33; Fri, 14 Apr 2023 03:13:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 372B03858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33E0i5TS019910; Fri, 14 Apr 2023 03:13:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=mime-version : date : from : to : cc : subject : in-reply-to : references : message-id : content-type : content-transfer-encoding; s=pp1; bh=pDVyvvOn0NEgOiYP9fviv4huvgmnRQ3FdKnBdxa2tOs=; b=XDUBpCeMsCIuRc45PI76qccYF8gYy7YZLy6C4oKxy98ottfJVa+6b8ueZ0ChdE+01TAl v2sVfBhfuh/hA8qYHMfdCxeDNYh7kLYbmeRJ5uYTBGHA2FJX8zN3KNP1va3xP+zm4JTy Km3GFGAAwft3/Jz8o011XovjZD5Es0iJU6UAg9bzWHe9hZCJmRMLQp2NfFUUVwX4CEwu aRqj9NaPfF6LmUls6DTotkRnVRvF5fOP8fIXlUUM33o7dV7Bo4hy59h828ba5KfkckBM aLc4c/VHlCGbI3opcbVOl/pHwjIvQ1pwOjAGgI6FFoC7UhK+XiIXjnJQzZvos+RjnbQg qg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3pxvgb4431-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 14 Apr 2023 03:13:18 +0000 Received: from m0187473.ppops.net (m0187473.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 33E2sW97039870; Fri, 14 Apr 2023 03:13:17 GMT Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3pxvgb442p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 14 Apr 2023 03:13:17 +0000 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 33E0XOEm002007; Fri, 14 Apr 2023 03:13:16 GMT Received: from smtprelay05.dal12v.mail.ibm.com ([9.208.130.101]) by ppma03dal.us.ibm.com (PPS) with ESMTPS id 3pu0ku6999-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 14 Apr 2023 03:13:16 +0000 Received: from smtpav04.dal12v.mail.ibm.com (smtpav04.dal12v.mail.ibm.com [10.241.53.103]) by smtprelay05.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 33E3DFJk9896488 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 14 Apr 2023 03:13:15 GMT Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2295C5805E; Fri, 14 Apr 2023 03:13:15 +0000 (GMT) Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BFDBD5805A; Fri, 14 Apr 2023 03:13:14 +0000 (GMT) Received: from ltc.linux.ibm.com (unknown [9.5.196.140]) by smtpav04.dal12v.mail.ibm.com (Postfix) with ESMTP; Fri, 14 Apr 2023 03:13:14 +0000 (GMT) MIME-Version: 1.0 Date: Fri, 14 Apr 2023 11:13:14 +0800 From: guojiufu To: Segher Boessenkool Cc: Richard Biener , gcc-patches@gcc.gnu.org, dmalcolm@redhat.com, jeffreyalaw@gmail.com, dje.gcc@gmail.com, linkw@gcc.gnu.org, meissner@linux.ibm.com Subject: Re: [PATCH] testsuite: filter out warning noise for CWE-1341 test In-Reply-To: <20230413120852.GF19790@gate.crashing.org> References: <20230412060845.981953-1-guojiufu@linux.ibm.com> <7nile08j5m.fsf@ltcden2-lp1.aus.stglabs.ibm.com> <20230413120852.GF19790@gate.crashing.org> Message-ID: X-Sender: guojiufu@linux.ibm.com Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 1-cO5QMC7SOm2MAj1UAw_mgiJ_B35Npr X-Proofpoint-ORIG-GUID: b2Bdux0LkvCGi1w9bu2ae5ANeD9UwRla X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-13_18,2023-04-13_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 mlxscore=0 bulkscore=0 priorityscore=1501 suspectscore=0 adultscore=0 spamscore=0 malwarescore=0 mlxlogscore=770 phishscore=0 impostorscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304140026 X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, On 2023-04-13 20:08, Segher Boessenkool wrote: > On Thu, Apr 13, 2023 at 07:39:01AM +0000, Richard Biener wrote: >> On Thu, 13 Apr 2023, Jiufu Guo wrote: >> I think this should be fixed in the analyzer, "stripping" malloc >> tracking from fopen/fclose since it does this manually. I've adjusted >> the bug accordingly. > > Yeah. > >> > > +/* This case checks double-fclose only, suppress other warning. */ >> > > +/* { dg-additional-options -Wno-analyzer-double-free } */ > > So please add "(PR108722)" or such to the comment here? That is enough > for future people to see if this is still necessary, to maybe remove it > from the testcase here, but certainly not cargo-cult it to other > testcases! Good suggestions, thanks! Committed via r13-7176-gedc6659c97c4a7. BR, Jeff (Jiufu) > > Thanks, > > > Segher