From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13326 invoked by alias); 5 Dec 2017 23:43:58 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 12904 invoked by uid 89); 5 Dec 2017 23:43:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=020 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 05 Dec 2017 23:43:56 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BC7DE32B379; Tue, 5 Dec 2017 23:43:55 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-2.rdu2.redhat.com [10.10.112.2]) by smtp.corp.redhat.com (Postfix) with ESMTP id BFDA362666; Tue, 5 Dec 2017 23:43:54 +0000 (UTC) Subject: Re: [020/nnn] poly_int: store_bit_field bitrange To: gcc-patches@gcc.gnu.org, richard.sandiford@linaro.org References: <871sltvm7r.fsf@linaro.org> <87h8uprdvk.fsf@linaro.org> From: Jeff Law Message-ID: Date: Tue, 05 Dec 2017 23:43:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <87h8uprdvk.fsf@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00275.txt.bz2 On 10/23/2017 11:08 AM, Richard Sandiford wrote: > This patch changes the bitnum and bitsize arguments to > store_bit_field from unsigned HOST_WIDE_INTs to poly_uint64s. > The later part of store_bit_field_1 still needs to operate > on constant bit positions and sizes, so the patch splits > it out into a subfunction (store_integral_bit_field). > > > 2017-10-23 Richard Sandiford > Alan Hayward > David Sherwood > > gcc/ > * expmed.h (store_bit_field): Take bitsize and bitnum as > poly_uint64s rather than unsigned HOST_WIDE_INTs. > * expmed.c (simple_mem_bitfield_p): Likewise. Add a parameter > that returns the byte size. > (store_bit_field_1): Take bitsize and bitnum as > poly_uint64s rather than unsigned HOST_WIDE_INTs. Update call > to simple_mem_bitfield_p. Split the part that can only handle > constant bitsize and bitnum out into... > (store_integral_bit_field): ...this new function. > (store_bit_field): Take bitsize and bitnum as poly_uint64s rather > than unsigned HOST_WIDE_INTs. > (extract_bit_field_1): Update call to simple_mem_bitfield_p. OK. jeff