From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by sourceware.org (Postfix) with ESMTPS id 248783858C54 for ; Wed, 7 Jun 2023 13:04:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 248783858C54 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-1b0314f057cso38008885ad.1 for ; Wed, 07 Jun 2023 06:04:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686143040; x=1688735040; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=33ghhV6UTWeNar3h5XTgOZeAJ9YcIEt6eri3KADtacw=; b=ldoKOSzr2p+bsXIAtJeshnaBPZ6iPcFs8a28Fvt5uCMX61Ns0n9FnX6lzkZu7CRTHJ bznyH9LgwSC9Ew9joSHxraqAnwbUppshEOhEjQxAkI/s9yVV0CqOM2qypuLbMKwtsypu Elwn1sh8PCV56wD5MFmErFi9uN6FkyByxsJELntced0PyMMN1YadLE3vZuQGytUqvsvv Qjg7taBf0SGsu8H+f8BmrY6s31KOvbu/hgQUXg5Z97mErK27a2iy7I2XCi8AYxoR+M3/ 2LaLCl72HEraUBW+DxqXR8RvCj7UhIi5F2OFV7996tqIVLCn27FbMw29uDL7LkkCebXc rHMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686143040; x=1688735040; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=33ghhV6UTWeNar3h5XTgOZeAJ9YcIEt6eri3KADtacw=; b=UwNneuDkb76Fha6qhBibxDEeNEoON4xS/rT56NFxCmNrbWzWWtRNMF1Bf88+pmX5c3 3yatvYaEGiQZRdzhLHQ4/F26qrMovONhruz6nJsYrZjF9Na1puBavscOkenAlmUuUa39 4zWsal5Nrr9aoVhbVURUvFn3JqN4vg+IQtdRHE7dFX+C4R1sCj7RE4rDzGxUj5JyMivg rJz0aIESdnVX7DE1HnMDIRSORhCPwsYt+bHtl9aKpDD2qkJeti6MoagXviCj60m8TBqD 6Mm9/i2BOHJyvgz1e00pmT+PT07iQ+tIYA06nSjiuacKY6VLo49FFYZGpw0VZ04CsmPo skNA== X-Gm-Message-State: AC+VfDwKXSUHGAL5fwB4bLgbACitZURpuT66bYVpVIqMrwb8vd+REgzp ppftmmVElf7N8VhlWFsQ7ks= X-Google-Smtp-Source: ACHHUZ5vDEBU4zssyJT+A68pvQe7URa0DLvFabG+MUJXih/G0ckNJVVDs1a96CuDzA3ZB0DXbPmm6A== X-Received: by 2002:a17:902:b20e:b0:1b1:9218:6bf9 with SMTP id t14-20020a170902b20e00b001b192186bf9mr2292928plr.43.1686143039706; Wed, 07 Jun 2023 06:03:59 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id s10-20020a170903200a00b001acad024c8asm10403701pla.40.2023.06.07.06.03.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jun 2023 06:03:59 -0700 (PDT) Message-ID: Date: Wed, 7 Jun 2023 07:03:57 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 1/2] Match: zero_one_valued_p should match 0 constants too Content-Language: en-US To: Jakub Jelinek , Andrew Pinski Cc: gcc-patches@gcc.gnu.org References: <20230607001706.3000011-1-apinski@marvell.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/7/23 01:12, Jakub Jelinek via Gcc-patches wrote: >> >> +/* zero_one_valued_p will match when a value is known to be either >> + 0 or 1 including the constant 0. */ >> (match zero_one_valued_p >> @0 >> (if (INTEGRAL_TYPE_P (type) && tree_nonzero_bits (@0) == 1))) > > So perhaps instead change this to > && wi::leu_p (tree_nonzero_bits (@0), 1) I guess that would cover both cases without the extra conditional. I'm fine with that approach too. Consider it pre-approved if someone wants to make that change. jeff