From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128592 invoked by alias); 25 Jul 2019 14:42:52 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 128576 invoked by uid 89); 25 Jul 2019 14:42:51 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:695 X-HELO: cc-smtpout2.netcologne.de Received: from cc-smtpout2.netcologne.de (HELO cc-smtpout2.netcologne.de) (89.1.8.212) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 25 Jul 2019 14:42:50 +0000 Received: from cc-smtpin3.netcologne.de (cc-smtpin3.netcologne.de [89.1.8.203]) by cc-smtpout2.netcologne.de (Postfix) with ESMTP id 6E686127C2; Thu, 25 Jul 2019 16:42:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=netcologne.de; s=nc1116a; t=1564065767; bh=bmW7WvmvUI/qbxkhk87DJOuSPSGKfA3Il4iSY5pQI6g=; h=Subject:To:Cc:References:From:Message-ID:Date:In-Reply-To:From; b=Pq5HJroF9Y9D/0mcioYVbmEOb/CchpmFUEBPMeugSrxV5frt2mp9z4APyl/3/IFaB 8k/1msbiReVSOk9nDrfCiYfuBySaIZm8mStCBvaKzDlCOq+Q1nuRP0CW0cvQhWc/zu acENxjA43Zj5n6JVDPz+N39yte1E4530SVEJRx63RHLHnKGXWFfSsGDs097CUCa490 wJszuA7TEiYitQCza7GLA1DBdnY5GVKNzKo3ITxhymjanCaoN1u1GK18a2LUGQnOiu 7SPQSsNf5Lu8z/UYB6fD2pwyGDx2U6IUQbP9uGJ7U3b0vm9h3+CB7k9sonqIOuEPmb TkMeVoy1c0twQ== Received: from localhost (localhost [127.0.0.1]) by cc-smtpin3.netcologne.de (Postfix) with ESMTP id 696B211EF2; Thu, 25 Jul 2019 16:42:47 +0200 (CEST) Received: from [2001:4dd7:fb2a:0:7285:c2ff:fe6c:992d] (helo=cc-smtpin3.netcologne.de) by localhost with ESMTP (eXpurgate 4.6.0) (envelope-from ) id 5d39bfe7-388c-7f0000012729-7f000001db9e-1 for ; Thu, 25 Jul 2019 16:42:47 +0200 Received: from [IPv6:2001:4dd7:fb2a:0:7285:c2ff:fe6c:992d] (2001-4dd7-fb2a-0-7285-c2ff-fe6c-992d.ipv6dyn.netcologne.de [IPv6:2001:4dd7:fb2a:0:7285:c2ff:fe6c:992d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by cc-smtpin3.netcologne.de (Postfix) with ESMTPSA; Thu, 25 Jul 2019 16:42:44 +0200 (CEST) Subject: Re: [patch, fortran] Improve dependency checking To: sgk@troutmask.apl.washington.edu Cc: "fortran@gcc.gnu.org" , gcc-patches References: <20190725142409.GA42079@troutmask.apl.washington.edu> From: Thomas Koenig Message-ID: Date: Thu, 25 Jul 2019 14:52:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20190725142409.GA42079@troutmask.apl.washington.edu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2019-07/txt/msg01642.txt.bz2 Hi Steve, >> -int gfc_dep_resolver(gfc_ref *, gfc_ref *, gfc_reverse *); >> +int gfc_dep_resolver(gfc_ref *, gfc_ref *, gfc_reverse *, bool identical = false); > This is changing the prototype. I would expect to see > > > int gfc_dep_resolver(gfc_ref *, gfc_ref *, gfc_reverse *, bool); Usig C++'s optional arguments is actually quite useful, it's used already used in a few places in the front end. The idea is that you don't need to touch the other callers, just the ones where the new argument matters. However, in this particular case, it would also be possible to ajust all other callers (exactly one), if you prefer. Regards Thomas