From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id A4EAA3858006 for ; Mon, 13 Sep 2021 17:53:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A4EAA3858006 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.1.2/8.16.0.43) with SMTP id 18DGVPqL011469; Mon, 13 Sep 2021 13:53:20 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 3b232uwtn1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 13 Sep 2021 13:53:19 -0400 Received: from m0098414.ppops.net (m0098414.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 18DGZo0h024555; Mon, 13 Sep 2021 13:53:19 -0400 Received: from ppma02wdc.us.ibm.com (aa.5b.37a9.ip4.static.sl-reverse.com [169.55.91.170]) by mx0b-001b2d01.pphosted.com with ESMTP id 3b232uwtms-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 13 Sep 2021 13:53:19 -0400 Received: from pps.filterd (ppma02wdc.us.ibm.com [127.0.0.1]) by ppma02wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 18DHpi5F007681; Mon, 13 Sep 2021 17:53:18 GMT Received: from b01cxnp22033.gho.pok.ibm.com (b01cxnp22033.gho.pok.ibm.com [9.57.198.23]) by ppma02wdc.us.ibm.com with ESMTP id 3b0m3aefg2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 13 Sep 2021 17:53:18 +0000 Received: from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com [9.57.199.109]) by b01cxnp22033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 18DHrHeg35848450 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 Sep 2021 17:53:17 GMT Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E8B94112067; Mon, 13 Sep 2021 17:53:16 +0000 (GMT) Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 53F97112065; Mon, 13 Sep 2021 17:53:16 +0000 (GMT) Received: from lexx (unknown [9.163.7.194]) by b01ledav004.gho.pok.ibm.com (Postfix) with ESMTP; Mon, 13 Sep 2021 17:53:16 +0000 (GMT) Message-ID: Subject: Re: [PATCH 02/18] rs6000: Move __builtin_mffsl to the [always] stanza From: will schmidt To: Bill Schmidt , gcc-patches@gcc.gnu.org Cc: dje.gcc@gmail.com, segher@kernel.crashing.org Date: Mon, 13 Sep 2021 12:53:15 -0500 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: ZiKBmpONoFCMgzMDwbMrK-mNiBb4oXug X-Proofpoint-GUID: BG7yis3lFLIdbrrJB6pGEYhEX11ZHZb0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.687,Hydra:6.0.235,FMLib:17.0.607.475 definitions=2020-10-13_15,2020-10-13_02,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxlogscore=999 impostorscore=0 mlxscore=0 suspectscore=0 malwarescore=0 phishscore=0 clxscore=1015 spamscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109030001 definitions=main-2109130043 X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Sep 2021 17:53:22 -0000 On Wed, 2021-09-01 at 11:13 -0500, Bill Schmidt via Gcc-patches wrote: > I over-restricted use of __builtin_mffsl, since I was unaware that it > automatically uses mffs when mffsl is not available. Paul Clarke > pointed > this out in discussion of his SSE 4.1 compatibility patches. > > 2021-08-31 Bill Schmidt > > gcc/ > * config/rs6000/rs6000-call.c (__builtin_mffsl): Move from > [power9] > to [always]. > --- > gcc/config/rs6000/rs6000-builtin-new.def | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/gcc/config/rs6000/rs6000-builtin-new.def > b/gcc/config/rs6000/rs6000-builtin-new.def > index 6a28d5189f8..a8c6b9e988f 100644 > --- a/gcc/config/rs6000/rs6000-builtin-new.def > +++ b/gcc/config/rs6000/rs6000-builtin-new.def > @@ -208,6 +208,12 @@ > double __builtin_mffs (); > MFFS rs6000_mffs {} > > +; Although the mffsl instruction is only available on POWER9 and > later > +; processors, this builtin automatically falls back to mffs on older > +; platforms. Thus it appears here in the [always] stanza. > + double __builtin_mffsl (); > + MFFSL rs6000_mffsl {} > + > ; This thing really assumes long double == __ibm128, and I'm told it > has > ; been used as such within libgcc. Given that __builtin_pack_ibm128 > ; exists for the same purpose, this should really not be used at > all. > @@ -2784,9 +2790,6 @@ > signed long long __builtin_darn_raw (); > DARN_RAW darn_raw {} > > - double __builtin_mffsl (); > - MFFSL rs6000_mffsl {} > - > const signed int __builtin_dtstsfi_eq_dd (const int<6>, > _Decimal64); > TSTSFI_EQ_DD dfptstsfi_eq_dd {} > Looks reasonable, Thanks -Will