From: Cary Coutant <ccoutant@google.com>
To: Rafael Espindola <espindola@google.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Diego Novillo <dnovillo@google.com>
Subject: Re: [patch] Fix resolution file generation
Date: Thu, 15 Oct 2009 00:02:00 -0000 [thread overview]
Message-ID: <c17be2b30910141537i60d5416eg5eaa195584bd14f4@mail.gmail.com> (raw)
In-Reply-To: <38a0d8450910141308o2d40c9f1td6a6fbc009e35713@mail.gmail.com>
> 2009-10-14 Rafael Avila de Espindola <espindola@google.com>
>
> * lto-plugin.c (resolution_file): New.
> (free_1): Update comment.
> (write_resolution): Write resolution to specified file. Use the
> syms array from the symbol table.
> (all_symbols_read_handler): Delay call to free_1 past call to
> write_resolution.
> (process_option): Add a -resolution option.
+ f = fopen (resolution_file, "w");
There ought to be a check that f != NULL after this (not so much an
issue with this patch -- it should have been there before).
Otherwise, looks good to me.
-cary
next prev parent reply other threads:[~2009-10-14 22:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-14 20:15 Rafael Espindola
2009-10-15 0:02 ` Cary Coutant [this message]
2009-10-15 14:41 ` Rafael Espindola
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c17be2b30910141537i60d5416eg5eaa195584bd14f4@mail.gmail.com \
--to=ccoutant@google.com \
--cc=dnovillo@google.com \
--cc=espindola@google.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).