From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17339 invoked by alias); 14 Oct 2009 22:38:00 -0000 Received: (qmail 17145 invoked by uid 22791); 14 Oct 2009 22:37:59 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 14 Oct 2009 22:37:54 +0000 Received: from zps77.corp.google.com (zps77.corp.google.com [172.25.146.77]) by smtp-out.google.com with ESMTP id n9EMbp9W004944 for ; Wed, 14 Oct 2009 23:37:51 +0100 Received: from pzk9 (pzk9.prod.google.com [10.243.19.137]) by zps77.corp.google.com with ESMTP id n9EMbiAh028935 for ; Wed, 14 Oct 2009 15:37:48 -0700 Received: by pzk9 with SMTP id 9so206205pzk.16 for ; Wed, 14 Oct 2009 15:37:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.247.5 with SMTP id u5mr737100wfh.333.1255559868574; Wed, 14 Oct 2009 15:37:48 -0700 (PDT) In-Reply-To: <38a0d8450910141308o2d40c9f1td6a6fbc009e35713@mail.gmail.com> References: <38a0d8450910141308o2d40c9f1td6a6fbc009e35713@mail.gmail.com> Date: Thu, 15 Oct 2009 00:02:00 -0000 Message-ID: Subject: Re: [patch] Fix resolution file generation From: Cary Coutant To: Rafael Espindola Cc: GCC Patches , Diego Novillo Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2009-10/txt/msg00947.txt.bz2 > 2009-10-14 =A0Rafael Avila de Espindola =A0 > > =A0 =A0 =A0 =A0* lto-plugin.c (resolution_file): New. > =A0 =A0 =A0 =A0(free_1): Update comment. > =A0 =A0 =A0 =A0(write_resolution): Write resolution to specified file. Us= e the > =A0 =A0 =A0 =A0syms array from the symbol table. > =A0 =A0 =A0 =A0(all_symbols_read_handler): Delay call to free_1 past call= to > =A0 =A0 =A0 =A0write_resolution. > =A0 =A0 =A0 =A0(process_option): Add a -resolution option. + f =3D fopen (resolution_file, "w"); There ought to be a check that f !=3D NULL after this (not so much an issue with this patch -- it should have been there before). Otherwise, looks good to me. -cary