Re: [patch] Use LDPL_FATAL instead of assert

[Cary Coutant <ccoutant@google.com>]

> The plugin currently asserts on all errors. This patch changes most of them
> into calls to the message callback. The patch also makes the cleanup_handler
> succeed when being called in consequence of an earlier error.
>
> 2009-10-15  Rafael Avila de Espindola  <espindola@google.com>
>
>        * lto-plugin.c (message): New variable.
>        (check): New function.
>        (parse_table_entry, translate, write_resolution,add_output_files,
>        exec_lto_wrapper,claim_file_handler, onload): Use check instead of
>        assert.
>        (cleanup_handler): Use check instead of assert. Remove the arguments
>        file if it exists.

+  check (WIFEXITED (status) && WEXITSTATUS (status) == 0,
+	 LDPL_FATAL,          "lto-wrapper failed.");

There's a bunch of extraneous spaces here.

+  /* Note: we cannot use LDPL_FATAL in here as that would produce
+     an infinite loop. */

Good point! That should probably be documented in the header and the
wiki page. (Hope you didn't discover that the hard way!)

+  check (version != EV_NONE, LDPL_FATAL, "Invalid elf version.");

"elf" should be "ELF".

Other than Joseph's comment about message style (and provided it's OK
to defer the I18N stuff), the rest looks good.

-cary