From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) by sourceware.org (Postfix) with ESMTPS id 0C68A385840D for ; Tue, 24 Oct 2023 20:49:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0C68A385840D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0C68A385840D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::72d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698180583; cv=none; b=dKseh7RMHDV+Vp6akk7xCZfBGjcuNd/fVSrbrTa8a7vKDkGhnIBSx2nq+K/BPFaZuEA4Cs7yrneI+ArEy1Q3J3+gsgz6xYzk07X9nUZBxqoTjdahE3FfbZxvvMLh10LpmHG3uKGWtyDWhkXcQ+yaB5Tq+1gTHpMWiWStz//uXqo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698180583; c=relaxed/simple; bh=O3dqKU5CwnWgJyLTUTk9IS+y0tM8F9nv/ZJShYxChqw=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=iAVxia++FTbP3John19aWCHSncqO3jQn5G01pKlpIYyAIJzgkvqndT2ycDQtCjCMvm4IPICzGFtUu25TsVhtQF4F0rw6KYYMjXZ41XQ3gm60QkYc8h3yu2nhvL0U3GD3NdIlmH8sAC8SJsJ7WdOPF02RNv0Y1eONaGf9l8TVk5o= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-qk1-x72d.google.com with SMTP id af79cd13be357-773ac11de71so329954485a.2 for ; Tue, 24 Oct 2023 13:49:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1698180581; x=1698785381; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=K3LdtLkhSrj6wwFzjIzK9Q1nW5GqGrWj8A/PpkB9Vc4=; b=JS/sm5C4cjHbzj7hWr7IdzxaAQ7rUmTvKhrE4HAZGHtHhbZIrQgL4+O6y3+KyMtqN/ 3L2fJXd3NB51FbZRU88Z0nIZbMiet7n+LCiBNlzm9G7sF1BgDwYyuliCsk8GwEbuVEjN WQMdgkvDcyvy/KXYpr8mFgT1uLCFjg+Xkr7cHwU1oaqx6PW51auFY7WqILW6caE9cYrB ip5AD8maWJS2Hefd72b1SPwjxYlt6Djb8uo45q0R+Nfn3u1nlKgJOhvdgX4nzlGAvOWr Mqbg6G8xWm0I+2Rz7ByBaDOAPt46K1dtSR6P+5HFGZi7FrerFk/KKoBBgm8XgKfUOjMV oyKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698180581; x=1698785381; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=K3LdtLkhSrj6wwFzjIzK9Q1nW5GqGrWj8A/PpkB9Vc4=; b=JKINXBGBibgTXFhMyA8APisl2y5usyqBDEXQAhynkp8hods/l4nyStcW2J/vz8+jMF 3BFLgCDf/bwhOd2HwugFQZd7wkn6NymE4XB3biA6VwUWtnoCPH/g9IbkjUCeDjRmnAVl YmPEip5Yl+7Z1Z6Em7/7WcIQaXQz6sWmv7vXjWnpc3e6kxxRRJSOc54W8fwhZDYWxR48 2EStqdXsEIuSLod+fLhp6G5hy8PrBu2etHBibf3b8+h3venGdb0PqQXr/DP0CaV3dmNe iHdFcoVtne4BQohbSslF/NedQlqjg7CL1iVngOQQt/68GLJtnROe3+ZyOKY6b9XKmlag FEpA== X-Gm-Message-State: AOJu0YxKpRe5PODtx9m+y78DhP8+Y5zqiYknF9ljm1MgcDrZcy3OfynX Jq7IMYRhO8Cqg8VN7LorrrYvxA== X-Google-Smtp-Source: AGHT+IFB4ixR4WHH0ra9c97Lj0ahT5iHddi6VuMmkvUGbmXwSCQomqzGTyd3uwseO51f+riYSgLZkQ== X-Received: by 2002:ad4:574c:0:b0:656:2d03:a4be with SMTP id q12-20020ad4574c000000b006562d03a4bemr17330764qvx.40.1698180581391; Tue, 24 Oct 2023 13:49:41 -0700 (PDT) Received: from [10.0.16.165] ([208.116.208.98]) by smtp.gmail.com with ESMTPSA id 6-20020a05620a06c600b0077569c302d1sm3686977qky.28.2023.10.24.13.49.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Oct 2023 13:49:41 -0700 (PDT) Message-ID: Date: Tue, 24 Oct 2023 13:49:39 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 4/4] ree: Improve ree pass for rs6000 target using defined ABI interfaces Content-Language: en-US To: rep.dot.nop@gmail.com, Ajit Agarwal Cc: gcc-patches@gcc.gnu.org, Jeff Law , Richard Biener , Segher Boessenkool , Peter Bergner , gnu-toolchain References: <32ca6e0e-ef68-4d4d-b864-c586a688b2c7@linux.ibm.com> <22541c92-a967-4e66-96b3-e4ad5011cd24@rivosinc.com> <20231023161027.362c626b@nbbrfq.loc> <8da41716-1111-4550-95dd-de41a402101e@linux.ibm.com> <4077DE16-87DA-4DDE-B119-6B516944B632@gmail.com> From: Vineet Gupta In-Reply-To: <4077DE16-87DA-4DDE-B119-6B516944B632@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GB_TO_NAME_FREEMAIL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/24/23 13:36, rep.dot.nop@gmail.com wrote: >>>>> As said, I don't see why the below was not cleaned up before the V1 submission. >>>>> Iff it breaks when manually CSEing, I'm curious why? >>> The function below looks identical in v12 of the patch. >>> Why didn't you use common subexpressions? >>> ba >> Using CSE here breaks aarch64 regressions hence I have reverted it back >> not to use CSE, > Just for my own education, can you please paste your patch perusing common subexpressions and an assembly diff of the failing versus working aarch64 testcase, along how you configured that failing (cross-?)compiler and the command-line of a typical testcase that broke when manually CSEing the function below? I was meaning to ask this before, but what exactly is the CSE issue, manually or whatever. -Vineet