From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18918 invoked by alias); 12 Apr 2017 22:03:20 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 18884 invoked by uid 89); 12 Apr 2017 22:03:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=sums X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Apr 2017 22:03:18 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 780FD80F7C; Wed, 12 Apr 2017 22:03:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 780FD80F7C Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=law@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 780FD80F7C Received: from localhost.localdomain (ovpn-116-10.phx2.redhat.com [10.3.116.10]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1E0A5183A8; Wed, 12 Apr 2017 22:03:16 +0000 (UTC) Subject: Re: port contrib/download_prerequisites script to macOS To: Damian Rouson , gcc patches References: Cc: Jerry DeLisle From: Jeff Law Message-ID: Date: Wed, 12 Apr 2017 22:03:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00602.txt.bz2 On 04/04/2017 07:10 PM, Damian Rouson wrote: > All, > > The attached patch modifies the contrib/download_prerequisites script to work on macOS. > The revised script detects the operating system and adjusts the shasum and md5 commands > to their expected name and arguments on macOS. The revised script also uses curl if > wget is not present. macOS ships with curl but not wget. > > Tested on macOS and Lubuntu and Fedora Linux distributions. > > Ok for trunk? > > Damian > > > 2017-04-05 Damian Rouson > > * download_prerequisites (md5_check): New function emulates Linux > 'md5 --check' on macOS. Modified script for macOS compatibility. I wonder if we should just switch to curl from wget in general rather than conditionalizing the code at all. For the sums, rather than doing a check of the OS, just see if sha512/md5sum exists. If not, then fallback to the Darwin defaults. Jeff