* [PATCH][pushed] Add -fprofile-reproducible=parallel-runs to STAGEfeedback_CFLAGS to Makefile.tpl. @ 2021-03-11 15:19 Martin Liška 2021-08-27 17:45 ` Gleb Fotengauer-Malinovskiy 0 siblings, 1 reply; 5+ messages in thread From: Martin Liška @ 2021-03-11 15:19 UTC (permalink / raw) To: gcc-patches Pushed as obvious, the original change was done in g:e05a117dc4b98f3ac60851608f532ba7cee7343a. Martin ChangeLog: * Makefile.tpl: The change was done Makefile.in which is generated file. --- Makefile.tpl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.tpl b/Makefile.tpl index 3b88f351d5b..6e0337fb48f 100644 --- a/Makefile.tpl +++ b/Makefile.tpl @@ -488,7 +488,7 @@ STAGEprofile_TFLAGS = $(STAGE2_TFLAGS) STAGEtrain_CFLAGS = $(filter-out -fchecking=1,$(STAGE3_CFLAGS)) STAGEtrain_TFLAGS = $(filter-out -fchecking=1,$(STAGE3_TFLAGS)) -STAGEfeedback_CFLAGS = $(STAGE4_CFLAGS) -fprofile-use +STAGEfeedback_CFLAGS = $(STAGE4_CFLAGS) -fprofile-use -fprofile-reproducible=parallel-runs STAGEfeedback_TFLAGS = $(STAGE4_TFLAGS) STAGEautoprofile_CFLAGS = $(STAGE2_CFLAGS) -g -- 2.30.1 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][pushed] Add -fprofile-reproducible=parallel-runs to STAGEfeedback_CFLAGS to Makefile.tpl. 2021-03-11 15:19 [PATCH][pushed] Add -fprofile-reproducible=parallel-runs to STAGEfeedback_CFLAGS to Makefile.tpl Martin Liška @ 2021-08-27 17:45 ` Gleb Fotengauer-Malinovskiy 2021-08-30 8:13 ` Martin Liška 0 siblings, 1 reply; 5+ messages in thread From: Gleb Fotengauer-Malinovskiy @ 2021-08-27 17:45 UTC (permalink / raw) To: Martin Liška; +Cc: gcc-patches Hi, On Thu, Mar 11, 2021 at 04:19:51PM +0100, Martin Liška wrote: > Pushed as obvious, the original change was done > in g:e05a117dc4b98f3ac60851608f532ba7cee7343a. > > Martin > > ChangeLog: > > * Makefile.tpl: The change was done Makefile.in which > is generated file. > --- > Makefile.tpl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile.tpl b/Makefile.tpl > index 3b88f351d5b..6e0337fb48f 100644 > --- a/Makefile.tpl > +++ b/Makefile.tpl > @@ -488,7 +488,7 @@ STAGEprofile_TFLAGS = $(STAGE2_TFLAGS) > STAGEtrain_CFLAGS = $(filter-out -fchecking=1,$(STAGE3_CFLAGS)) > STAGEtrain_TFLAGS = $(filter-out -fchecking=1,$(STAGE3_TFLAGS)) > > -STAGEfeedback_CFLAGS = $(STAGE4_CFLAGS) -fprofile-use > +STAGEfeedback_CFLAGS = $(STAGE4_CFLAGS) -fprofile-use -fprofile-reproducible=parallel-runs Did you mean to add -fprofile-reproducible flag to STAGEprofile_CFLAGS instead? I suppose this flag doesn't mean anything without -fprofile-generate, which is passed through STAGEprofile_CFLAGS. Thanks, -- glebfm ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][pushed] Add -fprofile-reproducible=parallel-runs to STAGEfeedback_CFLAGS to Makefile.tpl. 2021-08-27 17:45 ` Gleb Fotengauer-Malinovskiy @ 2021-08-30 8:13 ` Martin Liška 2021-08-30 23:03 ` Gleb Fotengauer-Malinovskiy 0 siblings, 1 reply; 5+ messages in thread From: Martin Liška @ 2021-08-30 8:13 UTC (permalink / raw) To: Gleb Fotengauer-Malinovskiy; +Cc: gcc-patches On 8/27/21 19:45, Gleb Fotengauer-Malinovskiy wrote: > Hi, > > On Thu, Mar 11, 2021 at 04:19:51PM +0100, Martin Liška wrote: >> Pushed as obvious, the original change was done >> in g:e05a117dc4b98f3ac60851608f532ba7cee7343a. >> >> Martin >> >> ChangeLog: >> >> * Makefile.tpl: The change was done Makefile.in which >> is generated file. >> --- >> Makefile.tpl | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Makefile.tpl b/Makefile.tpl >> index 3b88f351d5b..6e0337fb48f 100644 >> --- a/Makefile.tpl >> +++ b/Makefile.tpl >> @@ -488,7 +488,7 @@ STAGEprofile_TFLAGS = $(STAGE2_TFLAGS) >> STAGEtrain_CFLAGS = $(filter-out -fchecking=1,$(STAGE3_CFLAGS)) >> STAGEtrain_TFLAGS = $(filter-out -fchecking=1,$(STAGE3_TFLAGS)) >> >> -STAGEfeedback_CFLAGS = $(STAGE4_CFLAGS) -fprofile-use >> +STAGEfeedback_CFLAGS = $(STAGE4_CFLAGS) -fprofile-use -fprofile-reproducible=parallel-runs > > Did you mean to add -fprofile-reproducible flag to STAGEprofile_CFLAGS > instead? No. > I suppose this flag doesn't mean anything without > -fprofile-generate, which is passed through STAGEprofile_CFLAGS. The flag -fprofile-reproducible is used when we use a collected profile, so it works *only* with -fprofile-use flag. Thanks for heads up! Cheers, Martin > > Thanks, > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][pushed] Add -fprofile-reproducible=parallel-runs to STAGEfeedback_CFLAGS to Makefile.tpl. 2021-08-30 8:13 ` Martin Liška @ 2021-08-30 23:03 ` Gleb Fotengauer-Malinovskiy 2021-08-31 6:54 ` Martin Liška 0 siblings, 1 reply; 5+ messages in thread From: Gleb Fotengauer-Malinovskiy @ 2021-08-30 23:03 UTC (permalink / raw) To: Martin Liška; +Cc: gcc-patches On Mon, Aug 30, 2021 at 10:13:21AM +0200, Martin Liška wrote: > On 8/27/21 19:45, Gleb Fotengauer-Malinovskiy wrote: > > Hi, > > > > On Thu, Mar 11, 2021 at 04:19:51PM +0100, Martin Liška wrote: > >> Pushed as obvious, the original change was done > >> in g:e05a117dc4b98f3ac60851608f532ba7cee7343a. > >> > >> Martin > >> > >> ChangeLog: > >> > >> * Makefile.tpl: The change was done Makefile.in which > >> is generated file. > >> --- > >> Makefile.tpl | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/Makefile.tpl b/Makefile.tpl > >> index 3b88f351d5b..6e0337fb48f 100644 > >> --- a/Makefile.tpl > >> +++ b/Makefile.tpl > >> @@ -488,7 +488,7 @@ STAGEprofile_TFLAGS = $(STAGE2_TFLAGS) > >> STAGEtrain_CFLAGS = $(filter-out -fchecking=1,$(STAGE3_CFLAGS)) > >> STAGEtrain_TFLAGS = $(filter-out -fchecking=1,$(STAGE3_TFLAGS)) > >> > >> -STAGEfeedback_CFLAGS = $(STAGE4_CFLAGS) -fprofile-use > >> +STAGEfeedback_CFLAGS = $(STAGE4_CFLAGS) -fprofile-use -fprofile-reproducible=parallel-runs > > > > Did you mean to add -fprofile-reproducible flag to STAGEprofile_CFLAGS > > instead? > > No. > > > I suppose this flag doesn't mean anything without > > -fprofile-generate, which is passed through STAGEprofile_CFLAGS. > > The flag -fprofile-reproducible is used when we use a collected profile, so it works > *only* with -fprofile-use flag. Thank you for the answer, now I see how it works. I think that it means that the documentation is rather misleading about this flag: '-fprofile-reproducible=[multithreaded|parallel-runs|serial]' Control level of reproducibility of profile gathered by '-fprofile-generate'. [...] It convinced me that this flag changes the way the code is instrumented for profile generation. The rest of it convinced me even more, actually. > Thanks for heads up! > Cheers, > Martin > > > > > Thanks, > > -- glebfm ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][pushed] Add -fprofile-reproducible=parallel-runs to STAGEfeedback_CFLAGS to Makefile.tpl. 2021-08-30 23:03 ` Gleb Fotengauer-Malinovskiy @ 2021-08-31 6:54 ` Martin Liška 0 siblings, 0 replies; 5+ messages in thread From: Martin Liška @ 2021-08-31 6:54 UTC (permalink / raw) To: Gleb Fotengauer-Malinovskiy; +Cc: gcc-patches On 8/31/21 01:03, Gleb Fotengauer-Malinovskiy wrote: > On Mon, Aug 30, 2021 at 10:13:21AM +0200, Martin Liška wrote: >> On 8/27/21 19:45, Gleb Fotengauer-Malinovskiy wrote: >>> Hi, >>> >>> On Thu, Mar 11, 2021 at 04:19:51PM +0100, Martin Liška wrote: >>>> Pushed as obvious, the original change was done >>>> in g:e05a117dc4b98f3ac60851608f532ba7cee7343a. >>>> >>>> Martin >>>> >>>> ChangeLog: >>>> >>>> * Makefile.tpl: The change was done Makefile.in which >>>> is generated file. >>>> --- >>>> Makefile.tpl | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/Makefile.tpl b/Makefile.tpl >>>> index 3b88f351d5b..6e0337fb48f 100644 >>>> --- a/Makefile.tpl >>>> +++ b/Makefile.tpl >>>> @@ -488,7 +488,7 @@ STAGEprofile_TFLAGS = $(STAGE2_TFLAGS) >>>> STAGEtrain_CFLAGS = $(filter-out -fchecking=1,$(STAGE3_CFLAGS)) >>>> STAGEtrain_TFLAGS = $(filter-out -fchecking=1,$(STAGE3_TFLAGS)) >>>> >>>> -STAGEfeedback_CFLAGS = $(STAGE4_CFLAGS) -fprofile-use >>>> +STAGEfeedback_CFLAGS = $(STAGE4_CFLAGS) -fprofile-use -fprofile-reproducible=parallel-runs >>> >>> Did you mean to add -fprofile-reproducible flag to STAGEprofile_CFLAGS >>> instead? >> >> No. >> >>> I suppose this flag doesn't mean anything without >>> -fprofile-generate, which is passed through STAGEprofile_CFLAGS. >> >> The flag -fprofile-reproducible is used when we use a collected profile, so it works >> *only* with -fprofile-use flag. > > Thank you for the answer, now I see how it works. Good. > > I think that it means that the documentation is rather misleading about > this flag: > > '-fprofile-reproducible=[multithreaded|parallel-runs|serial]' > Control level of reproducibility of profile gathered by > '-fprofile-generate'. [...] Well, feel free to send a patch that can improve the wording. Cheers, Martin > > It convinced me that this flag changes the way the code is instrumented > for profile generation. The rest of it convinced me even more, actually. > >> Thanks for heads up! >> Cheers, >> Martin >> >>> >>> Thanks, >>> > ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-08-31 6:54 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-03-11 15:19 [PATCH][pushed] Add -fprofile-reproducible=parallel-runs to STAGEfeedback_CFLAGS to Makefile.tpl Martin Liška 2021-08-27 17:45 ` Gleb Fotengauer-Malinovskiy 2021-08-30 8:13 ` Martin Liška 2021-08-30 23:03 ` Gleb Fotengauer-Malinovskiy 2021-08-31 6:54 ` Martin Liška
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).