From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69289 invoked by alias); 19 Jul 2019 02:21:26 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 69278 invoked by uid 89); 19 Jul 2019 02:21:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 19 Jul 2019 02:21:24 +0000 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x6J2GPeI117829 for ; Thu, 18 Jul 2019 22:21:23 -0400 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0a-001b2d01.pphosted.com with ESMTP id 2tu4gt8wt9-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 18 Jul 2019 22:21:22 -0400 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 19 Jul 2019 03:21:20 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp01.uk.ibm.com (192.168.101.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 19 Jul 2019 03:21:19 +0100 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x6J2LIDN52363434 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 19 Jul 2019 02:21:18 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 26E92AE053; Fri, 19 Jul 2019 02:21:18 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0E8F3AE045; Fri, 19 Jul 2019 02:21:16 +0000 (GMT) Received: from kewenlins-mbp.cn.ibm.com (unknown [9.200.147.221]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 19 Jul 2019 02:21:15 +0000 (GMT) Subject: Re: [PATCH, rs6000] Support vrotr3 for int vector types To: Segher Boessenkool Cc: GCC Patches , Jakub Jelinek , Richard Biener , richard.sandiford@arm.com, Bill Schmidt References: <232a38b1-76c2-476d-1be0-a1958e5624bb@linux.ibm.com> <20190715085929.GO2125@tucnak> <32f89c4f-cd2d-a7bd-16d2-26fed6bb5f56@linux.ibm.com> <27be90e6-4beb-5c4c-a163-9b136490d783@linux.ibm.com> <20190717134025.GJ20882@gate.crashing.org> <83f8448e-3c59-8991-2176-729d87e08a86@linux.ibm.com> <20190718194818.GT20882@gate.crashing.org> From: "Kewen.Lin" Date: Fri, 19 Jul 2019 06:51:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190718194818.GT20882@gate.crashing.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit x-cbid: 19071902-4275-0000-0000-0000034E9680 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19071902-4276-0000-0000-0000385EB115 Message-Id: X-IsSubscribed: yes X-SW-Source: 2019-07/txt/msg01276.txt.bz2 on 2019/7/19 上午3:48, Segher Boessenkool wrote: > On Thu, Jul 18, 2019 at 01:44:36PM +0800, Kewen.Lin wrote: >> Hi Segher, >> >> on 2019/7/17 下午9:40, Segher Boessenkool wrote: >>> Hi Kewen, >>> >>> On Wed, Jul 17, 2019 at 04:32:15PM +0800, Kewen.Lin wrote: >>>> Regression testing just launched, is it OK for trunk if it's bootstrapped >>>> and regresstested on powerpc64le-unknown-linux-gnu? >>> >>>> +;; Expanders for rotatert to make use of vrotl >>>> +(define_expand "vrotr3" >>>> + [(set (match_operand:VEC_I 0 "vint_operand") >>>> + (rotatert:VEC_I (match_operand:VEC_I 1 "vint_operand") >>>> + (match_operand:VEC_I 2 "vint_reg_or_const_vector")))] >>> >>> Having any rotatert in a define_expand or define_insn will regress. >>> >>> So, nope, sorry. >> >> Thanks for clarifying! Since regression testing passed on powerpc64le,I'd like to double confirm the meaning of "regress", does it mean it's >> a regression from design view? Is it specific to rotatert and its >> related one like vrotr? > > You will get HAVE_rotatert defined in insn-config.h if you do this patch, > and then simplify-rtx.c will not work correctly, generating rotatert by > an immediate, which we have no instructions for. > > This might be masked because many of our rl*.c tests already fail because > of other changes, I should fix that :-/ > Hi Segher, Thanks for further explanation! Sorry that, but I didn't find this HAVE_rotatert definition. I guess it's due to the preparation is always "DONE"? Then it doesn't really generate rotatert. although I can see rotatert in insn like below, it seems fine in note? (insn 10 9 11 4 (set (reg:V4SI 122 [ vect__2.7 ]) (rotate:V4SI (reg:V4SI 121 [ vect__1.6 ]) (reg:V4SI 124))) "t.c":17:28 1596 {*altivec_vrlw} (expr_list:REG_EQUAL (rotatert:V4SI (reg:V4SI 121 [ vect__1.6 ]) (const_vector:V4SI [ (const_int 8 [0x8]) repeated x4 ])) (nil))) Thanks, Kewen