From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3984 invoked by alias); 31 Mar 2017 15:07:17 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 3965 invoked by uid 89); 31 Mar 2017 15:07:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 31 Mar 2017 15:07:15 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 45DAB6AAC6 for ; Fri, 31 Mar 2017 15:07:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 45DAB6AAC6 Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=law@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 45DAB6AAC6 Received: from localhost.localdomain (ovpn-116-213.phx2.redhat.com [10.3.116.213]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8A3F184738; Fri, 31 Mar 2017 15:07:14 +0000 (UTC) Subject: Re: Patch ping To: Jakub Jelinek , Jason Merrill References: <20170331063658.GA17462@tucnak> Cc: gcc-patches@gcc.gnu.org From: Jeff Law Message-ID: Date: Fri, 31 Mar 2017 15:14:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170331063658.GA17462@tucnak> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-03/txt/msg01572.txt.bz2 On 03/31/2017 12:36 AM, Jakub Jelinek wrote: > Hi! > > I'd like to ping two patches: > > PR c++/79572 > - ubsan instrumentation of reference binding to NULL if the reference > is folded into INTEGER_CST with REFERENCE_TYPE > http://gcc.gnu.org/ml/gcc-patches/2017-03/msg01255.html Just one question here -- we're working with pure trees or perhaps generic, not gimple here, right? Assuming that is true, this is OK. If instead we are working with gimple, then consider renaming "stmt" in ubsan_maybe_instrument_reference -- when I see "stmt" I think a gimple statement, not a tree:-) jeff