From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by sourceware.org (Postfix) with ESMTPS id 1B27E3858D1E for ; Mon, 9 Oct 2023 10:26:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1B27E3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-53b38d1ac36so4643445a12.2 for ; Mon, 09 Oct 2023 03:26:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696847190; x=1697451990; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=elOJpBYX4d3uyAfSU062je+5raTEGL6BWj88cj8Ge+0=; b=RU+7PO7j/qnMSnR0TtEV0duj41I1PS5qDExnqlirGGfTI0x/KtmKAHNw88R9KWl1uN hEbdcuOsn7F4ilrImveH3XQfZvkuuy3UIj86x6MmIHhDIadLKHXlAB2W3TUMJX9JS1bp VGNg50CMvwX7dCD4z3mM7AKsrjiKVwvD6kn0O+6od/ArTUNSUjx3OvKI30azsM710dAE mW7yj+N69SMXG5YVvyacWBfnOadQu5Sdz60maShEmC2zzqPA9lA1xDyqjf5dxPB0/GJa KWh87O4on8ZZyPy8/HgySAWw++DKZ1vDVZ25z/WiMMDjWLkKF8SKFVkgu0ktBSICD5Su aPXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696847190; x=1697451990; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=elOJpBYX4d3uyAfSU062je+5raTEGL6BWj88cj8Ge+0=; b=Dget6CalNGkEpCy2kWKZ6LsQ1nykTIojlJTX0U52sw1WzOUOUm1eLwMmLjAUpi5jew COeJ+TEIgvtaQWDL4b+KrVwfjRXZ7MUeS0BL4R8qJRIk4W6s8WJ6wvtKQcHtWCsLk9Kk wRKqe12gwLZInX2ac//1Dd3Nzth2OOx1pr2gmXQvaGFhV2guafwN7U4yuMMEyNJKYVHi 4lmJM1dRR1xR1azLhyGtkHYmw2JcmDoPJ4ssr9v/WcdCNnZbu47JS90N4TsWNO2WeS6a KXIgc7x8AYkG0wypsqWTGvvlr5bIn3Pcfk9f3kx+agK6Hz79dm0LlszokakqR5VvAoUs Ajtg== X-Gm-Message-State: AOJu0Yzb8zHOSgrG7qtUMgJGPTHj/tTPvx+yjFzkgsHdqJA3246VsyMo tTmwL1uw8PkmtCKTAuqgTc4= X-Google-Smtp-Source: AGHT+IH74YHocNC3FShtE5L/jDajHS+IEEI8iFFLPmOVrg4oWV9dgWujsY2V39IVNvMLfMgvnxBfFg== X-Received: by 2002:aa7:c248:0:b0:534:6b51:83a3 with SMTP id y8-20020aa7c248000000b005346b5183a3mr14103689edo.1.1696847189970; Mon, 09 Oct 2023 03:26:29 -0700 (PDT) Received: from [192.168.1.23] (ip-046-005-130-086.um12.pools.vodafone-ip.de. [46.5.130.86]) by smtp.gmail.com with ESMTPSA id n24-20020aa7d058000000b0053331f9094dsm5938626edo.52.2023.10.09.03.26.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Oct 2023 03:26:29 -0700 (PDT) Message-ID: Date: Mon, 9 Oct 2023 12:26:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Cc: rdapp.gcc@gmail.com, gcc-patches , rguenther , jeffreyalaw Subject: Re: [PATCH V2] TEST: Fix vect_cond_arith_* dump checks for RVV Content-Language: en-US To: Andreas Schwab , juzhe.zhong@rivai.ai References: <20231008013346.2374788-1-juzhe.zhong@rivai.ai> <1E5EBC402231B817+202310091511549960431@rivai.ai> From: Robin Dapp In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/9/23 09:32, Andreas Schwab wrote: > On Okt 09 2023, juzhe.zhong@rivai.ai wrote: > >> Turns out COND(_LEN)?_ADD can't work. > > It should work though. Tcl regexps are a superset of POSIX EREs. > The problem is that COND(_LEN)?_ADD matches two times against COND_LEN_ADD and a scan-tree-dump-times 1 will fail. So for those checks in vect-cond-arith-6.c we either need to switch to scan-tree-dump or change the pattern to "\.(?:COND|COND_LEN)_ADD". Juzhe, something like the attached works for me. Regards Robin diff --git a/gcc/testsuite/gcc.dg/vect/vect-cond-arith-4.c b/gcc/testsuite/gcc.dg/vect/vect-cond-arith-4.c index 1af0fe642a0..7d26dbedc5e 100644 --- a/gcc/testsuite/gcc.dg/vect/vect-cond-arith-4.c +++ b/gcc/testsuite/gcc.dg/vect/vect-cond-arith-4.c @@ -52,8 +52,8 @@ main (void) return 0; } -/* { dg-final { scan-tree-dump { = \.COND_ADD} "optimized" { target vect_double_cond_arith } } } */ -/* { dg-final { scan-tree-dump { = \.COND_SUB} "optimized" { target vect_double_cond_arith } } } */ -/* { dg-final { scan-tree-dump { = \.COND_MUL} "optimized" { target vect_double_cond_arith } } } */ -/* { dg-final { scan-tree-dump { = \.COND_RDIV} "optimized" { target vect_double_cond_arith } } } */ +/* { dg-final { scan-tree-dump { = \.COND_(LEN_)?ADD} "optimized" { target vect_double_cond_arith } } } */ +/* { dg-final { scan-tree-dump { = \.COND_(LEN_)?SUB} "optimized" { target vect_double_cond_arith } } } */ +/* { dg-final { scan-tree-dump { = \.COND_(LEN_)?MUL} "optimized" { target vect_double_cond_arith } } } */ +/* { dg-final { scan-tree-dump { = \.COND_(LEN_)?RDIV} "optimized" { target vect_double_cond_arith } } } */ /* { dg-final { scan-tree-dump-not {VEC_COND_EXPR} "optimized" { target vect_double_cond_arith } } } */ diff --git a/gcc/testsuite/gcc.dg/vect/vect-cond-arith-5.c b/gcc/testsuite/gcc.dg/vect/vect-cond-arith-5.c index ec3d9db4202..f7daa13685c 100644 --- a/gcc/testsuite/gcc.dg/vect/vect-cond-arith-5.c +++ b/gcc/testsuite/gcc.dg/vect/vect-cond-arith-5.c @@ -54,8 +54,8 @@ main (void) return 0; } -/* { dg-final { scan-tree-dump { = \.COND_ADD} "optimized" { target { vect_double_cond_arith && vect_masked_store } } } } */ -/* { dg-final { scan-tree-dump { = \.COND_SUB} "optimized" { target { vect_double_cond_arith && vect_masked_store } } } } */ -/* { dg-final { scan-tree-dump { = \.COND_MUL} "optimized" { target { vect_double_cond_arith && vect_masked_store } } } } */ -/* { dg-final { scan-tree-dump { = \.COND_RDIV} "optimized" { target { vect_double_cond_arith && vect_masked_store } } } } */ +/* { dg-final { scan-tree-dump { = \.COND_(LEN_)?ADD} "optimized" { target { vect_double_cond_arith && vect_masked_store } } } } */ +/* { dg-final { scan-tree-dump { = \.COND_(LEN_)?SUB} "optimized" { target { vect_double_cond_arith && vect_masked_store } } } } */ +/* { dg-final { scan-tree-dump { = \.COND_(LEN_)?MUL} "optimized" { target { vect_double_cond_arith && vect_masked_store } } } } */ +/* { dg-final { scan-tree-dump { = \.COND_(LEN_)?RDIV} "optimized" { target { vect_double_cond_arith && vect_masked_store } } } } */ /* { dg-final { scan-tree-dump-not {VEC_COND_EXPR} "optimized" { target { vect_double_cond_arith && vect_masked_store } } } } */ diff --git a/gcc/testsuite/gcc.dg/vect/vect-cond-arith-6.c b/gcc/testsuite/gcc.dg/vect/vect-cond-arith-6.c index 2aeebd44f83..a80c30a50b2 100644 --- a/gcc/testsuite/gcc.dg/vect/vect-cond-arith-6.c +++ b/gcc/testsuite/gcc.dg/vect/vect-cond-arith-6.c @@ -56,8 +56,8 @@ main (void) } /* { dg-final { scan-tree-dump-times {vectorizing stmts using SLP} 4 "vect" { target vect_double_cond_arith } } } */ -/* { dg-final { scan-tree-dump-times { = \.COND_ADD} 1 "optimized" { target vect_double_cond_arith } } } */ -/* { dg-final { scan-tree-dump-times { = \.COND_SUB} 1 "optimized" { target vect_double_cond_arith } } } */ -/* { dg-final { scan-tree-dump-times { = \.COND_MUL} 1 "optimized" { target vect_double_cond_arith } } } */ -/* { dg-final { scan-tree-dump-times { = \.COND_RDIV} 1 "optimized" { target vect_double_cond_arith } } } */ +/* { dg-final { scan-tree-dump { = \.COND_(LEN_)?ADD} "optimized" { target vect_double_cond_arith } } } */ +/* { dg-final { scan-tree-dump { = \.COND_(LEN_)?SUB} "optimized" { target vect_double_cond_arith } } } */ +/* { dg-final { scan-tree-dump { = \.COND_(LEN_)?MUL} "optimized" { target vect_double_cond_arith } } } */ +/* { dg-final { scan-tree-dump { = \.COND_(LEN_)?RDIV} "optimized" { target vect_double_cond_arith } } } */ /* { dg-final { scan-tree-dump-not {VEC_COND_EXPR} "optimized" { target vect_double_cond_arith } } } */