From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 9F35D395BC4C for ; Tue, 27 Jul 2021 03:26:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9F35D395BC4C Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16R3DFMo031868; Mon, 26 Jul 2021 23:26:28 -0400 Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0a-001b2d01.pphosted.com with ESMTP id 3a29641tqf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 26 Jul 2021 23:26:28 -0400 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 16R33CEn000601; Tue, 27 Jul 2021 03:26:27 GMT Received: from b01cxnp22034.gho.pok.ibm.com (b01cxnp22034.gho.pok.ibm.com [9.57.198.24]) by ppma01dal.us.ibm.com with ESMTP id 3a2361ck7f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Jul 2021 03:26:27 +0000 Received: from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com [9.57.199.109]) by b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 16R3QQO844499200 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 27 Jul 2021 03:26:26 GMT Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5D529112061; Tue, 27 Jul 2021 03:26:26 +0000 (GMT) Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 14F96112062; Tue, 27 Jul 2021 03:26:26 +0000 (GMT) Received: from Bills-MacBook-Pro.local (unknown [9.163.10.220]) by b01ledav004.gho.pok.ibm.com (Postfix) with ESMTP; Tue, 27 Jul 2021 03:26:25 +0000 (GMT) Reply-To: wschmidt@linux.ibm.com Subject: Re: [PATCH 23/55] rs6000: Incorporate new builtins code into the build machinery To: Segher Boessenkool Cc: gcc-patches@gcc.gnu.org References: <4f27468885fd84aba5f0dc2369a284f3cffa2b34.1623941441.git.wschmidt@linux.ibm.com> <20210721185830.GK1583@gate.crashing.org> From: Bill Schmidt Message-ID: Date: Mon, 26 Jul 2021 22:26:25 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210721185830.GK1583@gate.crashing.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-TM-AS-GCONF: 00 X-Proofpoint-GUID: LspDqAbb_I_0AqwrSoQniJQ2d0Mb_YsJ X-Proofpoint-ORIG-GUID: LspDqAbb_I_0AqwrSoQniJQ2d0Mb_YsJ X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-07-27_03:2021-07-26, 2021-07-27 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 bulkscore=0 mlxscore=0 lowpriorityscore=0 mlxlogscore=999 spamscore=0 adultscore=0 impostorscore=0 clxscore=1015 phishscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000 definitions=main-2107270016 X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jul 2021 03:26:31 -0000 Hi Segher, On 7/21/21 1:58 PM, Segher Boessenkool wrote: > On Thu, Jun 17, 2021 at 10:19:07AM -0500, Bill Schmidt wrote: >> 2021-06-07 Bill Schmidt >> >> gcc/ >> * config.gcc (extra_objs): Include rs6000-builtins.o and >> rs6000-c.o. > The rs6000-c.o part needs an explanation, and probably should be a > separate (bugfix) patch (and it needs backports?) OK.  Yeah, I'm a little surprised looking at this diff now...I wonder if it got removed by accident by some previous patch.  I'll investigate. > > The changelog entry should read > * config.gcc (powerpc*-*-*): Include [...] in extra_objs. > or similar. OK, thanks!  Will fix. > >> * config/rs6000/t-rs6000 (rs6000-gen-builtins.o): New target. >> (rbtree.o): Likewise. >> (rs6000-gen-builtins): Likewise. >> (rs6000-builtins.c): Likewise. >> (rs6000-builtins.h): Likewise. >> (rs6000.o): Add dependency. >> (EXTRA_HEADERS): Add rs6000-vecdefines.h. >> (rs6000-vecdefines.h): New target. >> (rs6000-builtins.o): Likewise. >> (rs6000-call.o): Add rs6000-builtins.h as a dependency. >> (rs6000-c.o): Likewise. >> +rs6000-gen-builtins.o: $(srcdir)/config/rs6000/rs6000-gen-builtins.c >> + $(COMPILE) $(CXXFLAGS) $< >> + $(POSTCOMPILE) >> + >> +rbtree.o: $(srcdir)/config/rs6000/rbtree.c >> + $(COMPILE) $< >> + $(POSTCOMPILE) > Why does one need CXXFLAGS and the other does not? Well, I'm as puzzled as you are.  I'll remove the $(CXXFLAGS) and see if anything goes wrong to remind me...but I think it's just unnecessary. > >> +# TODO: Whenever GNU make 4.3 is the minimum required, we should use >> +# grouped targets on this: > That may be quite a while still. GNU make is the foundation of > everything, so we cannot require very new versions of it ever. > > In the meantime, you can make all these targets depend on an > intermediate target (that you mark with .INTERMEDIATE), and have that > intermediate target have the dependencies. This is from version 3.74.3 > and we require 3.80 already, so this is fine. I think this is too artificial.  Right now I just make the two generated .h files depend on the generated .c file, which works since they are all generated together or none of them are generated.  That seems simple enough and more self-documenting to me. > >> +EXTRA_HEADERS += rs6000-vecdefines.h >> +rs6000-vecdefines.h : rs6000-builtins.c > No space before the colon please. Oopsie. Thanks! Bill > > > Segher