From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 3813D3858017 for ; Mon, 28 Feb 2022 16:31:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3813D3858017 Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-199-cwKUb9bJPMeSEvn1l2Q2sA-1; Mon, 28 Feb 2022 11:31:39 -0500 X-MC-Unique: cwKUb9bJPMeSEvn1l2Q2sA-1 Received: by mail-qk1-f200.google.com with SMTP id bj2-20020a05620a190200b005084968bb24so11500325qkb.23 for ; Mon, 28 Feb 2022 08:31:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=YYmowYWT8ZalWdzWto4tVENh8sidiMY6Sl1gd1549ts=; b=Pska1d5igEtWSkdD4oiH67lZDMgvslu3TPHLJqwTsYmsi/3PQZFspTbaUOVFNUMvMo J8oKHBbjJKJIIzB2AdDpUkrww/NkyNdMnRqrPAs+JiQlA3heDTs8TeH0siudqrLzzB7k T/LI3rv5KLYM8ccP7mxC9wSfUtTjHqMkn7HUav2luKIOdUreFsKl5R2+NK/4WqQeX3Ht DZgzMy5pJ49+BhEiK80NOD+6d5pd/GMCaogJqx3G2jjKOJWOUVZ9Y7NVCESpK1tg8YCs VLfjzwfzD2SDisWFkrnefnnreFzbKdjXzk+zi/NFy1OagV8xA1Y6JaKeUGjx0Q10/oqf Ss9g== X-Gm-Message-State: AOAM53070Q/mPdAucFmkjFdthCq8cHIxLbGUMkntRWNaxmy6QFD8xru5 OVaQKkNCT6ZBONBOQZrhy2Nz7QeX2hgUtnc3e5/TkAWtUPq64/VKJxzy3NRqHk7CX3JbzdQtF1v t+fo+TgK3xKBJR6cupA== X-Received: by 2002:a05:620a:b96:b0:649:5c0e:c9ac with SMTP id k22-20020a05620a0b9600b006495c0ec9acmr11711471qkh.136.1646065899171; Mon, 28 Feb 2022 08:31:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJxc/OPhM5RBOpLSGq3VRi1Sy6ETa6aZnaSP0Nhd4zPUj24VUUBWsWHegzcOLijnDC6xgsMBmg== X-Received: by 2002:a05:620a:b96:b0:649:5c0e:c9ac with SMTP id k22-20020a05620a0b9600b006495c0ec9acmr11711454qkh.136.1646065898814; Mon, 28 Feb 2022 08:31:38 -0800 (PST) Received: from [192.168.1.58] ([70.45.227.144]) by smtp.gmail.com with ESMTPSA id v26-20020a05620a0a9a00b00605c6dbe40asm5086493qkg.87.2022.02.28.08.31.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Feb 2022 08:31:38 -0800 (PST) Message-ID: Date: Mon, 28 Feb 2022 12:31:37 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] c++: ->template and implicit typedef [PR104608] To: Marek Polacek , GCC Patches References: <20220222214617.1949703-1-polacek@redhat.com> From: Jason Merrill In-Reply-To: <20220222214617.1949703-1-polacek@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Feb 2022 16:31:45 -0000 On 2/22/22 17:46, Marek Polacek wrote: > Here we have a forward declaration of Parameter for which we create > an implicit typedef, which is a TYPE_DECL. Then, when looking it up > at template definition time, cp_parser_template_id gets (since r12-6754) > this TYPE_DECL which it can't handle. Hmm, getting that global TYPE_DECL from lookup seems like a bug; isn't the lookup earlier in cp_parser_template_name in object scope? > This patch defers lookup for implicit typedefs, a la r12-6879. > > Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? > > PR c++/104608 > > gcc/cp/ChangeLog: > > * parser.cc (cp_parser_template_name): Repeat lookup of implicit > typedef. > > gcc/testsuite/ChangeLog: > > * g++.dg/parse/template-keyword3.C: New test. > --- > gcc/cp/parser.cc | 3 ++- > gcc/testsuite/g++.dg/parse/template-keyword3.C | 12 ++++++++++++ > 2 files changed, 14 insertions(+), 1 deletion(-) > create mode 100644 gcc/testsuite/g++.dg/parse/template-keyword3.C > > diff --git a/gcc/cp/parser.cc b/gcc/cp/parser.cc > index 03d99aba13e..5e89e3737b0 100644 > --- a/gcc/cp/parser.cc > +++ b/gcc/cp/parser.cc > @@ -18681,7 +18681,8 @@ cp_parser_template_name (cp_parser* parser, > return error_mark_node; > } > else if ((!DECL_P (decl) && !is_overloaded_fn (decl)) > - || TREE_CODE (decl) == USING_DECL) > + || TREE_CODE (decl) == USING_DECL > + || DECL_IMPLICIT_TYPEDEF_P (decl)) > /* Repeat the lookup at instantiation time. */ > decl = identifier; > } > diff --git a/gcc/testsuite/g++.dg/parse/template-keyword3.C b/gcc/testsuite/g++.dg/parse/template-keyword3.C > new file mode 100644 > index 00000000000..59fe0fc180b > --- /dev/null > +++ b/gcc/testsuite/g++.dg/parse/template-keyword3.C > @@ -0,0 +1,12 @@ > +// PR c++/104608 > + > +class Parameter; > +template class Function > +: public R > +{ > + Function(); > +}; > +template > +Function::Function() { > + this->template Parameter(); > +} > > base-commit: bc66b471d16ef2fd8cb66fd1131b41f80ecb9961