From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from xry111.site (xry111.site [IPv6:2001:470:683e::1]) by sourceware.org (Postfix) with ESMTPS id E38C53858C83 for ; Mon, 27 Mar 2023 14:34:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E38C53858C83 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=xry111.site Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xry111.site DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1679927651; bh=HW0Co7bPtFtkJi/NTmHm4p9hOrQclnk1wyOH95zBt4k=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=ffKf1hiAh5+uQPJ1A+5/90VKPnphRIyNISvftb3fZo0HHX2+5aft15b9TW4ewnegE 2NFUl4XO/46Jw3UATxBd6bURMKBp6j/X6DFCQ+tiW3gXGYNbTIKCZcEwtgznh/MmYb PtEWAod5iMWIc88F/ilYH6ISJjpep4lTd3DxXWBI= Received: from localhost.localdomain (unknown [IPv6:2001:470:683e::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id 2E9066591A; Mon, 27 Mar 2023 10:34:10 -0400 (EDT) Message-ID: Subject: Re: [V5][PATCH 2/2] Update documentation to clarify a GCC extension From: Xi Ruoyao To: Qing Zhao , Joseph Myers Cc: Jakub Jelinek , "sandra@codesourcery.com" , Siddhesh Poyarekar , Kees Cook , Richard Biener , gcc Patches Date: Mon, 27 Mar 2023 22:34:08 +0800 In-Reply-To: References: <20230316214715.604671-3-qing.zhao@oracle.com> <4a128885-687d-9c22-778-811816b2e535@codesourcery.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.0 MIME-Version: 1.0 X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,LIKELY_SPAM_FROM,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 2023-03-27 at 13:38 +0000, Qing Zhao via Gcc-patches wrote: >=20 >=20 > > On Mar 23, 2023, at 4:14 PM, Joseph Myers wro= te: > >=20 > > On Thu, 23 Mar 2023, Qing Zhao via Gcc-patches wrote: > >=20 > > > +Wgnu-variable-sized-type-not-at-end > > > +C C++ Var(warn_variable_sized_type_not_at_end) Warning > > > +Warn about structures or unions with C99 flexible array members are = not > > > +at the end of a structure. > >=20 > > I think there's at least one word missing here, e.g. "that" before "are= ". >=20 > Will fix it. > >=20 > > > +Please use warning option=C2=A0 @option{-Wgnu-variable-sized-type-no= t-at-end} to > > > +identify all such cases in the source code and modify them.=C2=A0 Th= is extension > > > +will be deprecated from gcc in the next release. > >=20 > > We don't generally say "in the next release" in the manual (or "depreca= ted=20 > > from gcc").=C2=A0 Maybe it *is* deprecated, maybe it will be *removed*,= or will=20 > > *start to warn by default*, in some specified version number (giving a= =20 > > version number seems better than "next release"), but "will be deprecat= ed"=20 > > is odd. > How about the following: >=20 > +Please use warning option=C2=A0 @option{-Wgnu-variable-sized-type-not-at= -end} to > +identify all such cases in the source code and modify them.=C2=A0 This w= arning will be=20 > + on by default starting from GCC14. I'm wondering why it *was" not on by default...=20 --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University