public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <jeffreyalaw@gmail.com>
To: Florian Weimer <fweimer@redhat.com>, Yang Yujie <yangyujie@loongson.cn>
Cc: gcc-patches@gcc.gnu.org, ro@CeBiTec.Uni-Bielefeld.DE,
	mikestump@comcast.net
Subject: Re: [PATCH] testsuite: Adjust for the new permerror -Wincompatible-pointer-types
Date: Wed, 6 Dec 2023 10:45:22 -0700	[thread overview]
Message-ID: <c2a579f1-7606-4294-93df-ee442fc45900@gmail.com> (raw)
In-Reply-To: <871qbzcyy4.fsf@oldenburg.str.redhat.com>



On 12/6/23 05:12, Florian Weimer wrote:
> * Yang Yujie:
> 
>> From: Yang Yujie <yangyujie@loongson.cn>
>> Subject: [PATCH] testsuite: Adjust for the new permerror
>>   -Wincompatible-pointer-types
>> To: gcc-patches@gcc.gnu.org
>> Cc: ro@CeBiTec.Uni-Bielefeld.DE, mikestump@comcast.net, fweimer@redhat.com,
>>   Yang Yujie <yangyujie@loongson.cn>
>> Date: Wed,  6 Dec 2023 10:29:31 +0800 (9 hours, 42 minutes, 7 seconds ago)
>> Message-ID: <20231206022931.33437-1-yangyujie@loongson.cn>
>>
>> r14-6037 turned -Wincompatible-pointer-types into a permerror,
>> which causes the following tests to fail.
>>
>> gcc/testsuite/ChangeLog:
>>
>> 	* gcc.dg/fixed-point/composite-type.c: replace dg-warning with dg-error.
>> ---
>>   .../gcc.dg/fixed-point/composite-type.c       | 64 +++++++++----------
>>   1 file changed, 32 insertions(+), 32 deletions(-)
> 
> Looks reasonable to me, but I can't approve it.
We might want to fix that from a policy standpoint :-)

Regardless, this is OK for the trunk.  Thanks Yang for taking care of 
it.  I don't see you in the maintainers file, so I'll go ahead and push 
it momentarily.

jeff

  reply	other threads:[~2023-12-06 17:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-06  2:29 Yang Yujie
2023-12-06 12:12 ` Florian Weimer
2023-12-06 17:45   ` Jeff Law [this message]
2023-12-07  1:30     ` Yang Yujie
2023-12-07  1:35       ` Sam James
2023-12-07  1:42         ` Yang Yujie
2023-12-07  9:18       ` Florian Weimer
2023-12-08  2:00         ` Yang Yujie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c2a579f1-7606-4294-93df-ee442fc45900@gmail.com \
    --to=jeffreyalaw@gmail.com \
    --cc=fweimer@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=mikestump@comcast.net \
    --cc=ro@CeBiTec.Uni-Bielefeld.DE \
    --cc=yangyujie@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).