From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2057.outbound.protection.outlook.com [40.107.7.57]) by sourceware.org (Postfix) with ESMTPS id A93DA3858CD1 for ; Fri, 14 Jul 2023 10:40:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A93DA3858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VA7/PBGAYRYPDt6tfQ6BoY8BeRsz5jr5mNfqtLlqFP10dwtRG7YHbjez/w7OB+btGpV9SOfdQhcMnU9cImWIrYVQRobdXakkYvYpK0iY5mjggx0UzMnGembn5jqJkFqUuHjGZoGlnfGTGjmceAlNy7dlf9BO+u4EW9emBPQvX5ww6dsqclvufzPC+sCr7npG2wtOBaXZnQTPgaPdtVt6ydHmLaKTenaxVuzDrmFv35avEdr5YNkTWE98QBw5w8Khbg6GcGY4bIvpY9sLjPr+C9ka/9l0Ds3G6cWRuYRJKvKzUuVvl6KT3AwjWXERMNKYqJ2LMTh0KT+aRGECrz7cOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R3dAMTz26iL9JvFhbkyj1XCCNl4HY39TxQECSVshwbs=; b=XiAABkTj0PPPsrCfGKnVSZdIqJgjdShUfQjQ8qRIfTc9P5FKbfe7Pk2zWX0a1WM8WqcqIFvXGOtNHHaZynsEvD5h+MVU/JX5WIdVOcxSFzNthEC05nr+TohyUjOoxBgyuYUFhO1uQ0XPaqm4LQgW1FIkdZu9v91QSDpZRnPutOjfJhIfbMWlwFACGXkzYvZs/fcxm4O7o6gfpR8YsvCsmgeY5S6/E7Ms8XVca4K1y8P2VbQSFi/ZkWlkTXitZZdCLfKSN1Gyh/FZjvz3um/vNwv1ZR5hQ86QjgI6qP7gxeHPgkMNAh+CwuQqm5cc/vPNsIfNF4S+F+PapHd4h7kGLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R3dAMTz26iL9JvFhbkyj1XCCNl4HY39TxQECSVshwbs=; b=ctJyyvbqEk3lbOdf4Dm3sOeoZsuUTf1FrtB9jKemdTKRVIJ0TYPp8upNUr5vPc/XlW6dQ9WwCA53SkQ2wvVcbknMISazTiQiUhk5A6RTl8vuSRN0d+BMU1ErKKaRc9QcZeuFITS8YBQPRFkxl8OlJ8IzwKYNVKEc9v4YLxDoi1Nn03em+Ea+T+O3NLXqK8mMLiw4iwJFxu31C+uPf6JM6FRwYDK2agNgtQXksH0qeQ/jWqy2BgdgbUTTHy/aNy0mgbC1C5di1zijcxJwx1yXgAlYaOS1P25ItRFbSGGn+Q6BMHdFPmDSTGwu/4Um9gxgXSuolJqwUiq9VK/sQmDWGg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from AS8PR04MB8788.eurprd04.prod.outlook.com (2603:10a6:20b:42f::21) by AS5PR04MB9969.eurprd04.prod.outlook.com (2603:10a6:20b:67c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.36; Fri, 14 Jul 2023 10:40:25 +0000 Received: from AS8PR04MB8788.eurprd04.prod.outlook.com ([fe80::cbc0:69aa:c9a2:198e]) by AS8PR04MB8788.eurprd04.prod.outlook.com ([fe80::cbc0:69aa:c9a2:198e%7]) with mapi id 15.20.6565.016; Fri, 14 Jul 2023 10:40:25 +0000 Message-ID: Date: Fri, 14 Jul 2023 12:40:22 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] x86: replace "extendhfdf2" expander Content-Language: en-US To: Uros Bizjak Cc: "gcc-patches@gcc.gnu.org" , Hongtao Liu , Kirill Yukhin , Jan Hubicka References: <28de2fc1-79e6-6fef-400c-2991b25d13e1@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0126.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::6) To AS8PR04MB8788.eurprd04.prod.outlook.com (2603:10a6:20b:42f::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8788:EE_|AS5PR04MB9969:EE_ X-MS-Office365-Filtering-Correlation-Id: 3dbdd1c6-f2be-47fb-7216-08db8456bbb0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KPZQHHRL196LxeA77GcMAlh0pj99E9hI4lYSGrEk4ZlR5UY5E+hXQqVfwD+9xPCkuISXHgBd/KuAbIVtln+7n2us/ea6cmchSgLjVNMcfY+R+bb96i/6/JW+PP01ep+JbLqYwMzNjCXcfZcqc3mNJwjTiONSj8xjFAJxPqJIu3A2Dom28qBDgcSdXa+Py9Er15zLvLbEGC/hos1g6Y9E8Rqz1D93RNLKa0oQQsPm5X5PU+DJZblDQKazlgpcXsstrKNwMU46erNAcP+E/ssYQQ5xI4hLRKNxyET7HKU+Etbfy5JV3YM0je0QCBp3TsAYAYt2g7jo7u3+2Xo+dk7bsaFiRXYKf3tNTs2VUAYIb+XT+hbchoH3k/1NDrHcSRALajkl3328nRiQHZbbXxrWN43VxEROKC/FAl0oGjkuxTOHJijPEyU1izW0xw/dY7NdnyfVNEDeA9RIw8vHRl9xGSGbDcEo/HmBIciClgrbVPdSuPXk3hVK1/q7WL92yreUT1e3LMbsT0Xxr8/foaIKyED7QePAUhzed+9nmTSIV/Nh+eZtyOaZa9kK/a2M3GGJQmZScS0JRf3eI7111AcMIWCj1XYNeb2FVP0K/Fcy4T4+sMow2YZa6hIdHe0UlB4cXK0gOKMqNLbYqSlMmnYxcg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8788.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(396003)(376002)(366004)(39860400002)(346002)(451199021)(31686004)(6486002)(478600001)(54906003)(6666004)(53546011)(31696002)(83380400001)(186003)(86362001)(36756003)(2616005)(6512007)(2906002)(6506007)(26005)(4744005)(38100700002)(6916009)(66476007)(66946007)(316002)(41300700001)(8676002)(66556008)(8936002)(4326008)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SUhVVTl3aDZnZlR4Ujdma3ZKdTA2M2JFWjNvQjFXdThTMDMxOW1ZWU1jK2VQ?= =?utf-8?B?aWFPWDk1SGpiT2JqMlNwWmVSVzBlZFVrVklGVTlYN0U5dHhPN2UxckczVTdY?= =?utf-8?B?YXZxa3RiT2U4NWJac0F0UmVlVDd3U2lZaHczcGhsdm5MZFp2alAwWFFQdlRV?= =?utf-8?B?OUtTeE5rdWhINSsxdTFFK3loVDNkbENHUXdNTngyM3B0Y1hIaFZsSldyUEx5?= =?utf-8?B?S0FEK2xNbUZXd3NJQlBqcWhJNXdmQ3BCTHk1aDZmZXhNcndYL1V1L3pnekdw?= =?utf-8?B?U2htUmcrKzRPNDNhSWc2d1g3ZGphdVBUVnZ1ZFByK1U2NEVnbUpwd1ZwNTNj?= =?utf-8?B?RkoxWWFWN25GYWY0OXRQWUJJNndmVmVoWEdoRjEvSzJCblJRTU1JSVE2Qmh6?= =?utf-8?B?SnRDczM0MHkwaTJYVTh0dUlFZkRTODdRVnhORVJHUFhMN2RnRTJHVDRjUjhj?= =?utf-8?B?OWlGR29yR00yWnhzSDd5NEdqd2hZL1BrdnhQQ1hrWXMybkhreDZSbTNhUnVh?= =?utf-8?B?VllwK1J5M1R1eVU2WXhPQWFDclhsZGhOaWw1SzRiNkJBRVI1Z0VCdzdUZXFl?= =?utf-8?B?THFXUWZOOXJvUStKd21wYmllUlJDNEFEWk9XVmtURjlIV1djdHY3KzVvM1g4?= =?utf-8?B?cHlMT3NKMzlWd2ZBVGRlQWo3OG1vaXZsTXIrYXRndGV0SjNLNm10TkRZT0xX?= =?utf-8?B?MFowRU5ueVY1bGR2aU5EQUJqdFVzQkJNRVd3aTRLQmdHNHltaGFpTi9nazY1?= =?utf-8?B?aEp2dm0wcnd1NGFIUThaYlVjckxWU2JoSFpRZ0NBUTRpVldtTlVydWtJcUp4?= =?utf-8?B?K0N2ZjBMT0huSFhDTGRhM2lMKy9seHpwd2grcUNUVnNKZWJwRk9Rd0lJeUtN?= =?utf-8?B?NXV6OGw4emNBS3NJdTlHb1FZY0w1ZE9DSHpwQlZFdU1vYkV4SGJRd1lWNXNK?= =?utf-8?B?REgwNEtrWnFURXQ0YnYxYVl5dmk3cCt4M1gxWVRnaTR6UGZhV09LV082QWlr?= =?utf-8?B?cHdmbENRekluaFNMdmJvdXFTZ1NDYjJ1V2dzdDczSnNMVVRyWnFHWWhOM0Yv?= =?utf-8?B?VmpjZjJvNjJuc1Y3d0d0VVlBTGpaSGlzanVJZ01GQjFDakp1cEMyMHIyelpS?= =?utf-8?B?cTF6SVBoL2VOK2RFOUlnMVU1RndXSXpJbDNMZlNyZXdCRVZUMWhsVnhxL0FN?= =?utf-8?B?WVVYU1NYUFJxck5LRlJjRTdQSi96ZHczbTBxUjQzNDhGdDBERjFGalJ4OU8z?= =?utf-8?B?L3Y2YkN5S3dDUlU4ZDhYT3d5VExpVi9VZFVCK0pNaS9rZ090WGhlczRPNUdz?= =?utf-8?B?N3ZIZnZ0ZGZUWVFoY2dxVGxyamdTM0xpL21xTmV4ck04b3ZCQW14SDJ6Rjg2?= =?utf-8?B?UWpJQW9VUUowM2orMFl5K2NRMERvSzJMdVNBSDhwZ1E3TFVoYWo0aGhneVdI?= =?utf-8?B?MkZvSnR5ZnlmNk9Ndnh2Sm1ZTkVlakxjalR6SVo4UlVTc2NnTUZHVEt3WDRj?= =?utf-8?B?MDI2WmlSNUZSbVI4cjhJMXIwWEdiTENFNlNBakZXQ0pKNWpvM1IvUGVwMmlY?= =?utf-8?B?V2tUUUdiZzc3c2hBenBLelgxTDBqOW1YZ0NRZjU4bnM5Q0ZHRXVEcnVCZG1U?= =?utf-8?B?THVhY21RYkdaZmNjTDZmMGgvK2Q4OERxajBKWVZ0c0FTN0srWmRFcjdTbVkr?= =?utf-8?B?eW4zODl5S2lCU2JSMGRwWGJWTTg1WUVCYzhhMTNucDFUVStUQUZjNlVid3FM?= =?utf-8?B?QkVxQk0zdVBOVmhYZ2VuV2pSNE9WeVJFdlhHcHFGVUoyMkR2UTFkR0RLK0d2?= =?utf-8?B?cnM1WmIzQzFtdkxnZi9EYkd1NkwrUDhzWi9LUXZhMlFLd3dmczhNZ3FwOEcz?= =?utf-8?B?MU80Sk9scnQ5QmR6T1FEU3JPTUxnZVZVTVc4RXBNaGl3L1lQREllVFV5aVVK?= =?utf-8?B?UFJrYWdKemJVK1JzQlM3d2NHSFl3RWlrVzRzcnBPblJiZWtmdlkzZUZxUjdW?= =?utf-8?B?ekVXL2dBVk5YbjdjNEczTjFzUzJXQnBZdXhzd0FVVm1PT2ZhRGZ0ajB1L0kx?= =?utf-8?B?ZFhuZGFZbDRrQjQxYkQ5Z1RUL1RnNC9UWkt4dHFJZGpmd2RJWGVqeWZkeTh2?= =?utf-8?Q?z1yxks+U1U3t21jIovng0tpJV?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3dbdd1c6-f2be-47fb-7216-08db8456bbb0 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8788.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2023 10:40:25.4832 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: W+b3yVQ348+efJjgkENCMQPIsYmWCGrmB90dqQ7EBnrznKDigduXqeVQACnaduUFJ8DMvhCAmGODOaQhbD8sYg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS5PR04MB9969 X-Spam-Status: No, score=-3027.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 14.07.2023 12:10, Uros Bizjak wrote: > On Fri, Jul 14, 2023 at 11:44 AM Jan Beulich wrote: >> >> The corresponding insn serves this purpose quite fine, and leads to >> slightly less (generated) code. All we need is the insn to not have a >> leading * in its name, while retaining that * for "extendhfsf2". >> Introduce a mode attribute in exchange to achieve that. >> >> gcc/ >> >> * config/i386/i386.md (extendhfdf2): Delete expander. >> (extendhf): New mode attribute. >> (*extendhf2): Use it. > > No, please leave the expander, it is there due to extendhfsf2 that > prevents effective macroization. Well, okay then. > FYI, there is no less generated code when the named pattern is used, > the same code is generated from the named pattern as from the > expander. Source code can be shrinked, but in this particular case, > forced macroization complicates things more. Hmm, I'm pretty sure I checked and found some reduction. Jan