From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x32b.google.com (mail-ot1-x32b.google.com [IPv6:2607:f8b0:4864:20::32b]) by sourceware.org (Postfix) with ESMTPS id 653C13858CD1 for ; Fri, 23 Jun 2023 14:57:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 653C13858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ot1-x32b.google.com with SMTP id 46e09a7af769-6b71cdb47e1so659122a34.2 for ; Fri, 23 Jun 2023 07:57:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687532243; x=1690124243; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2rH+1Kb9raJqVEUyEeXdX5IDQQDxCgZ8iXj4SwwF22s=; b=OdkKep5oPzp/0MIuEeY2jTcbZu87yIpy/CpGQGuZIdNWlPnjDxcvATIpRCNVEW6nwi xv2M2kSKyPNVu+zMw/mP+6Ikeqe6L/7DtR4KLK/ngE1ZIS5UufKthBin2O9VfLcTLV4p oOHSGr+oZFbQYZGugMns0EmWHfmYF21z7mUIziG25I5UPgB+xeR6+INmhM0o1aZKrssr YJvwrM2J1NDdo20XL/U4pJm1qy5FO0yTjmZSIol6cA4h5AYnqtYKKexMRz+6D74by5Rd Z7ePkO0msCs6e0Kq4gSyTbWLcLTfcbQWSIquLFTzbPkKHatFn6EMnwg9S4gWkjuoV+yJ 5Z+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687532243; x=1690124243; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2rH+1Kb9raJqVEUyEeXdX5IDQQDxCgZ8iXj4SwwF22s=; b=aYz9gHssdMSOpzKJ84sXJxUwBvwkJ2Oz2FOfnKG1XSvfwfFeSt9gk+0abBfrrIYkm3 U8l7uJxY66xcZr5JYWT4JW53pzpxeU+mfjH8c3+LDNXvJU/yBJ6FDGQnX+b94Xb7z5rt +zbVAugoUnA5moyh0aHkzehaEnySqMm4XJstURoeFCCFz3qQ/dkpM67CFdM2SrWAJHKt /5jHSxodSuwN0NcjUV2Dgq1DLrEC4riI/ytrpKnPYLQE028Ap0C16xXLjiNOPZX3L+MZ xr3NtHfx8ui2VFNywfFp7TLoa9CVCeScuCqGpKvO0mMdhk/ptJ8qBDduJLnkh8Zj3XHm iAQw== X-Gm-Message-State: AC+VfDy/AbfHMYhpnq23JM4eMaWzxnC7/77DAfs+Ffes9/sdfA7JuJn6 GTYKdkCT+eGnzkut282o8UA= X-Google-Smtp-Source: ACHHUZ5f7ztKcgww8zH2xbs+tTtwfHWCrMG1n624hVVcTuSP5Ll3W4wzc11varPQ49SXZQbP973N6g== X-Received: by 2002:a9d:7490:0:b0:6b5:8aaf:1347 with SMTP id t16-20020a9d7490000000b006b58aaf1347mr15876994otk.23.1687532243559; Fri, 23 Jun 2023 07:57:23 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id p14-20020a63e64e000000b005533c53f550sm6552806pgj.45.2023.06.23.07.57.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Jun 2023 07:57:23 -0700 (PDT) Message-ID: Date: Fri, 23 Jun 2023 08:57:21 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] DSE: Add LEN_MASK_STORE analysis into DSE Content-Language: en-US To: juzhe.zhong@rivai.ai, gcc-patches@gcc.gnu.org Cc: rguenther@suse.de, richard.sandiford@arm.com References: <20230623144847.85698-1-juzhe.zhong@rivai.ai> From: Jeff Law In-Reply-To: <20230623144847.85698-1-juzhe.zhong@rivai.ai> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/23/23 08:48, juzhe.zhong@rivai.ai wrote: > From: Ju-Zhe Zhong > > gcc/ChangeLog: > > * tree-ssa-dse.cc (initialize_ao_ref_for_dse): Add LEN_MASK_STORE. > (dse_optimize_stmt): Ditto. > > --- > gcc/tree-ssa-dse.cc | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/gcc/tree-ssa-dse.cc b/gcc/tree-ssa-dse.cc > index 3c7a2e9992d..01b0951f1a9 100644 > --- a/gcc/tree-ssa-dse.cc > +++ b/gcc/tree-ssa-dse.cc > @@ -174,6 +174,23 @@ initialize_ao_ref_for_dse (gimple *stmt, ao_ref *write, bool may_def_ok = false) > return true; > } > break; > + case IFN_LEN_MASK_STORE: { > + /* We cannot initialize a must-def ao_ref (in all cases) but we > + can provide a may-def variant. */ > + if (may_def_ok) > + { > + tree len_size > + = int_const_binop (MINUS_EXPR, gimple_call_arg (stmt, 2), > + gimple_call_arg (stmt, 5)); > + tree mask_size > + = TYPE_SIZE_UNIT (TREE_TYPE (gimple_call_arg (stmt, 4))); > + tree size = int_const_binop (MAX_EXPR, len_size, mask_size); > + ao_ref_init_from_ptr_and_size (write, gimple_call_arg (stmt, 0), > + size); So isn't len_size here the size in elements? If so, don't you need to multiply len_size by the element size? Jeff