public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Bernd Schmidt <bschmidt@redhat.com>
To: Jason Merrill <jason@redhat.com>
Cc: gcc-patches List <gcc-patches@gcc.gnu.org>
Subject: Re: RFC: PATCH to consider MAX_OFILE_ALIGNMENT for targetm.absolute_biggest_alignment
Date: Tue, 13 Sep 2016 11:03:00 -0000	[thread overview]
Message-ID: <c3148fcf-0260-182b-9a67-adadd3e4e909@redhat.com> (raw)
In-Reply-To: <CADzB+2=srCTJSU-vb+ipf=0DGsLrh3hgkycHrHKzdQnD2h2EFA@mail.gmail.com>

On 09/12/2016 08:58 PM, Jason Merrill wrote:
> TARGET_ABSOLUTE_BIGGEST_ALIGNMENT is documented to be the largest
> alignment possible for any type or variable, and defaults to
> BIGGEST_ALIGNMENT.  But MAX_OFILE_ALIGNMENT is typically much larger
> than BIGGEST_ALIGNMENT, and is documented as the limit for __attribute
> ((aligned)).  Shouldn't it be considered in the default for
> absolute_biggest_alignment?  But if we make that change, I expect that
> your ACCEL_COMPILER streamer-in change would become a no-op.  What was
> that change intended to accomplish?  I'm not finding anything about it
> in gcc-patches.

https://gcc.gnu.org/ml/gcc-patches/2014-11/msg00003.html

Its only purpose is to limit alignments when offloading to a different 
target. You may be right about having to use MAX_OFILE_ALIGNMENT; I 
suppose defining it to 64 on nvptx would still work.


Bernd

  reply	other threads:[~2016-09-13 10:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-12 19:00 Jason Merrill
2016-09-13 11:03 ` Bernd Schmidt [this message]
2016-09-13 14:27   ` Jason Merrill
2016-09-13 14:34     ` Bernd Schmidt
2016-09-14 16:43       ` Thomas Schwinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c3148fcf-0260-182b-9a67-adadd3e4e909@redhat.com \
    --to=bschmidt@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jason@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).