From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79324 invoked by alias); 21 Feb 2017 19:27:39 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 79307 invoked by uid 89); 21 Feb 2017 19:27:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 Feb 2017 19:27:38 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E39B88124B; Tue, 21 Feb 2017 19:27:37 +0000 (UTC) Received: from localhost.localdomain (ovpn-123-213.rdu2.redhat.com [10.10.123.213] (may be forged)) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v1LJRVAE014218; Tue, 21 Feb 2017 14:27:33 -0500 Subject: Re: [PATCH 3/6] microblaze: Fixes for RTL checking To: Segher Boessenkool , gcc-patches@gcc.gnu.org References: <0b3332af5c3662c0efdf2d930c06457b0fd3cd13.1487685472.git.segher@kernel.crashing.org> Cc: eager@eagercon.com From: Jeff Law Message-ID: Date: Tue, 21 Feb 2017 19:28:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <0b3332af5c3662c0efdf2d930c06457b0fd3cd13.1487685472.git.segher@kernel.crashing.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg01338.txt.bz2 On 02/21/2017 07:48 AM, Segher Boessenkool wrote: > REGNO can only be called on REGs, not SUBREGs; and INTVAL does not work > on REGs. > > 2017-02-21 Segher Boessenkool > > * config/microblaze/microblaze.c (microblaze_expand_shift): Do not > test for register moves to themselves. > * config/microblaze/microblaze.md (*ashlsi3_byone, *ashrsi3_byone, > *lshrsi3_byone): Test for const1_rtx instead of calling INTVAL on > something that isn't necessarily a CONST_INT. So I wanted to make sure that the avoidance of a nop-move resulting from a nop-shift wasn't because the ISA couldn't encode a nop-move (and yes, I've run into such ISAs). The microblaze doesn't seem to have any trouble encoding a nop move, so if we were to generate one due to this change it won't cause a problem. OK for the trunk. Jeff