public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH][wwwdocs] remove references to java in htdocs/projects/beginner.html
@ 2021-11-19  1:37 Eric Gallager
  2021-11-19  6:48 ` Gerald Pfeifer
  0 siblings, 1 reply; 8+ messages in thread
From: Eric Gallager @ 2021-11-19  1:37 UTC (permalink / raw)
  To: gcc-patches

[-- Attachment #1: Type: text/plain, Size: 716 bytes --]

So, on the wiki page for EasyHacks
<https://gcc.gnu.org/wiki/EasyHacks>, it says: "There is also a
non-wiki list of beginner projects at
http://gcc.gnu.org/projects/beginner.html, however, it is very
outdated and the projects are not that easy." Since I don't have an
account on the wiki (since creating a separate wiki account that's
different from my Bugzilla account would create difficulties for my
password manager), but I do have commit access, I'd find it easier to
just edit the page linked to in wwwdocs instead, so I'm going to start
seeing what I can do to update it. I figured I'd start by removing the
references to Java in it, since Java has been removed. A patch to do
that is attached.
Eric Gallager

[-- Attachment #2: patch-beginner-projects-01.diff --]
[-- Type: application/octet-stream, Size: 1043 bytes --]

diff --git a/htdocs/projects/beginner.html b/htdocs/projects/beginner.html
index 0a705dbf..3380df40 100644
--- a/htdocs/projects/beginner.html
+++ b/htdocs/projects/beginner.html
@@ -162,7 +162,6 @@ be done with the maintainers of those files.</p>
 targets:</p>
 
 <pre>
-	494K java/parse.y
 	413K combine.c
 	408K dwarf2out.c
 	375K cp/pt.c
@@ -218,9 +217,7 @@ less likely that someone will muck with action code and then forget to
 rebuild the generated parser and check it in.</p>
 
 <p>We also want to minimize the number of helper functions embedded in
-the grammar file.  <code>java/parse.y</code> is a particularly bad
-example, having upwards of 10,000 lines of code after the second
-<code>%%</code>.</p>
+the grammar file.</p>
 </li>
 
 <li>Break up enormous functions.
@@ -849,8 +846,6 @@ include files.  Remember that we already have define_constants.</p>
 
 <ul>
 
-<li>Implement <samp>-std</samp> for the Java front end?</li>
-
 <li>Fix the places where <samp>-std=c89</samp> is not the same thing
 as <samp>-ansi</samp>.</li>
 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH][wwwdocs] remove references to java in htdocs/projects/beginner.html
  2021-11-19  1:37 [PATCH][wwwdocs] remove references to java in htdocs/projects/beginner.html Eric Gallager
@ 2021-11-19  6:48 ` Gerald Pfeifer
  2021-11-19 13:14   ` Eric Gallager
  0 siblings, 1 reply; 8+ messages in thread
From: Gerald Pfeifer @ 2021-11-19  6:48 UTC (permalink / raw)
  To: Eric Gallager; +Cc: gcc-patches

On Thu, 18 Nov 2021, Eric Gallager wrote:
> I'd find it easier to just edit the page linked to in wwwdocs instead, 
> so I'm going to start seeing what I can do to update it. I figured I'd 
> start by removing the references to Java in it, since Java has been 
> removed. A patch to do that is attached. Eric Gallager

Cool, thank you!

Please feel free to commit patches like this without asking for
approval (though I'm happy to review and approve).

Gerald


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH][wwwdocs] remove references to java in htdocs/projects/beginner.html
  2021-11-19  6:48 ` Gerald Pfeifer
@ 2021-11-19 13:14   ` Eric Gallager
  2021-11-23 23:27     ` [committed][wwwdocs] Remove section on traditional C from htdocs/projects/beginner.html Eric Gallager
  0 siblings, 1 reply; 8+ messages in thread
From: Eric Gallager @ 2021-11-19 13:14 UTC (permalink / raw)
  To: Gerald Pfeifer; +Cc: gcc-patches

On Fri, Nov 19, 2021 at 1:48 AM Gerald Pfeifer <gerald@pfeifer.com> wrote:
>
> On Thu, 18 Nov 2021, Eric Gallager wrote:
> > I'd find it easier to just edit the page linked to in wwwdocs instead,
> > so I'm going to start seeing what I can do to update it. I figured I'd
> > start by removing the references to Java in it, since Java has been
> > removed. A patch to do that is attached. Eric Gallager
>
> Cool, thank you!
>
> Please feel free to commit patches like this without asking for
> approval (though I'm happy to review and approve).
>
> Gerald
>

OK thanks; committed as dbaebcd

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [committed][wwwdocs] Remove section on traditional C from htdocs/projects/beginner.html
  2021-11-19 13:14   ` Eric Gallager
@ 2021-11-23 23:27     ` Eric Gallager
  2021-11-24  7:11       ` [PATCH][wwwdocs] Update section on enormous source files in htdocs/projects/beginner.html Eric Gallager
  0 siblings, 1 reply; 8+ messages in thread
From: Eric Gallager @ 2021-11-23 23:27 UTC (permalink / raw)
  To: Gerald Pfeifer; +Cc: gcc-patches

On Fri, Nov 19, 2021 at 8:14 AM Eric Gallager <egall@gwmail.gwu.edu> wrote:
>
> On Fri, Nov 19, 2021 at 1:48 AM Gerald Pfeifer <gerald@pfeifer.com> wrote:
> >
> > Cool, thank you!
> >
> > Please feel free to commit patches like this without asking for
> > approval (though I'm happy to review and approve).
> >
> > Gerald
> >
>
> OK thanks; committed as dbaebcd

I've also committed one to remove the section on traditional C now:
https://gcc.gnu.org/git/?p=gcc-wwwdocs.git;a=commitdiff;h=ca83c13ad6bf0d351220dafa36264ebc7a6b7816

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH][wwwdocs] Update section on enormous source files in htdocs/projects/beginner.html
  2021-11-23 23:27     ` [committed][wwwdocs] Remove section on traditional C from htdocs/projects/beginner.html Eric Gallager
@ 2021-11-24  7:11       ` Eric Gallager
  2021-12-01 15:14         ` PING " Eric Gallager
  2021-12-01 15:54         ` Gerald Pfeifer
  0 siblings, 2 replies; 8+ messages in thread
From: Eric Gallager @ 2021-11-24  7:11 UTC (permalink / raw)
  To: Gerald Pfeifer; +Cc: gcc-patches

[-- Attachment #1: Type: text/plain, Size: 875 bytes --]

On Tue, Nov 23, 2021 at 6:27 PM Eric Gallager <egall@gwmail.gwu.edu> wrote:
>
> On Fri, Nov 19, 2021 at 8:14 AM Eric Gallager <egall@gwmail.gwu.edu> wrote:
> >
> > On Fri, Nov 19, 2021 at 1:48 AM Gerald Pfeifer <gerald@pfeifer.com> wrote:
> > >
> > > Cool, thank you!
> > >
> > > Please feel free to commit patches like this without asking for
> > > approval (though I'm happy to review and approve).
> > >
> > > Gerald
> > >
> >
> > OK thanks; committed as dbaebcd
>
> I've also committed one to remove the section on traditional C now:
> https://gcc.gnu.org/git/?p=gcc-wwwdocs.git;a=commitdiff;h=ca83c13ad6bf0d351220dafa36264ebc7a6b7816

This next patch does more than just removing old stuff: it adds an
extra sentence to describe a shell command used to generate a list, so
to verify that I've got the shell command right, I'm asking for a
review.

Thanks,
Eric Gallager

[-- Attachment #2: patch-beginner-projects-02.diff --]
[-- Type: application/octet-stream, Size: 1340 bytes --]

diff --git a/htdocs/projects/beginner.html b/htdocs/projects/beginner.html
index 589b47c8..08c4bdce 100644
--- a/htdocs/projects/beginner.html
+++ b/htdocs/projects/beginner.html
@@ -135,25 +135,33 @@ to take those patches too.</p>
 targets:</p>
 
 <pre>
-	413K combine.c
-	408K dwarf2out.c
-	375K cp/pt.c
-	367K fold-const.c
-	356K loop.c
-	342K cp/decl.c
-	278K expr.c
-	238K cp/class.c
-	234K c-typeck.c
-	233K cse.c
-	231K c-decl.c
-	200K cp/typeck.c
-	168K function.c
+	1.4M	cp/parser.c
+	1000K	dwarf2out.c
+	932K	cp/pt.c
+	684K	c/c-parser.c
+	576K	cp/decl.c
+	516K	cp/module.cc
+	512K	fold-const.c
+	500K	gimplify.c
+	492K	c/c-typeck.c
+	484K	combine.c
+	460K	omp-low.c
+	432K	tree.c
+	408K	expr.c
+	404K	cp/call.c
 </pre>
 
-<p>There are several other files in this size range, which I have left
+<p>There are several other files in this size range, which are left
 out because touching them at all is unwise (reload, the Fortran front
 end).  You can try, but I am not responsible for any damage to your
 sanity which may result.</p>
+
+<p>Note that the list of large files in this section is generated with the
+following shell command, run from the gcc subdirectory:</p>
+
+<pre>
+	du -sh *.{c,h,cc} */*.{c,h,cc} | sort -hr | grep -v fortran | head -n 14
+</pre>
 </li>
 
 <li>Remove as much code from parser actions as possible.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* PING [PATCH][wwwdocs] Update section on enormous source files in htdocs/projects/beginner.html
  2021-11-24  7:11       ` [PATCH][wwwdocs] Update section on enormous source files in htdocs/projects/beginner.html Eric Gallager
@ 2021-12-01 15:14         ` Eric Gallager
  2021-12-01 15:54         ` Gerald Pfeifer
  1 sibling, 0 replies; 8+ messages in thread
From: Eric Gallager @ 2021-12-01 15:14 UTC (permalink / raw)
  To: Gerald Pfeifer; +Cc: gcc-patches

Hi, I'd like to ping this patch:
https://gcc.gnu.org/pipermail/gcc-patches/2021-November/585294.html

On Wed, Nov 24, 2021 at 2:11 AM Eric Gallager <egall@gwmail.gwu.edu> wrote:
>
> On Tue, Nov 23, 2021 at 6:27 PM Eric Gallager <egall@gwmail.gwu.edu> wrote:
> >
> > On Fri, Nov 19, 2021 at 8:14 AM Eric Gallager <egall@gwmail.gwu.edu> wrote:
> > >
> > > On Fri, Nov 19, 2021 at 1:48 AM Gerald Pfeifer <gerald@pfeifer.com> wrote:
> > > >
> > > > Cool, thank you!
> > > >
> > > > Please feel free to commit patches like this without asking for
> > > > approval (though I'm happy to review and approve).
> > > >
> > > > Gerald
> > > >
> > >
> > > OK thanks; committed as dbaebcd
> >
> > I've also committed one to remove the section on traditional C now:
> > https://gcc.gnu.org/git/?p=gcc-wwwdocs.git;a=commitdiff;h=ca83c13ad6bf0d351220dafa36264ebc7a6b7816
>
> This next patch does more than just removing old stuff: it adds an
> extra sentence to describe a shell command used to generate a list, so
> to verify that I've got the shell command right, I'm asking for a
> review.
>
> Thanks,
> Eric Gallager

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH][wwwdocs] Update section on enormous source files in htdocs/projects/beginner.html
  2021-11-24  7:11       ` [PATCH][wwwdocs] Update section on enormous source files in htdocs/projects/beginner.html Eric Gallager
  2021-12-01 15:14         ` PING " Eric Gallager
@ 2021-12-01 15:54         ` Gerald Pfeifer
  2021-12-01 17:26           ` Eric Gallager
  1 sibling, 1 reply; 8+ messages in thread
From: Gerald Pfeifer @ 2021-12-01 15:54 UTC (permalink / raw)
  To: Eric Gallager; +Cc: gcc-patches

Hi Eric,

On Wed, 24 Nov 2021, Eric Gallager wrote:
> This next patch does more than just removing old stuff: it adds an
> extra sentence to describe a shell command used to generate a list, so
> to verify that I've got the shell command right, I'm asking for a
> review.

-<p>There are several other files in this size range, which I have left
+<p>There are several other files in this size range, which are left
 out because touching them at all is unwise (reload, the Fortran front
 end).  You can try, but I am not responsible for any damage to your
 sanity which may result.</p>

while we are touching this, how about toning the second half of this
paragraph down and moving away from first person?

How about something like "...breaking them up likely may prove rather
difficult" (or similar, happy to leave this to you as native spaker)?


+<p>Note that the list of large files in this section is generated with the
+following shell command, run from the gcc subdirectory:</p>
+
+<pre>
+	du -sh *.{c,h,cc} */*.{c,h,cc} | sort -hr | grep -v fortran | head -n 14
+</pre>

This looks like it does what you want it to do.

(Pulling up the database courses I have given in a previous life, I'd pull 
in the grep before the sort - O(n) filtering before O(n·log n) processing
- but even on my notebook both are instantenous. ;-) )


Please consider the two suggestions above and commit the result; just
share the final patch here (no review required).

Thanks,
Gerald

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH][wwwdocs] Update section on enormous source files in htdocs/projects/beginner.html
  2021-12-01 15:54         ` Gerald Pfeifer
@ 2021-12-01 17:26           ` Eric Gallager
  0 siblings, 0 replies; 8+ messages in thread
From: Eric Gallager @ 2021-12-01 17:26 UTC (permalink / raw)
  To: Gerald Pfeifer; +Cc: gcc-patches

[-- Attachment #1: Type: text/plain, Size: 2003 bytes --]

On Wed, Dec 1, 2021 at 10:54 AM Gerald Pfeifer <gerald@pfeifer.com> wrote:
>
> Hi Eric,
>
> On Wed, 24 Nov 2021, Eric Gallager wrote:
> > This next patch does more than just removing old stuff: it adds an
> > extra sentence to describe a shell command used to generate a list, so
> > to verify that I've got the shell command right, I'm asking for a
> > review.
>
> -<p>There are several other files in this size range, which I have left
> +<p>There are several other files in this size range, which are left
>  out because touching them at all is unwise (reload, the Fortran front
>  end).  You can try, but I am not responsible for any damage to your
>  sanity which may result.</p>
>
> while we are touching this, how about toning the second half of this
> paragraph down and moving away from first person?
>
> How about something like "...breaking them up likely may prove rather
> difficult" (or similar, happy to leave this to you as native spaker)?
>

OK yeah I did remove the first instance of the first person in that
paragraph, but couldn't think of a better wording for the second one,
so that suggestion is helpful; thanks.

>
> +<p>Note that the list of large files in this section is generated with the
> +following shell command, run from the gcc subdirectory:</p>
> +
> +<pre>
> +       du -sh *.{c,h,cc} */*.{c,h,cc} | sort -hr | grep -v fortran | head -n 14
> +</pre>
>
> This looks like it does what you want it to do.
>
> (Pulling up the database courses I have given in a previous life, I'd pull
> in the grep before the sort - O(n) filtering before O(n·log n) processing
> - but even on my notebook both are instantenous. ;-) )
>
>
> Please consider the two suggestions above and commit the result; just
> share the final patch here (no review required).
>
> Thanks,
> Gerald

OK thanks, I committed the attached patch as f4b4d0f:
https://gcc.gnu.org/git/?p=gcc-wwwdocs.git;a=commitdiff;h=f4b4d0f783246dd6f58944cdb542446d5e7589d3

[-- Attachment #2: patch-beginner-projects-02.diff --]
[-- Type: application/octet-stream, Size: 1477 bytes --]

diff --git a/htdocs/projects/beginner.html b/htdocs/projects/beginner.html
index 589b47c8..5ad00ad8 100644
--- a/htdocs/projects/beginner.html
+++ b/htdocs/projects/beginner.html
@@ -135,25 +135,33 @@ to take those patches too.</p>
 targets:</p>
 
 <pre>
-	413K combine.c
-	408K dwarf2out.c
-	375K cp/pt.c
-	367K fold-const.c
-	356K loop.c
-	342K cp/decl.c
-	278K expr.c
-	238K cp/class.c
-	234K c-typeck.c
-	233K cse.c
-	231K c-decl.c
-	200K cp/typeck.c
-	168K function.c
+	1.4M	cp/parser.c
+	1000K	dwarf2out.c
+	932K	cp/pt.c
+	684K	c/c-parser.c
+	576K	cp/decl.c
+	516K	cp/module.cc
+	512K	fold-const.c
+	500K	gimplify.c
+	492K	c/c-typeck.c
+	484K	combine.c
+	460K	omp-low.c
+	432K	tree.c
+	408K	expr.c
+	404K	cp/call.c
 </pre>
 
-<p>There are several other files in this size range, which I have left
+<p>There are several other files in this size range, which are left
 out because touching them at all is unwise (reload, the Fortran front
-end).  You can try, but I am not responsible for any damage to your
-sanity which may result.</p>
+end).  You can try, but breaking them up likely may prove rather
+difficult, so beware of the level of challenge before attempting.</p>
+
+<p>Note that the list of large files in this section is generated with the
+following shell command, run from the gcc subdirectory:</p>
+
+<pre>
+	du -sh *.{c,h,cc} */*.{c,h,cc} | grep -v fortran | sort -hr | head -n 14
+</pre>
 </li>
 
 <li>Remove as much code from parser actions as possible.

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-12-01 17:26 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-19  1:37 [PATCH][wwwdocs] remove references to java in htdocs/projects/beginner.html Eric Gallager
2021-11-19  6:48 ` Gerald Pfeifer
2021-11-19 13:14   ` Eric Gallager
2021-11-23 23:27     ` [committed][wwwdocs] Remove section on traditional C from htdocs/projects/beginner.html Eric Gallager
2021-11-24  7:11       ` [PATCH][wwwdocs] Update section on enormous source files in htdocs/projects/beginner.html Eric Gallager
2021-12-01 15:14         ` PING " Eric Gallager
2021-12-01 15:54         ` Gerald Pfeifer
2021-12-01 17:26           ` Eric Gallager

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).