From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) by sourceware.org (Postfix) with ESMTPS id AD0B63858D32 for ; Sat, 17 Sep 2022 00:22:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AD0B63858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-x52d.google.com with SMTP id s206so21789527pgs.3 for ; Fri, 16 Sep 2022 17:22:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=OfWN0S7xHatONxe5BPY3qFaAfATDrAeCcj2zAnt/YI4=; b=jWG8y/0Ar2/xwJADyy365eAC5Zqtg3B2KKbjaSCUDuCsJKW+1jLdu8xsLlBKQaqv9Y /KIVgU17V2OF9SrL46sBrMSbUG84UZWoPGu2fLLQgsTMw8AIRkTweMQL81OCIYXIa/Mw NfGfwESSxn9felJMkBdCagD48np4qmUGgEkm6/ADzgjJfAJcZOTFL+zNRulSaksrK9mY OWc71zvDS4QiB4BSyz35umin9al05MwqMdQ3IlyyIUFwYsYr0+3z3NNFFIv6uRfAFfdx l5YTsZEjBEPoxu0YMgonSOsPDX6IMXbsn9iPPPPI4vBRuWT2bpRL6yff26jRPXKRoSMc qS1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=OfWN0S7xHatONxe5BPY3qFaAfATDrAeCcj2zAnt/YI4=; b=4wGrckJ/gknUUtRgdWWeHqHtkqJoL9/g/avU9K0BfL1QIA27s0U7wQ+Dj9dxx7uw8m iCDrYkmYFz89GsTl64qijpdEL4EsYPY5ZiChTfF1xML2tv2+3E09TqMCkxhx/f8vDLl0 Gmo2XlKHmE/a11UOQuqn+zinHBz9ScbjI1/igEaqM4bVhlZcHetg2saEcyQG+jw+gU4f DPUL6sr77ZXrav7VO/spony9KaQJoAp/lmQdZ9MCBkYsBnGq2M46xSpKiZTLMgESqP+l 2TSxwzFfP3U1OjJgnD74425h8osPvmCcsf0saaGK4/LtLv6PW5uJaNnFRKcBxIGLtBx9 ZCyw== X-Gm-Message-State: ACrzQf0e9XY5CnOD1UTxJcEIdgYKSnm41CeJ8bsSMtWN3XFI9s6rS+XZ +kF7VqBwVCrA4axJvaordLf3XB+ZIuhMVg== X-Google-Smtp-Source: AMsMyM5MlZcqBM919LYxpLJc0x5Qdo2SIoSt33qfN0X2Dny4ZlxSVmWvMw549UY589Wm4AjWQwinGw== X-Received: by 2002:a65:42c8:0:b0:41a:8138:f47f with SMTP id l8-20020a6542c8000000b0041a8138f47fmr6760970pgp.476.1663374170118; Fri, 16 Sep 2022 17:22:50 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id z189-20020a6233c6000000b0054087e1aea4sm15695466pfz.15.2022.09.16.17.22.49 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Sep 2022 17:22:49 -0700 (PDT) Message-ID: Date: Fri, 16 Sep 2022 18:22:48 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] C-SKY: Fix unsigned comparison warning Content-Language: en-US To: gcc-patches@gcc.gnu.org References: <20220912121923.fazqolix7neh77uz@lug-owl.de> From: Jeff Law In-Reply-To: <20220912121923.fazqolix7neh77uz@lug-owl.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/12/22 06:19, Jan-Benedict Glaw wrote: > Hi! > > When -mfloat-abi=hard support was added, a cast went missing that > used to silence a warning in common code: > > /usr/lib/gcc-snapshot/bin/g++ -fno-PIE -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -Werror -fno-common -DHAVE_CONFIG_H -I. -I. -I../../gcc/gcc -I../../gcc/gcc/. -I../../gcc/gcc/../include -I../../gcc/gcc/../libcpp/include -I../../gcc/gcc/../libcody -I../../gcc/gcc/../libdecnumber -I../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I../../gcc/gcc/../libbacktrace -o builtins.o -MT builtins.o -MMD -MP -MF ./.deps/builtins.TPo ../../gcc/gcc/builtins.cc > In file included from ./tm.h:21, > from ../../gcc/gcc/backend.h:28, > from ../../gcc/gcc/builtins.cc:27: > ../../gcc/gcc/builtins.cc: In function 'int apply_args_size()': > ../../gcc/gcc/config/csky/csky.h:421:13: error: comparison of unsigned expression in '>= 0' is always true [-Werror=type-limits] > 421 | (((REGNO) >= CSKY_FIRST_PARM_REGNUM \ > ../../gcc/gcc/builtins.cc:1444:13: note: in expansion of macro 'FUNCTION_ARG_REGNO_P' > 1444 | if (FUNCTION_ARG_REGNO_P (regno)) > | ^~~~~~~~~~~~~~~~~~~~ > cc1plus: all warnings being treated as errors > make[1]: *** [Makefile:1146: builtins.o] Error 1 > > The needed (int) cast is even mentioned in the comment above, so reinstate > it here. > > > > 2022-09-06 Jan-Benedict Glaw > > gcc/ChangeLog: > * config/csky/csky.h (FUNCTION_ARG_REGNO_P): Cast REGNO to (int) > to prevent warning. OK jeff