From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99314 invoked by alias); 14 Jul 2017 17:02:16 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 99286 invoked by uid 89); 14 Jul 2017 17:02:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=objective X-HELO: mail-it0-f42.google.com Received: from mail-it0-f42.google.com (HELO mail-it0-f42.google.com) (209.85.214.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 14 Jul 2017 17:02:13 +0000 Received: by mail-it0-f42.google.com with SMTP id m68so24748489ith.1 for ; Fri, 14 Jul 2017 10:02:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to; bh=kgMZYq4w/UWFXNK1kQL6f0vNfoY9HqiU+s+cn8kc/E8=; b=V1tYGVhyBeuAk08ZNhijJmAyxM6M9whMcTQd5261S/m/31zXBFnv94LDs2JA2m0jAS quCsGHJHX5Bx4FuTHc6D1HOIJNhog886UgfqaJNq74QxEdIqeHq0Qs15r+nkgTSOgQc4 wN0p4828CxCT87ZUUc/r1H330SEyD3ik/7dMNlhzRbCDh33F3Qq5hbAj0ifCxO58+T78 s9qubiwwRak9jtYkRdEZrcHqDSpQrctqMO+YkrKkAmm9BTEBy2xMFyUtt5NhOqt4V3zO ASl6fmUTEDpfdc8fsSz6ZVRR3Ku01HlICIiygnVcrgRp+UxnXJMjzTYgDB/3DDps5453 Wd+w== X-Gm-Message-State: AIVw1124I9cmy1kIsGETEdGAhs6gSq/BFtSdUjKC6kMcNMPjUQJMderv /f6wwyI0leeOUQ== X-Received: by 10.36.17.69 with SMTP id 66mr4560830itf.9.1500051731382; Fri, 14 Jul 2017 10:02:11 -0700 (PDT) Received: from [100.64.209.104] (public-120-7.nat.utoronto.ca. [138.51.120.7]) by smtp.googlemail.com with ESMTPSA id a65sm4957767ioj.51.2017.07.14.10.02.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Jul 2017 10:02:10 -0700 (PDT) Subject: Re: [PATCH] Kill TYPE_METHODS objc 8/9 To: GCC Patches References: <8377f2cd-577c-60b2-63ac-f2619ebe63aa@acm.org> Cc: Jason Merrill , Richard Guenther , Jim Wilson , Jan Hubicka From: Nathan Sidwell Message-ID: Date: Fri, 14 Jul 2017 17:02:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <8377f2cd-577c-60b2-63ac-f2619ebe63aa@acm.org> Content-Type: multipart/mixed; boundary="------------4FD915DCBAE1E668B61B711D" X-SW-Source: 2017-07/txt/msg00855.txt.bz2 This is a multi-part message in MIME format. --------------4FD915DCBAE1E668B61B711D Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-length: 280 This bit of the objective C runtime already knows that TYPE_FIELDS might contain non-FIELD_DECL things. But it has the delightful assumption that the first thing is a FIELD_DECL, which apparently was fine until now. Fixed by simplifying the loop. nathan -- Nathan Sidwell --------------4FD915DCBAE1E668B61B711D Content-Type: text/plain; charset=UTF-8; name="method-objc.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="method-objc.diff" Content-length: 3124 MjAxNy0wNy0xNCAgTmF0aGFuIFNpZHdlbGwgIDxuYXRoYW5AYWNtLm9yZz4K CglnY2Mvb2JqYy8KCSogb2JqYy1ydW50aW1lLXNoYXJlZC1zdXBwb3J0LmMg KGJ1aWxkX2l2YXJfbGlzdF9pbml0aWFsaXplcik6CglEb24ndCBwcmVzdW1l IGZpcnN0IGl0ZW0gaXMgYSBGSUVMRF9ERUNMLgoKSW5kZXg6IGdjYy9vYmpj L29iamMtcnVudGltZS1zaGFyZWQtc3VwcG9ydC5jCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIGdjYy9vYmpjL29iamMtcnVudGltZS1zaGFyZWQtc3Vw cG9ydC5jCShyZXZpc2lvbiAyNTAxNjApCisrKyBnY2Mvb2JqYy9vYmpjLXJ1 bnRpbWUtc2hhcmVkLXN1cHBvcnQuYwkod29ya2luZyBjb3B5KQpAQCAtNTI4 LDM0ICs1MjgsMzIgQEAgYnVpbGRfaXZhcl9saXN0X2luaXRpYWxpemVyICh0 cmVlIHR5cGUsCiB7CiAgIHZlYzxjb25zdHJ1Y3Rvcl9lbHQsIHZhX2djPiAq aW5pdHMgPSBOVUxMOwogCi0gIGRvCi0gICAgewotICAgICAgdmVjPGNvbnN0 cnVjdG9yX2VsdCwgdmFfZ2M+ICppdmFyID0gTlVMTDsKLSAgICAgIHRyZWUg aWQ7CisgIGZvciAoOyBmaWVsZF9kZWNsOyBmaWVsZF9kZWNsID0gREVDTF9D SEFJTiAoZmllbGRfZGVjbCkpCisgICAgaWYgKFRSRUVfQ09ERSAoZmllbGRf ZGVjbCkgPT0gRklFTERfREVDTCkKKyAgICAgIHsKKwl2ZWM8Y29uc3RydWN0 b3JfZWx0LCB2YV9nYz4gKml2YXIgPSBOVUxMOworCXRyZWUgaWQ7CiAKLSAg ICAgIC8qIFNldCBuYW1lLiAgKi8KLSAgICAgIGlmIChERUNMX05BTUUgKGZp ZWxkX2RlY2wpKQotCUNPTlNUUlVDVE9SX0FQUEVORF9FTFQgKGl2YXIsIE5V TExfVFJFRSwKLQkJCQlhZGRfb2JqY19zdHJpbmcgKERFQ0xfTkFNRSAoZmll bGRfZGVjbCksCi0JCQkJCQkgbWV0aF92YXJfbmFtZXMpKTsKLSAgICAgIGVs c2UKLQkvKiBVbm5hbWVkIGJpdC1maWVsZCBpdmFyICh5dWNrKS4gICovCi0J Q09OU1RSVUNUT1JfQVBQRU5EX0VMVCAoaXZhciwgTlVMTF9UUkVFLCBidWls ZF9pbnRfY3N0IChOVUxMX1RSRUUsIDApKTsKKwkvKiBTZXQgbmFtZS4gICov CisJaWYgKERFQ0xfTkFNRSAoZmllbGRfZGVjbCkpCisJICBDT05TVFJVQ1RP Ul9BUFBFTkRfRUxUIChpdmFyLCBOVUxMX1RSRUUsCisJCQkJICBhZGRfb2Jq Y19zdHJpbmcgKERFQ0xfTkFNRSAoZmllbGRfZGVjbCksCisJCQkJCQkgICBt ZXRoX3Zhcl9uYW1lcykpOworCWVsc2UKKwkgIC8qIFVubmFtZWQgYml0LWZp ZWxkIGl2YXIgKHl1Y2spLiAgKi8KKwkgIENPTlNUUlVDVE9SX0FQUEVORF9F TFQgKGl2YXIsIE5VTExfVFJFRSwKKwkJCQkgIGJ1aWxkX2ludF9jc3QgKE5V TExfVFJFRSwgMCkpOwogCi0gICAgICAvKiBTZXQgdHlwZS4gICovCi0gICAg ICBpZCA9IGFkZF9vYmpjX3N0cmluZyAoZW5jb2RlX2ZpZWxkX2RlY2wgKGZp ZWxkX2RlY2wpLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgIG1ldGhf dmFyX3R5cGVzKTsKLSAgICAgIENPTlNUUlVDVE9SX0FQUEVORF9FTFQgKGl2 YXIsIE5VTExfVFJFRSwgaWQpOworCS8qIFNldCB0eXBlLiAgKi8KKwlpZCA9 IGFkZF9vYmpjX3N0cmluZyAoZW5jb2RlX2ZpZWxkX2RlY2wgKGZpZWxkX2Rl Y2wpLAorCQkJICAgICAgbWV0aF92YXJfdHlwZXMpOworCUNPTlNUUlVDVE9S X0FQUEVORF9FTFQgKGl2YXIsIE5VTExfVFJFRSwgaWQpOwogCi0gICAgICAv KiBTZXQgb2Zmc2V0LiAgKi8KLSAgICAgIENPTlNUUlVDVE9SX0FQUEVORF9F TFQgKGl2YXIsIE5VTExfVFJFRSwgYnl0ZV9wb3NpdGlvbiAoZmllbGRfZGVj bCkpOwotICAgICAgQ09OU1RSVUNUT1JfQVBQRU5EX0VMVCAoaW5pdHMsIE5V TExfVFJFRSwKLQkJCSAgICAgIG9iamNfYnVpbGRfY29uc3RydWN0b3IgKHR5 cGUsIGl2YXIpKTsKLSAgICAgIGRvCi0JZmllbGRfZGVjbCA9IERFQ0xfQ0hB SU4gKGZpZWxkX2RlY2wpOwotICAgICAgd2hpbGUgKGZpZWxkX2RlY2wgJiYg VFJFRV9DT0RFIChmaWVsZF9kZWNsKSAhPSBGSUVMRF9ERUNMKTsKKwkvKiBT ZXQgb2Zmc2V0LiAgKi8KKwlDT05TVFJVQ1RPUl9BUFBFTkRfRUxUIChpdmFy LCBOVUxMX1RSRUUsIGJ5dGVfcG9zaXRpb24gKGZpZWxkX2RlY2wpKTsKKwlD T05TVFJVQ1RPUl9BUFBFTkRfRUxUIChpbml0cywgTlVMTF9UUkVFLAorCQkJ CW9iamNfYnVpbGRfY29uc3RydWN0b3IgKHR5cGUsIGl2YXIpKTsKICAgICB9 Ci0gIHdoaWxlIChmaWVsZF9kZWNsKTsKIAogICByZXR1cm4gb2JqY19idWls ZF9jb25zdHJ1Y3RvciAoYnVpbGRfYXJyYXlfdHlwZSAodHlwZSwgMCksIGlu aXRzKTsKIH0K --------------4FD915DCBAE1E668B61B711D--