From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12c.google.com (mail-il1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) by sourceware.org (Postfix) with ESMTPS id C4DB83858C53 for ; Sun, 19 Mar 2023 16:58:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C4DB83858C53 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-il1-x12c.google.com with SMTP id h7so5433064ila.5 for ; Sun, 19 Mar 2023 09:58:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679245089; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=GUjU4nxmJDLj7cWhH/OvZbw/f5T41IL7i2SFpvGpPn8=; b=OnuTJxrZHhVQQu4elflV3aAKimncQRLE4FTxdg3bMuHRqIVnKtDr3t3tbIGlxzR3xY 4JR56W02vHJm8xDC1gkTA7K/m/Z4Ftvdt+fCzlaJWjnQSZQcD3/MA3GiKhlc0lP/ESXE EC/jLY541JaPSIFsoxgCNBF2YNAkeHVVpj+TfAP+/I/oU9IY0clLS/gyXsTnrYn+oPQE q0vpJM3Y0ch7R/9UxLB41W4xJvM+jFzvOycnViNSRxpPSnCyzJ1tu5AjWOPE/oE76feH tHS2U+6NWk6PJvIIVRqkpyuQZCyTDWfrK+L8f7um/eIl6TMzZHmAOBhBmfsGq9Jijc3H /X2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679245089; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GUjU4nxmJDLj7cWhH/OvZbw/f5T41IL7i2SFpvGpPn8=; b=Spgb1Zw0Vag+LyCJGYGr+bjnfYa1WkLQn4pSKUPqGZUZt/YhiMnnkrlgRm3ewHunSi SX/MAxeKN0z4f9BJplQ6Y5Lu+e3dgrktsVqzh4Kg4mkLp4/qvLvSqBZbZm1IjGyZs80X wcxlwH7NkyK7UNk8yoPTrmA6ajTJu802a6Rc3ILGmxTYfFnxz9NPMxTHwM8zkksuvalb WXH1q+PQ0pNBdNZbyHx5ZrTgzaL8hNUKb4tHzL9u3fWc+1140ytKhGNUHbQ1tgtWA7NJ LZ/fkNHdEo5FgWxGUtHLzuPxBucIzuNOK2ZpwRWVHbf2Q4qfAKYiJx1HZJ7909QTmEqZ brBQ== X-Gm-Message-State: AO0yUKUEmFPHoasgrEf1HwPkPq1Uyx03OautrXrkxbiJ/NJSIuH/Qg3U OihExFQxioNcGuHz4oTcrJcobokDAnM= X-Google-Smtp-Source: AK7set9jen6DabioquL6A0I5bUsCa6oPxbNrQ/LgWJVxv72/sPWa0Af1nYSIYK6DfIT77HYwJNzN+Q== X-Received: by 2002:a05:6e02:2199:b0:315:6840:f727 with SMTP id j25-20020a056e02219900b003156840f727mr3642265ila.8.1679245089043; Sun, 19 Mar 2023 09:58:09 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id cd27-20020a0566381a1b00b003c4e3ecb02dsm2568671jab.24.2023.03.19.09.58.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Mar 2023 09:58:08 -0700 (PDT) Message-ID: Date: Sun, 19 Mar 2023 10:58:07 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] vect: Verify that GET_MODE_NUNITS is greater than one. Content-Language: en-US To: Michael Collison , gcc-patches@gcc.gnu.org References: <20230314215256.4153026-1-collison@rivosinc.com> From: Jeff Law In-Reply-To: <20230314215256.4153026-1-collison@rivosinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/14/23 15:52, Michael Collison wrote: > While working on autovectorizing for the RISCV port I encountered an issue > where can_duplicate_and_interleave_p assumes that GET_MODE_NUNITS is a > evenly divisible by two. The RISC-V target has vector modes (e.g. VNx1DImode), > where GET_MODE_NUNITS is equal to one. > > Tested on RISCV and x86_64-linux-gnu. Okay? > > 2023-03-09 Michael Collison > > * tree-vect-slp.cc (can_duplicate_and_interleave_p): > Check that GET_MODE_NUNITS is greater than one. As far as I know this doesn't fix a regression so I would defer to gc-14. As release managers, Richi, Jakub or Joseph can gate it in as an exception. jeff