From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) by sourceware.org (Postfix) with ESMTPS id D323A39490A1 for ; Tue, 24 Nov 2020 17:01:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D323A39490A1 Received: by mail-qk1-x742.google.com with SMTP id v143so21274027qkb.2 for ; Tue, 24 Nov 2020 09:01:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xFoYHnRCWa454eAKO+t5G177a3iIjYljsAheRs30K5w=; b=WcMFYfAw3/CjZnJ5GtoBwe6OmkqfXdXGXx8SbMzNW3VT6X2kGdIVAJq9rsMCk8tCSu Mg1JyNJ+BSB531naAvLGImvjXbFaxKdtq67JlDIwal9/QSKE/ynCzfvc1XYTSHInVKfB +8OQfPlr06mX6atVRmAcqHuYdV7FvJYZyCFjJBxK49UQjT0piS0Wcf3ILPTsAoB80YkL 7xrN9o+A7HMef3qCvWkUeq0P2R5ph84n8KAufivWANgPRtoMWxgp6GnwuDeGAoA7zs5J mBygLP1HcPjrBJsv1nS3U70F+sE9i8gxvas3gdXCNPbG5sEPZCuPmZ6a9Pq+r+uwBzEM oKtA== X-Gm-Message-State: AOAM530ns2kIRKJU7v8WWI25Onx4zSql9XoCx9nuPUsjcYeqRWsgn5l3 au6CXUSHnSd5imIiI9MxwKkIE+asoqU= X-Google-Smtp-Source: ABdhPJyxNkVWlu9qK59PK9tbQjS/7HF+lABAhNTFIgwmR5k7KkCc+C5ONCcH0dKWCH4SSyqVkS+JhA== X-Received: by 2002:ae9:f70e:: with SMTP id s14mr5594912qkg.340.1606237309243; Tue, 24 Nov 2020 09:01:49 -0800 (PST) Received: from [192.168.0.41] (75-166-106-198.hlrn.qwest.net. [75.166.106.198]) by smtp.gmail.com with ESMTPSA id k17sm12952734qkj.51.2020.11.24.09.01.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Nov 2020 09:01:48 -0800 (PST) Subject: Re: [PATCH] dump type attributes in dump_function_to_file From: Martin Sebor To: Jeff Law , gcc-patches References: <463079e0-b666-3f27-b5b5-6990f48b9e2f@redhat.com> <3ca43545-b69e-d81b-a1e5-34715944af66@redhat.com> <21463f91-6da3-cd77-e9e9-d998e4701a12@gmail.com> Message-ID: Date: Tue, 24 Nov 2020 10:01:44 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <21463f91-6da3-cd77-e9e9-d998e4701a12@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Nov 2020 17:01:51 -0000 On 11/24/20 8:53 AM, Martin Sebor wrote: > On 11/23/20 9:31 PM, Jeff Law wrote: >> >> >> On 11/20/20 4:14 PM, Jeff Law wrote: >>> >>> On 11/20/20 11:12 AM, Martin Sebor via Gcc-patches wrote: >>>> dump_function_to_file prints DECL_ATTRIBUTES but not TYPE_ATTRIBUTES >>>> when both can be important and helpful for debugging, especially with >>>> attributes that are added implicitly (such attribute access and >>>> the proposed internal attribute *dealloc).  The function also prints >>>> function arguments (and their types) but not its return type, again, >>>> leaving out a useful detail.  The attached tweak adds both to >>>> the dump. >>>> >>>> Martin >>>> >>>> gcc-dump-type-attr.diff >>>> >>>> gcc/ChangeLog: >>>> >>>>     * gcc/tree-cfg.c (dump_function_to_file): Print type attributes >>>>     and return type. >>>> >>>> gcc/testsuite/ChangeLog: >>>>     * gcc.dg/attr-access-4.c: New test. >> So was this actually regression tested?  Even tests that change dump >> files need to be regression tested because some of the tests scan those >> dump files. >> >> I'm seeing this on several targets: >> >> Tests that now fail, but worked before (6 tests): >> >> xstormy16-sim: gcc.dg/tree-ssa/pr23401.c scan-tree-dump-times gimple >> "int" 5 >> xstormy16-sim: gcc.dg/tree-ssa/pr23401.c scan-tree-dump-times gimple >> "int" 5 >> xstormy16-sim: gcc.dg/tree-ssa/pr27810.c scan-tree-dump-times gimple >> "int" 3 >> xstormy16-sim: gcc.dg/tree-ssa/pr27810.c scan-tree-dump-times gimple >> "int" 3 >> xstormy16-sim: gcc.dg/tree-ssa/slsr-8.c scan-tree-dump-times optimized >> " w?\\* " 9 >> xstormy16-sim: gcc.dg/tree-ssa/slsr-8.c scan-tree-dump-times optimized >> " w?\\* " 9 >> >> >> >>  From my quick reading, these tests are likely failing across the board. > > It was tested with the results below.  I looked onto the jit > failures (test-combination.c.exe etc.) but overlooked those > in the tree-ssa directory because of all the perpetual guality > clutter. I committed r11-5321 to fix up the gfortran.dg/gomp/declare-target-4.f90 regex pattern. Thank you for cleaning up the others. > > !  FAIL: gcc.dg/atomic/pr65345-4.c (4: +4)ESC[0m > !  FAIL: gcc.dg/guality/loop-1.c (1: +1)ESC[0m > !  FAIL: gcc.dg/guality/pr36728-2.c (28: +28)ESC[0m > !  FAIL: gcc.dg/guality/pr36728-4.c (4: +4)ESC[0m > !  FAIL: gcc.dg/guality/pr41616-1.c (3: +3)ESC[0m > !  FAIL: gcc.dg/guality/pr54519-1.c (8: +8)ESC[0m > !  FAIL: gcc.dg/guality/pr54519-2.c (2: +2)ESC[0m > !  FAIL: gcc.dg/guality/pr54519-3.c (8: +8)ESC[0m > !  FAIL: gcc.dg/guality/pr54519-4.c (2: +2)ESC[0m > !  FAIL: gcc.dg/guality/pr54519-5.c (2: +2)ESC[0m > !  FAIL: gcc.dg/guality/pr54519-6.c (1: +1)ESC[0m > !  FAIL: gcc.dg/guality/pr56154-1.c (1: +1)ESC[0m > !  FAIL: gcc.dg/guality/pr59776.c (6: +6)ESC[0m > !  FAIL: gcc.dg/guality/pr90074.c (2: +2)ESC[0m > !  FAIL: gcc.dg/guality/pr90716.c (1: +1)ESC[0m > !  FAIL: gcc.dg/guality/sra-1.c (16: +16)ESC[0m > !  FAIL: gcc.dg/guality/vla-1.c (8: +8)ESC[0m > !  FAIL: gcc.dg/tree-ssa/pr23401.c (1: +1)ESC[0m > !  FAIL: gcc.dg/tree-ssa/pr27810.c (1: +1)ESC[0m > !  FAIL: gcc.dg/tree-ssa/slsr-8.c (1: +1)ESC[0m > !  FAIL: gdc.dg/intrinsics.d (3: +3)ESC[0m > !  FAIL: g++.dg/guality/pr55665.C (1: +1)ESC[0m > !  FAIL: gfortran.dg/gomp/declare-target-4.f90 (8: +8)ESC[0m > !  FAIL: test-combination.c.exe (1: +1)ESC[0m > !  FAIL: test-functions.c.exe (1: +1)ESC[0m > !  FAIL: test-pr66779.c.exe (1: +1)ESC[0m > !  FAIL: test-threads.c.exe (1: +1)ESC[0m > ! XPASS: gcc.dg/analyzer/pr94851-1.c (1: +1)ESC[0m > ! XPASS: gcc.dg/guality/example.c (3: +3)ESC[0m > ! XPASS: gcc.dg/guality/guality.c (8: +8)ESC[0m > ! XPASS: gcc.dg/guality/inline-params.c (5: +5)ESC[0m > ! XPASS: gcc.dg/guality/pr41353-1.c (2: +2)ESC[0m > ! XPASS: gcc.dg/guality/pr54970.c (16: +16)ESC[0m > ! XPASS: gcc.dg/guality/pr59776.c (2: +2)ESC[0m > >> >> jeff >> >