From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by sourceware.org (Postfix) with ESMTPS id 463993858C39 for ; Tue, 28 Nov 2023 05:50:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 463993858C39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 463993858C39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::42b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701150649; cv=none; b=THP185Wr1k5VZ2wu1s8EuDyf0mEaRGIil8+xl9tzjg43Fk09FR1Nb9VPNR3RP1k0AeDQo/2ti6vLxK7VI7Hf5PF/9QVnwIWc8OkDoAOyYvNnWw+jEQbdGIKACpsgsFkKHOhhz+hv4MZVjHCFWWvXVk9mTjGrfCSkFb1yr/glpHw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701150649; c=relaxed/simple; bh=2v2kdQraW0LPioqCcqxXhC6UkaS8aPjFmll5DYggKiQ=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=suNKVQa0mmkA1zh8WSHZZfXXbYW6hSefAwPfv1rhYmAuFqXwn4RENIt6HpfOK9zbeLobahp6fgTl/ljh+7TNjfJNcs0Y3HG+s/i/n6iaI7ghh2pjRl740rNHu24HhgQqbslzx4rh7lF10L97OSalXlSvIW/nQFqVog+V3yRbqZA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-6cbe716b511so3722495b3a.3 for ; Mon, 27 Nov 2023 21:50:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701150647; x=1701755447; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=33i7OI7NyUoEPd3jAGlwzDP6dA9nwkL/JUYEspiog9A=; b=RkuRVO0M1cJaOoes25g6cK/ALcGKi0VPIKtpdKWyO8kVj3Fb0Hj+PESGMKH2uq5UXv xPWX2GUyVs3QpxFI4hpNaH6co0oyEa3U68BXcyTsGCfcdKgldFrvAIH5QcWJBhn6Opdx tumU9EXP3tvUp3hma+0oh1rSKNyeg0ziE4shrkpVZNcanQroYjjS1NeAsL3/1dmXd6W5 2GT8AkM0gJcsPy4E4WoNr00RAu81pZaKetOgyFFTEGSoF3zr0SfBT1PezLoza3ehT1s6 2eTxJeDZQGm7WMLqKqjVg5zE0WzjD3+aDFyc+cwCix4NM49e2ajAmAR2w86muRh8FqRW fVLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701150647; x=1701755447; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=33i7OI7NyUoEPd3jAGlwzDP6dA9nwkL/JUYEspiog9A=; b=I7x39HUCa/9Bjn9jhYzqr/JMOs6Qm6PDbWilrzY4QDCC+Jp/GivZVCgrsn9trcOdtA NYPmQ/Awukw6t6NdJYUyaYD3FS6wgO9P8nx88qlj5p5T5q2xEVU04X9YThsKwWm2LuRK yLWTFfzSKarShOoOKqdNIyp1LUL0KItNNwxnsys2irfpVDOs5zzygx4W1FY0YmhzcqVy QfYgrJjt2U2qCMO7nlHyjcEBcK40P/WSJigJIVXXPaJk54xbL2WZPCh+BUS75oe2Em3C Gyn749/u+EBM8kU9gMrqG/lvn7BpHZoTTPKuSBKYfOfm+Eo2E017VasiBCadha7bl4zd 4xUw== X-Gm-Message-State: AOJu0YzcwhVYjREEgGd3i+6wEft1XrXSHPAXWDSIDmkwfHO+61rmiPsn H09pK91/M2Y5XIcL8Wd0QUE= X-Google-Smtp-Source: AGHT+IHiQPhyPoXJsPBYRVaY1XjLiqnUzX6ooG2iMWU9f+BYtdfMatZN/53vD6kAUivMM+JCc5Zydw== X-Received: by 2002:a05:6a00:14c6:b0:691:2d4:2389 with SMTP id w6-20020a056a0014c600b0069102d42389mr16514978pfu.21.1701150647033; Mon, 27 Nov 2023 21:50:47 -0800 (PST) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id 18-20020aa79252000000b006cbb56d4e58sm8149155pfp.65.2023.11.27.21.50.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Nov 2023 21:50:46 -0800 (PST) Message-ID: Date: Mon, 27 Nov 2023 22:50:40 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFA] New pass for sign/zero extension elimination Content-Language: en-US To: Joern Rennecke , GCC Patches Cc: jlaw@ventanamicro.com, richard.sandiford@arm.com References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/27/23 10:36, Joern Rennecke wrote: > On 11/20/23 11:26, Richard Sandiford wrote: > >>> + >>> + mask = GET_MODE_MASK (GET_MODE (SUBREG_REG (x))) << bit; >>> + if (!mask) >>> + mask = -0x100000000ULL; >> >> Not sure I follow this. What does the -0x100000000ULL constant indicate? >> Also, isn't it the mask of the outer register that is shifted, rather >> than the mask of the inner mode? E.g. if we have: > Jeff Law: >> Inherited. I should have marked it like the other one as needing >> investigation. Probably the fastest way is to just rip it out for a >> test to see what breaks. > > This is for support of types wider than DImode. > > You unsupported tracking of these values in various places, though. Because we don't track liveness beyond DImode in this code at all and if you don't filter out the larger modes, things will go wonky in a bad way. It may be less of an issue after fixing the big endian correction code which was totally broken. Supporting TI, OI, etc would certainly be possible, but it didn't seem worth the effort on current architectures. Jeff