public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Earnshaw <Richard.Earnshaw@foss.arm.com>
To: Christophe Lyon <christophe.lyon@arm.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] arm: Define with_float to hard when target name ends with hf
Date: Wed, 17 Aug 2022 12:46:31 +0100	[thread overview]
Message-ID: <c5060c15-ff57-78fb-e256-6f587ae6fffe@foss.arm.com> (raw)
In-Reply-To: <20220817083512.53915-1-christophe.lyon@arm.com>



On 17/08/2022 09:35, Christophe Lyon via Gcc-patches wrote:
> On arm, the --with-float= configure option is used to define include
> files search path (among other things).  However, when targeting
> arm-linux-gnueabihf, one would expect to automatically default to the
> hard-float ABI, but this is not the case. As a consequence, GCC
> bootstrap fails on an arm-linux-gnueabihf target if --with-float=hard
> is not used.
> 
> This patch checks if the target name ends with 'hf' and defines
> with_float to hard if not already defined.  This is achieved in
> gcc/config.gcc, just before selecting the default CPU depending on the
> $with_float value.
> 
> 2022-08-17  Christophe Lyon  <christophe.lyon@arm.com>
> 
> 	gcc/
> 	* config.gcc (arm): Define with_float to hard if target name ends
> 	with 'hf'.
> ---
>   gcc/config.gcc | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/gcc/config.gcc b/gcc/config.gcc
> index 4e3b15bb5e9..02f58970db0 100644
> --- a/gcc/config.gcc
> +++ b/gcc/config.gcc
> @@ -1314,6 +1314,13 @@ arm*-*-linux-* | arm*-*-uclinuxfdpiceabi)
>   	    tm_file="$tm_file arm/uclinuxfdpiceabi.h"
>   	    ;;
>   	esac
> +	# Define with_float to "hard" if not already defined and
> +	# target name ends with "hf"
> +	case $target:$with_float in
> +	arm*-*-*hf:)
> +	    with_float=hard
> +	    ;;
> +	esac
>   	# Generation of floating-point instructions requires at least ARMv5te.
>   	if [ "$with_float" = "hard" -o "$with_float" = "softfp" ] ; then
>   	    target_cpu_cname="arm10e"

OK.

R.

      reply	other threads:[~2022-08-17 11:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-17  8:35 Christophe Lyon
2022-08-17 11:46 ` Richard Earnshaw [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c5060c15-ff57-78fb-e256-6f587ae6fffe@foss.arm.com \
    --to=richard.earnshaw@foss.arm.com \
    --cc=christophe.lyon@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).