From: Tobias Burnus <tobias@codesourcery.com>
To: Andre Vehreschild <vehre@gmx.de>
Cc: Jakub Jelinek <jakub@redhat.com>, Tobias Burnus <burnus@net-b.de>,
gcc-patches <gcc-patches@gcc.gnu.org>,
fortran <fortran@gcc.gnu.org>
Subject: Re: [Patch] Fortran: Add 'device_type' clause to OpenMP's declare target
Date: Wed, 26 Aug 2020 09:33:48 +0200 [thread overview]
Message-ID: <c50704f5-3e5f-2a50-39e8-fad8c90404a8@codesourcery.com> (raw)
In-Reply-To: <20200820181047.365be629@vepi2>
Thanks. I have now committed it as
r11-2858-gd58e7173ef964ddac3ab3ad8cc97de8f9f3b32ee
Tobias
On 8/20/20 6:10 PM, Andre Vehreschild wrote:
> Hi Tobias,
>
> to me this looks OK now.
>
> Regards,
> Andre
>
> On Thu, 20 Aug 2020 11:51:50 +0200
> Tobias Burnus <tobias@codesourcery.com> wrote:
>
>> Updated patch – taking Andre's suggestions into account +
>> extending the testcase, which now catches the previous (NO)HOST
>> module issue.
>>
>> OK?
>>
>> Tobias
>>
>> On 8/19/20 2:51 PM, Tobias Burnus wrote:
>>> Am 18.08.20 um 19:33 schrieb Andre Vehreschild:
>>>> + case OMP_DEVICE_TYPE_HOST:
>>>> + MIO_NAME (ab_attribute) (AB_OMP_DEVICE_TYPE_NOHOST, attr_bits);
>>>> Why also NOHOST here?
>>> Copy and paste error.
>> ...
>>>> + tree clauses = NULL_TREE;
>>>> Would you mind using "omp_clauses" or the like here?
>> Done now.
>> -----------------
>> Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany
>> Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung,
>> Alexander Walter
>
-----------------
Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany
Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander Walter
prev parent reply other threads:[~2020-08-26 7:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 15:03 Tobias Burnus
2020-08-18 7:11 ` *PING* / " Tobias Burnus
2020-08-18 17:33 ` Andre Vehreschild
2020-08-19 12:51 ` Tobias Burnus
2020-08-20 9:51 ` Tobias Burnus
2020-08-20 16:10 ` Andre Vehreschild
2020-08-26 7:33 ` Tobias Burnus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c50704f5-3e5f-2a50-39e8-fad8c90404a8@codesourcery.com \
--to=tobias@codesourcery.com \
--cc=burnus@net-b.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=vehre@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).