From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 2B2CD3857838; Wed, 26 Aug 2020 07:33:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2B2CD3857838 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Tobias_Burnus@mentor.com IronPort-SDR: cUwlIxnTh6n51Pz+AoedNdpp+hMERkpb2bcaWS7ARvYtiBr6CBjWRU1Cv5XXFkpNSdVIIKFdII ebY/Ls+bNaaRyZL/ZlJNpngaLje290CS3wHs5sItX1xCkbVjTc6ctZu/7wmn99rze0qShHIBF4 U5NEnubIE4VYLVExDIC9i0YoMn6tic7WiIORWHppPpqxFipqoyVufCvDyOOuXN9wWFjpk1v8FG Exg4Apq5dKgl0ThvtIGrqaEkOP900ku1et0CelSwFAkiuPxgCtCZeE2DMvxYeRsbatyaeIxUZn Axw= X-IronPort-AV: E=Sophos;i="5.76,354,1592899200"; d="scan'208";a="54452310" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa1.mentor.iphmx.com with ESMTP; 25 Aug 2020 23:33:45 -0800 IronPort-SDR: fQYT5UykOmmdLkUwqxu6s+qFooGWjqBtRFdarUEi4LCM4/YMjdtwjDMF8x5tPPZocDmH54PH4Z 6/DlN5yBhxs1hMet339XW+gP8Ue21tHPd87oHFKHS6GpgZygseDeM3+FS9bYdpo+0Wums8b+RD R+jppY7C/K1w+tQoGswmDUTTjsF6/T/sn4eUxi3gseN/juZbX0mM5UxceM3igcA5dhKPp+EIfx DoPky6v5frIBmqWyiT3UVkF5UwCZi2Ab26x5pMmV8yE9X9uQpeU9Pi6nf1bQ4aDcFm5NKabQR8 e4s= Subject: Re: [Patch] Fortran: Add 'device_type' clause to OpenMP's declare target To: Andre Vehreschild CC: Jakub Jelinek , Tobias Burnus , gcc-patches , fortran References: <20200818193349.09639c4a@vepi2> <78b99997-f3dd-1f73-625e-818868e53244@net-b.de> <82b801e4-e5dc-1ba7-6fb3-da680f345fd8@codesourcery.com> <20200820181047.365be629@vepi2> From: Tobias Burnus Message-ID: Date: Wed, 26 Aug 2020 09:33:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200820181047.365be629@vepi2> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-8.5 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Aug 2020 07:33:48 -0000 Thanks. I have now committed it as r11-2858-gd58e7173ef964ddac3ab3ad8cc97de8f9f3b32ee Tobias On 8/20/20 6:10 PM, Andre Vehreschild wrote: > Hi Tobias, > > to me this looks OK now. > > Regards, > Andre > > On Thu, 20 Aug 2020 11:51:50 +0200 > Tobias Burnus wrote: > >> Updated patch =E2=80=93 taking Andre's suggestions into account + >> extending the testcase, which now catches the previous (NO)HOST >> module issue. >> >> OK? >> >> Tobias >> >> On 8/19/20 2:51 PM, Tobias Burnus wrote: >>> Am 18.08.20 um 19:33 schrieb Andre Vehreschild: >>>> + case OMP_DEVICE_TYPE_HOST: >>>> + MIO_NAME (ab_attribute) (AB_OMP_DEVICE_TYPE_NOHOST, attr_bits); >>>> Why also NOHOST here? >>> Copy and paste error. >> ... >>>> + tree clauses =3D NULL_TREE; >>>> Would you mind using "omp_clauses" or the like here? >> Done now. >> ----------------- >> Mentor Graphics (Deutschland) GmbH, Arnulfstra=C3=9Fe 201, 80634 M=C3=BC= nchen / Germany >> Registergericht M=C3=BCnchen HRB 106955, Gesch=C3=A4ftsf=C3=BChrer: Thom= as Heurung, >> Alexander Walter > ----------------- Mentor Graphics (Deutschland) GmbH, Arnulfstra=C3=9Fe 201, 80634 M=C3=BCnch= en / Germany Registergericht M=C3=BCnchen HRB 106955, Gesch=C3=A4ftsf=C3=BChrer: Thomas = Heurung, Alexander Walter