From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by sourceware.org (Postfix) with ESMTPS id 8500B3857036 for ; Tue, 18 Apr 2023 19:25:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8500B3857036 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-63b7b54642cso1425861b3a.0 for ; Tue, 18 Apr 2023 12:25:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681845926; x=1684437926; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JlEF7QI5yZ3KNonRn20aFLC2H+PRqDfALmFNhoEhbQU=; b=UjgxtJAq0+k1mqvU6i6FH9zytskcap5/Mnn8uKceCAjgXdpM3ZYD0yoEcFlfH8uzvL v0u+CsZPuhayjp9QkiodzovzIWhF/1CGhm87tmYhRQEiHlT6Naql6xfCgOIewd6/kYNX mVTRRL+QeGsfyuqdm0Ev6rJoVzmY3Pjz4PRDAzEdJRX75OXn43YEtm4kzEiI0sfkYgKu yRVF9tdJZrzt9ehAfSY+lwGn2wu3/sYVpipRu5NnacOXuimxKsCqysOXFcxEvuaV25cj tGWRozgVWF2Lvt06gqOcRH6l6cK+6H/QQAae3a9982kCCso2mJgwDc6ILxteFHAcp0qN bT2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681845926; x=1684437926; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JlEF7QI5yZ3KNonRn20aFLC2H+PRqDfALmFNhoEhbQU=; b=fApq7cg385H/BPy+8p1XK9wl2vr6scJwb2IJ9KUVVQC+lTEV4yb1jKW8Z+0RKkv2C1 5sqpGd9pT2ivlSLEfhgSQwD6Xy7Dy/2m1TdcEJfVccdXvFhPC0M23sN94JaLNU4PDI6W j0vQtfbQC7dhRHIkDkZ3Nu4sgq0NepQSsBxjPKatbGJ0hGPWDJilhQoS2gHHR1u/FvCf bmBSb3Dvp7bKeaML8bgLRlCcc1fz/wkHA+LrF7f78QOperUa3htosxDXi1T/P2feVUCE iW+13VtW5MF+r4Y3o9wBQSTrizhuO8YW0TMYQ7jsfcGoo0PwGm1VsYn9Ay6wXeLYTYPI jayw== X-Gm-Message-State: AAQBX9f+k2NZ9lr58ylaUDkjIbdVaZrPrSrvZBi/fGp5EliZQJTmy9SB oyYtBv7ScSMIwsfktQIof6Q= X-Google-Smtp-Source: AKy350YjMyYHwXU93N9cyiCf0lqq1aMBhiKxHaMXqjdu2wtMqwxIABvmPliaa+/cNUOQWovvbfT1eQ== X-Received: by 2002:a05:6a00:cd6:b0:628:f0:51d4 with SMTP id b22-20020a056a000cd600b0062800f051d4mr916222pfv.11.1681845926482; Tue, 18 Apr 2023 12:25:26 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id g14-20020aa7818e000000b005d61829db4fsm9627957pfi.168.2023.04.18.12.25.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Apr 2023 12:25:26 -0700 (PDT) Message-ID: Date: Tue, 18 Apr 2023 13:25:24 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] PHIOPT: Move tree_ssa_cs_elim into pass_cselim::execute. Content-Language: en-US To: Andrew Pinski , gcc-patches@gcc.gnu.org References: <20230418192136.286589-1-apinski@marvell.com> From: Jeff Law In-Reply-To: <20230418192136.286589-1-apinski@marvell.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/18/23 13:21, Andrew Pinski via Gcc-patches wrote: > This moves around the code for tree_ssa_cs_elim slightly > improving code readability and removing declarations that > are no longer needed. > > OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions. > > gcc/ChangeLog: > > * tree-ssa-phiopt.cc (tree_ssa_phiopt_worker): Remove declaration. > (make_pass_phiopt): Make execute out of line. > (tree_ssa_cs_elim): Move code into ... > (pass_cselim::execute): here. OK jeff