Re: [Patch, fortran] PR112407 - [13/14 Regression] Fix for PR37336 triggers an ICE in gfc_format_decoder while constructing a vtab

[Harald Anlauf <anlauf@gmx.de>]

Hi Paul,

I had only a quick glance at your patch.  I guess you unintentionally
forgot to remove those parts that you already committed for PR110987,
along with the finalize-testcases.

I am still trying to find the precise paragraph in the standard
you refer to regarding INTENT(OUT) and default initialization.

While at it, I think I found a minor nit in testcase pr112407a.f90:
component x%i appears undefined the first time it is printed.
This can be verified by either adding an explicit

   x% i = -42

in the main after the allocate(x).  Alternatively, running the
code with Intel and using MALLOC_PERTURB_ shows a random arg1%i,
but is otherwise fine.  However, if by chance (random memory)

   x% i = +42

then the test would likely fail everywhere.

Cheers,
Harald


Am 30.03.24 um 10:06 schrieb Paul Richard Thomas:
> Hi All,
>
> This bug emerged in a large code and involves possible recursion with a
> "hidden" module procedure; ie. where the symtree name starts with '@'. This
> throws the format decoder. As the last message in the PR shows, I have
> vacillated between silently passing on the possible recursion or adding an
> alternative warning message. In the end, as a conservative choice I went
> for emitting the message.
>
> In the course of trying to develop a compact test case, I found that type
> bound procedures were not being tested for recursion and that class
> dummies, with intent out, were being incorrectly initialized with an empty
> default initializer. Both of these have been fixed.
>
> Unfortunately, the most compact reproducer that Tomas was able to come up
> with required more than 100kbytes of module files. I tried from the bottom
> up but failed. Both the tests check the fixes for the other bugs.
>
> Regtests on x86_64 - OK for mainline and, in a couple of weeks, 13-branch?
>
> Paul
>
> Fortran: Fix wrong recursive errors and class initialization [PR112407]
>
> 2024-03-30  Paul Thomas  <pault@gcc.gnu.org>
>
> gcc/fortran
> PR fortran/112407
> *resolve.cc (resolve_procedure_expression): Change the test for
> for recursion in the case of hidden procedures from modules.
> (resolve_typebound_static): Add warning for possible recursive
> calls to typebound procedures.
> * trans-expr.cc (gfc_trans_class_init_assign): Do not apply
> default initializer to class dummy where component initializers
> are all null.
>
> gcc/testsuite/
> PR fortran/112407
> * gfortran.dg/pr112407a.f90: New test.
> * gfortran.dg/pr112407b.f90: New test.
>