From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 2E51C3858D28; Fri, 7 Apr 2023 09:49:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2E51C3858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33766QZ0032550; Fri, 7 Apr 2023 09:49:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=t03icKYMcO/l+xLVpzWZq2WB8hMv22ad/pjdlyY1Xls=; b=Xrg/KFEjcuxLQo9qUZgWmGFtloI0DAmQ88BwkfJ+x9bTKqhbI/FzFLF6pr5YUHgJ/8iC gyJYTSX5MwvjBFkmSdYtTFKG4ewqbucrAurYQN5EJWFaKcCoki7IBDEbZNXyLkopQq5y 1kg1itvIJdI64GaNgVDEiCvPZA3pVN7mFmOE7sz7AzPPlFWgxBXxbhyyax1zKfFnmUCW nnUBsvtayzT+rph3bdkS8SVRoZ27KhcXoRQvUd6pQZ7Q1wu3n6GnEtp7OmYMrKHKwhv9 Zy2nijTi6/7hBxvRArJOflbGBOWKd8yX0YC+PoK/PYJsEJZQO94VDmWRoe10iJPRB72g Dw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3pt6fh3rk8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 07 Apr 2023 09:49:16 +0000 Received: from m0098404.ppops.net (m0098404.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3379iwwU020388; Fri, 7 Apr 2023 09:49:15 GMT Received: from ppma02fra.de.ibm.com (47.49.7a9f.ip4.static.sl-reverse.com [159.122.73.71]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3pt6fh3rjp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 07 Apr 2023 09:49:15 +0000 Received: from pps.filterd (ppma02fra.de.ibm.com [127.0.0.1]) by ppma02fra.de.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3378TOGn012005; Fri, 7 Apr 2023 09:49:13 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma02fra.de.ibm.com (PPS) with ESMTPS id 3ppc86upey-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 07 Apr 2023 09:49:13 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3379nAIM12649092 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 7 Apr 2023 09:49:10 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A119520043; Fri, 7 Apr 2023 09:49:10 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B775320040; Fri, 7 Apr 2023 09:49:07 +0000 (GMT) Received: from [9.177.92.176] (unknown [9.177.92.176]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTP; Fri, 7 Apr 2023 09:49:07 +0000 (GMT) Message-ID: Date: Fri, 7 Apr 2023 17:49:05 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] [PR99708] [rs6000] don't expect __ibm128 with 64-bit long double Content-Language: en-US To: Alexandre Oliva Cc: Rainer Orth , Mike Stump , David Edelsohn , Segher Boessenkool , Kewen Lin , gcc-patches@gcc.gnu.org References: <8e75ef66-c654-155e-ccf6-ac95cc38c740@linux.ibm.com> <9eb5b41f-8ab1-ef2e-0429-8ce335e18304@linux.ibm.com> From: "Kewen.Lin" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: -kLIXgKIkOQdI4CgwYbWR71yqvOmqs8Q X-Proofpoint-GUID: d5-tRCOu0uoEt134XQavAfanBN6P8PNi X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-07_06,2023-04-06_03,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1015 priorityscore=1501 spamscore=0 lowpriorityscore=0 adultscore=0 mlxlogscore=999 phishscore=0 bulkscore=0 impostorscore=0 malwarescore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304070088 X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Alexandre, on 2023/4/7 09:48, Alexandre Oliva wrote: > On Apr 6, 2023, "Kewen.Lin" wrote: > >> The reason why personally I preferred to fix it with xfail is that: > > Got it. I'm convinced, and I agree. > > I tried an xfail in the initial dg-do, but that is no good for a compile > error, so I went for a dg-bogus xfail. I hope that will still have the > intended effect when __ibm128 is defined when it currently isn't. > Thanks for looking into it. > There is a dg-skip-if in this test on the trunk, covering some targets, > that IIRC are longdouble64, so maybe that's related and I could have > dropped them, but I wasn't sure, so I left them alone. I think it's due to that -mfloat128 isn't fully supported on them, so yeah, just leave them alone. > > Regstrapped on ppc64-linux-gnu (pass), also tested on ppc64-vx7r2/gcc-12 > (xfail). Ok to install? > > > [PR99708] [rs6000] don't expect __ibm128 with 64-bit long double > > When long double is 64-bit wide, as on vxworks, the rs6000 backend > defines neither the __ibm128 type nor the __SIZEOF_IBM128__ macro, but > pr99708.c expected both to be always defined. Adjust the test to > match the implementation. > > > for gcc/testsuite/ChangeLog > > * gcc.target/powerpc/pr99708.c: Accept lack of > __SIZEOF_IBM128__ when long double is 64-bit wide. > --- > gcc/testsuite/gcc.target/powerpc/pr99708.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/testsuite/gcc.target/powerpc/pr99708.c b/gcc/testsuite/gcc.target/powerpc/pr99708.c > index 02b40ebc40d3d..66a5f88479330 100644 > --- a/gcc/testsuite/gcc.target/powerpc/pr99708.c > +++ b/gcc/testsuite/gcc.target/powerpc/pr99708.c > @@ -14,7 +14,7 @@ > int main (void) > { > if (__SIZEOF_FLOAT128__ != sizeof (__float128) > - || __SIZEOF_IBM128__ != sizeof (__ibm128)) > + || __SIZEOF_IBM128__ != sizeof (__ibm128)) /* { dg-bogus "undeclared" "" { xfail longdouble64 } } */ > abort (); > This new version causes unresolved record on my side, it's due to the compilation failed to produce executable. === gcc Summary for unix/-m64 === # of expected passes 1 # of expected failures 1 # of unresolved testcases 1 So I think we need to make the file be compiled well, how about something like: ------ diff --git a/gcc/testsuite/gcc.target/powerpc/pr99708.c b/gcc/testsuite/gcc.target/powerpc/pr99708.c index 02b40ebc40d..c6aa0511b89 100644 --- a/gcc/testsuite/gcc.target/powerpc/pr99708.c +++ b/gcc/testsuite/gcc.target/powerpc/pr99708.c @@ -14,9 +14,17 @@ int main (void) { if (__SIZEOF_FLOAT128__ != sizeof (__float128) - || __SIZEOF_IBM128__ != sizeof (__ibm128)) + /* FIXME: Once type __ibm128 gets supported with long-double-64, + we shouldn't need this conditional #ifdef and xfail. */ +#ifdef __SIZEOF_IBM128__ + || __SIZEOF_IBM128__ != sizeof (__ibm128) +#else + || 1 +#endif + ) abort (); return 0; } +/* { dg-xfail-run-if "unsupported type __ibm128 with long-double-64" { longdouble64 } } */ ------ ? OK if it looks reasonable to you and the testing goes well. Thanks! BR, Kewen