From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id B9F563858D20 for ; Tue, 14 Nov 2023 17:23:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B9F563858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=foss.arm.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=foss.arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B9F563858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699982621; cv=none; b=PXxkonAl1xO7SvMEdhqCJbC/zdJGpQbk51r/EXaPelsSXtd0u0TpsZNAhp0T/Pn2/OmjPuXQMjKUjhOnTMJHDGoBP285hfjo5/aJRf38a/uUKWpEPCZufDbccy/KO8U2psUzdpxlWZKIhkP+b9GUVEetpEvWZ3MFvhHB0m0ehgU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699982621; c=relaxed/simple; bh=De8nRo7xD0AlXo4CIQqy0kew+2OKbvM9drVgnmRQ9z8=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=vT2tteUgH39kZZw7v+ZPS7EqmoQXdCmsZVpwY1v7BKZrLeYZ+kJl4XmNNCziOrZxTkipseiGS4BcR+tSMNfoVIugu651EMTttCI/zpYammU8itB6zK1H7PsIZzn7pLP2gGzEpwBsRxNCR3/RVj8B/0L1d0gMMzjAuTeKXxbQ+cA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A2DBEC15; Tue, 14 Nov 2023 09:24:25 -0800 (PST) Received: from [10.57.41.187] (unknown [10.57.41.187]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D1FFA3F641; Tue, 14 Nov 2023 09:23:39 -0800 (PST) Message-ID: Date: Tue, 14 Nov 2023 17:23:38 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [committed 01/22] arm: testsuite: correctly detect armv6t2 hardware for acle execution tests Content-Language: en-GB To: Christophe Lyon , Richard Earnshaw , gcc-patches@gcc.gnu.org References: <20231113142658.69039-1-rearnsha@arm.com> <20231113142658.69039-2-rearnsha@arm.com> From: Richard Earnshaw In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3493.8 required=5.0 tests=BAYES_00,BODY_8BITS,GIT_PATCH_0,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 14/11/2023 17:01, Christophe Lyon wrote: > Hi, > > On 11/13/23 15:26, Richard Earnshaw wrote: >> diff --git a/gcc/testsuite/lib/target-supports.exp >> b/gcc/testsuite/lib/target-supports.exp >> index 1a7bea96c1e..d414cddf4dc 100644 >> --- a/gcc/testsuite/lib/target-supports.exp >> +++ b/gcc/testsuite/lib/target-supports.exp >> @@ -5590,6 +5590,24 @@ proc check_effective_target_arm_thumb1_cbz_ok {} { >>       } >>   } >> +# Return 1 if this is an Arm target which supports the Armv6t2 >> extensions. >> +# This can be either in Arm state or in Thumb state. >> + >> +proc check_effective_target_arm_arch_v6t2_hw_ok {} { >> +    if [check_effective_target_arm_thumb1_ok] { > > Why arm_thumb1_ok and not arm_arch_v6t2_ok ? Because I cloned the function immediately above, then only half fixed it. That's not the only bug though. It never tries to run the test (object only runs the compiler with '-c', so it stops after assembly), which it should if it's checking if the HW can run a test. Ooops! I'll fix that. Thanks for catching. R. > > Thanks, > > Christophe > > >> +    return [check_no_compiler_messages arm_movt object { >> +        int >> +        main (void) >> +        { >> +          asm ("bfc r0, #1, #2"); >> +          return 0; >> +        } >> +    } [add_options_for_arm_arch_v6t2 ""]] >> +    } else { >> +    return 0 >> +    } >> +} >> + >>   # Return 1 if this is an ARM target where ARMv8-M Security >> Extensions is >>   # available.