From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22e.google.com (mail-oi1-x22e.google.com [IPv6:2607:f8b0:4864:20::22e]) by sourceware.org (Postfix) with ESMTPS id EF8B53858403 for ; Fri, 22 Mar 2024 13:36:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EF8B53858403 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EF8B53858403 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::22e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711114577; cv=none; b=HB6Jn8hakwixQa6pOFzG6mnZMjUWCzkFHEw9POQ0e5qClzrQ5+CxuXM2iFDb060/7vPZMumbCv7aLO14XZRPeEqXqBARr3/pb8sCCmfdkb2FkIuqQWerHRYqajqEAkgpxRMh9uzQJNJ1B8aAu08K+E31hqPcwYI2FCYW9UxmGQo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711114577; c=relaxed/simple; bh=uRFDNEvyGq5h1z5GoWSJk2Mi1/nplz3+oWQztYyqXCE=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=nvvewC9959NWERtSsx9SAKTvr4wOI8r2czO/Qqj+wuEeKTMuBWN1Hyr3WtVije3gtlfmSoeG3lW630/1ZfW0SlWhs1rRQMM1Lc0Qs/eskRTn1vAznNkpWergHpBzOqOrzVJmKcZPssGjT0uFskvzfIf5D8kmqSzVyYmiakFeZso= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oi1-x22e.google.com with SMTP id 5614622812f47-3c3bc867eaaso209122b6e.1 for ; Fri, 22 Mar 2024 06:36:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711114566; x=1711719366; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gxmOtfRhkgeZF+d9cXx9a22imlD1X69UvbBHzHGCEas=; b=hq/NHkQ5SWNmBzrdyB0I02cazwY4vkPUlqVL1hC1FnpA/rNbL7IITNhhpkCEvcl3D2 NqSD420ktXR/Q9k5fouxMx6+60xjJxpmZv/dU0unig3MTuw9DCA4KOBAq6V+lzGHmmGu MMFfxfaLd42e846h/heiBA7WLP9wT7T1XzojfdkuIDuuOMeOsrauHzMn4g54ucj5eCD7 QjF5v8yh0tkFmsZF2bQo1rJacb7Hgdv/gREpmnvK8Z+ICr7T2OCKn+4sguJVxUXjwl6L CriLWG658msqWpTi02DcTeEmltTLCMIiowGjyWwJcBrW9ibK9GdVaSDUjsPk3zxbxLTD MjgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711114566; x=1711719366; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gxmOtfRhkgeZF+d9cXx9a22imlD1X69UvbBHzHGCEas=; b=MWrBixqwcj/CWbR6eccGMCfH7kZGgN2rXGmCj4hkUadqqtYqNxuuQSKILlG6+xnByr +1YryL/BSdGlWwtju2RR/NtzCBs5n4CwoUXJPfYbxG1GwmLgdaTUPB+gv2UV3AtMRS8R bEvnAkMPu4fI/T7oIgl0CQPkoz09Pv3RYLeuO+AzBKfm/NaX1x0JRKBFxFnChOngxPtw /wZy8kCK1fD4htyN7oHwijATU7KpO/awcR7DIiIZ2ATtfzs02oLxTJhKzZyq4xZltETp fj+q7jqeEF8MxALSG3Ixo59delFe4AwgDsfIw0ZguG7UKhXBbhzOhVkRXfDCfplrGdih bWnw== X-Forwarded-Encrypted: i=1; AJvYcCWXR+DueUh3tlxx4F+q84a53WaZIpUX98qao35DuVWrkRChauWxcdgj0+E0KefkfjYt1Ui5bURA0TBwFaCRi2KK+qNaMK/YMA== X-Gm-Message-State: AOJu0YzmojI3dWKGHm02jLM2ecoqp7NBQPmPLafp8YzhobAm5RW3bWUD Sp1eIuLHmYvnH9suYQprr0uQ8bKTNdTAxTPUGyVusOxSHMr3qZoZ X-Google-Smtp-Source: AGHT+IGlp68HpVFa/Edsst4EkePL1O2kdjzk2kkPHMaOF1cwJnLGfixq8rzglFjYW9fLk44hxFUQjA== X-Received: by 2002:a05:6808:11ca:b0:3c3:9d49:1de1 with SMTP id p10-20020a05680811ca00b003c39d491de1mr2157527oiv.57.1711114564789; Fri, 22 Mar 2024 06:36:04 -0700 (PDT) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id j19-20020a544813000000b003c385d0ce00sm278864oij.3.2024.03.22.06.36.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Mar 2024 06:36:04 -0700 (PDT) Message-ID: Date: Fri, 22 Mar 2024 07:36:04 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH] handle unwind tables that are embedded within unwinding code, [PR111731] Content-Language: en-US To: Thomas Neumann , "gcc-patches@gcc.gnu.org" Cc: Jakub Jelinek References: <2a4776b9-9271-bb3c-a626-d5ec22dae6f3@in.tum.de> <91045a34-a534-4436-bb06-cac32d797a36@in.tum.de> <87sfibqu1s.fsf@oldenburg.str.redhat.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/15/24 4:29 AM, Thomas Neumann wrote: > Original bug report: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111731 > Given that this is a regression, is this okay for gcc 13 and mainline? > > The unwinding mechanism registers both the code range and the unwind > table itself within a b-tree lookup structure. That data structure > assumes that is consists of non-overlappping intervals. This > becomes a problem if the unwinding table is embedded within the > code itself, as now the intervals do overlap. > > To fix this problem we now keep the unwind tables in a separate > b-tree, which prevents the overlap. > > libgcc/ChangeLog: >     PR libgcc/111731 >     * unwind-dw2-fde.c: Split unwind ranges if they contain the >     unwind table. And what I'd suggest is committing to the trunk now, then waiting a week or two before backporting to gcc-13. jeff