From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by sourceware.org (Postfix) with ESMTPS id DB9A33959C3B for ; Thu, 29 Apr 2021 12:44:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DB9A33959C3B Received: by mail-pl1-x62c.google.com with SMTP id t21so3578379plo.2 for ; Thu, 29 Apr 2021 05:44:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=9mmMUDrP5ap/qgmuRq9MRIjHRr4cnd/RlxlaelyLEZo=; b=kuwA9NwlE3VuS3ZryNj3G+B22eQLtpp5PQ52J+c9UgS1qIpEt2N1xW1M8bjfOfIk4t w3Ned+90w8D0bCwOKqdU8mXAPDWAz2zkAVR2Ya3CuQf9E8qIx8jAX7lhUBGg1KKidnFB 5ywLQLi8aaMLd5n+CUrL991rerCjNUjWNXRLa8iIE7qE2Mv2aXBXBGFuCOSodZzlK6A2 VbTexISI/m1wY8XHcojFs2kQNsd/TZuXJ8AFeFS3+EORNglpc3nIH8Gy0eT1cR4ZV3sD xUzTstfhDIfEW/P9Bd0piGcKa4QpUDmJjmfRhx6vG9+rGp/RblpLlyIxKDe1P+a8IMuZ tpdA== X-Gm-Message-State: AOAM533YUmQU4f2YBbClJUeYSo7656PhH3IN9qwqKU0fNRygu5mhjn/X t27XC0ZtyGJGRAR65jnxKCPtrwMw6IL6kA== X-Google-Smtp-Source: ABdhPJw7M7SOChA3tEVRifKLxoRu9Y+OfFq4+K8sSDNAyeL21g62T+po2Z45OSMjCPr1sRvJ92Zahg== X-Received: by 2002:a17:902:6949:b029:e8:c22d:17ae with SMTP id k9-20020a1709026949b02900e8c22d17aemr34625684plt.57.1619700288728; Thu, 29 Apr 2021 05:44:48 -0700 (PDT) Received: from [192.168.1.2] (c-98-202-48-222.hsd1.ut.comcast.net. [98.202.48.222]) by smtp.gmail.com with ESMTPSA id a18sm2639718pgk.66.2021.04.29.05.44.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Apr 2021 05:44:48 -0700 (PDT) Subject: Re: [PATCH v2 10/21] libcc1: use unique_ptr more To: Tom Tromey , gcc-patches@gcc.gnu.org References: <20210428010119.806184-1-tom@tromey.com> <20210428010119.806184-11-tom@tromey.com> From: Jeff Law Message-ID: Date: Thu, 29 Apr 2021 06:44:47 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <20210428010119.806184-11-tom@tromey.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Apr 2021 12:44:51 -0000 On 4/27/2021 7:01 PM, Tom Tromey wrote: > This changes libcc1 to use unique_ptr in a few more places, removing > some manual memory management. > > libcc1/ChangeLog > 2021-04-27 Tom Tromey > > * libcp1.cc (struct libcp1) : Use > unique_ptr. > (~libcp1): Remove. > (libcp1_compile, libcp1_set_triplet_regexp) > (libcp1_set_driver_filename): Update. > * libcc1.cc (struct libcc1) : Use > unique_ptr. > (~libcc1): Remove. > (libcc1_set_triplet_regexp, libcc1_set_driver_filename) > (libcc1_compile): Update. OK Jeff