From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28679 invoked by alias); 13 Oct 2016 10:21:58 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 28632 invoked by uid 89); 13 Oct 2016 10:21:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Oct 2016 10:21:57 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1622E4ACB7 for ; Thu, 13 Oct 2016 10:21:56 +0000 (UTC) Received: from localhost.localdomain (vpn1-7-104.ams2.redhat.com [10.36.7.104]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9DALsCg015761; Thu, 13 Oct 2016 06:21:55 -0400 Subject: Re: [PATCH] (v2) Add a "compact" mode to print_rtx_function To: David Malcolm , gcc-patches@gcc.gnu.org References: <43d4ec20-5f84-2533-22e4-e16c779f6162@redhat.com> <1476304646-39819-1-git-send-email-dmalcolm@redhat.com> From: Bernd Schmidt Message-ID: Date: Thu, 13 Oct 2016 10:21:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1476304646-39819-1-git-send-email-dmalcolm@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-10/txt/msg01004.txt.bz2 On 10/12/2016 10:37 PM, David Malcolm wrote: > It didn't pass, due to this change: > > (print_rtx_operand_code_i): When printing source locations, wrap > xloc.file in quotes. [...snip...] [...] > The following is a revised version of the patch which updates this test case. Also ok. This reminds me, wrapping the filename in quotes was a side issue - what I was really hoping for was to have testcases without this visual clutter unless they wanted to explicitly test functionality related to it. Bernd