From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from silver.cherry.relay.mailchannels.net (silver.cherry.relay.mailchannels.net [23.83.223.166]) by sourceware.org (Postfix) with ESMTPS id D1D063858C35 for ; Tue, 31 Oct 2023 16:30:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D1D063858C35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=eagercon.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=eagercon.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D1D063858C35 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=23.83.223.166 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1698769802; cv=pass; b=xDyVCs6HjgJxokBGtJZthHNE8fsFgfO6YwL6Z7HyuDeqs/zs3Z/TkL0BWBxLj9mQ1YftdRcqt1eZ5vzmVSTB14put/S/eMkG5nJrAJE54tzYSEI85aWV9tONzK2DQQuQqF9W/MSPzSxB/HjrW4lykLOipPeiXQaj7n6fTvTPfBQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1698769802; c=relaxed/simple; bh=/TDSMXh31bYGEkYsByijbFoxc0DMGBiDpqfwE92DncY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=reMRQblUCphmZD2l7DK7+/q4BrTcBRmM6Q9PLE+DeG5HU4VEML8qIkye4jyagzsCQW4Ojs43+51JvUM+uRV2AVhkosnqEJ3kYWRYowcwOVixMeb2x9a3SqV3G8JzGoCSWnTLhl5SsFl+nJ3Whw8d/k+4nxeL2GNLTYbsf6H9TFc= ARC-Authentication-Results: i=2; server2.sourceware.org X-Sender-Id: dreamhost|x-authsender|eager@eagerm.com Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id BA27D360C32; Tue, 31 Oct 2023 16:29:58 +0000 (UTC) Received: from pdx1-sub0-mail-a310.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 46F05361F56; Tue, 31 Oct 2023 16:29:58 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1698769798; a=rsa-sha256; cv=none; b=e726p2J7v12R2ME+Vir6WtRsxo9qCMOcybMYD3TInaLUwATxNkGKLTn683ldfBDtVbuIq0 KKY7gJVHyhK9OSZQCwgMb+zyojUgH0PGKJ2/ZhLbV0ja2e+7r/YDzSOGUmqCAQZI0+Psq8 XFiAnqJ/YHA7OvLmH4PsUW8xmUj8Wu6KlQXjTQMlrOEmmfywsB5zRKf0GBYQgrwRUHIt6i DU13criVY7pVwKnoZ7jocVgthVsr7lTu7zrgIWXmLyEjqmhhFqSk8/f8vaHm7XMtvsvtOf QLlbz8xu7JPDjTn1I2PL8Tor8faefOJONmN86770mL53eaMOqjE6WorulKpcVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1698769798; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=A1dtXjkscJOcA70VMgbFppRsu5bfhlBW0jhLSK0ZIDA=; b=3JqGN6C0nbZseF/LK9fr9GXaVzoGs+zMtewAIxxnu9CAWd/RwUlQKf/3K6mgNdPgHA859Q KtVVyKNZsg58APkzuxW3478MrOJpN2WYgWzUlDyko/2AaBzD7Nzld8cJrSYuek+s97utsv tkr63Qgm31wrwjvzPavhrJVmE1UQAk8xOvsCw0jtkuoSSwjUpi3qYZWMfC2EpqqBW0we+q P5/sCqnbSoutKpqcu2wl5DLk7q9AacVlicdGXGImrII01YF4rgu2YnYHMmbIUrMocvoM4J kaE8XWSBaljz6c4LhxS9hw9t9xO1MNC3M++uJb6+8Y4dXkhP9Hh/RmfTnxrG1g== ARC-Authentication-Results: i=1; rspamd-86646d89b6-wmnm7; auth=pass smtp.auth=dreamhost smtp.mailfrom=eager@eagercon.com X-Sender-Id: dreamhost|x-authsender|eager@eagerm.com X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|eager@eagerm.com X-MailChannels-Auth-Id: dreamhost X-Fumbling-Illegal: 0870699839b5324e_1698769798608_2895183722 X-MC-Loop-Signature: 1698769798608:990033584 X-MC-Ingress-Time: 1698769798608 Received: from pdx1-sub0-mail-a310.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.115.216.135 (trex/6.9.2); Tue, 31 Oct 2023 16:29:58 +0000 Received: from [192.168.20.10] (c-73-170-238-207.hsd1.ca.comcast.net [73.170.238.207]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: eager@eagerm.com) by pdx1-sub0-mail-a310.dreamhost.com (Postfix) with ESMTPSA id 4SKbFx5Bpjz3p; Tue, 31 Oct 2023 09:29:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eagercon.com; s=dreamhost; t=1698769798; bh=A1dtXjkscJOcA70VMgbFppRsu5bfhlBW0jhLSK0ZIDA=; h=Date:Subject:To:Cc:From:Content-Type:Content-Transfer-Encoding; b=CPIyORA6QOJY0kh/O7b97Zhk9O7L80qwAUNY9pb5m8aE2Uogn/EzjBlmFvbKqJ7kS NE6E0iiJ8aUl5nmnOoZ3Cq6b1/pvtxcQpVocSJQen35JIkRarBajLyu8GWSMMXwPsx n4HIrzYvm7+cr0U8/NkpPE+xuaG6aUTC5ctF24C6hWo72ajEMdBOTEAEFvfU2b5X2F qxjdnq3lgED5vVYHfxpmU4reP0HEr3RfU7wRHGPbE9dlygom54wPClQTQiTaOUJLS8 n6xXk1ame62VKD5HRyKKTznenjE3g+4/01xKzt+Vy/3qAedmiu9gQ9obxp5dIORX8V e5oBl4ioGT61Q== Message-ID: Date: Tue, 31 Oct 2023 09:29:56 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 1/1] gcc: config: microblaze: fix cpu version check Content-Language: en-US To: Neal Frager , gcc-patches@gcc.gnu.org, eager@eagerm.com Cc: ibai.erkiaga-elorza@amd.com, nagaraju.mekala@amd.com, mark.hatle@amd.com, sadanand.mutyala@amd.com, appa.rao.nali@amd.com, vidhumouli.hunsigida@amd.com, luca.ceresoli@bootlin.com References: <20231030170253.293494-1-neal.frager@amd.com> From: Michael Eager In-Reply-To: <20231030170253.293494-1-neal.frager@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/30/23 10:02, Neal Frager wrote: > The MICROBLAZE_VERSION_COMPARE was incorrectly using strcasecmp > instead of strverscmp to check the mcpu version against feature > options. By simply changing the define to use strverscmp, > the new version 10.0 is treated correctly as a higher version > than previous versions. > > Signed-off-by: Neal Frager Added to commit message; Fix incorrect warning with -mcpu=10.0: warning: '-mxl-multiply-high' can be used only with '-mcpu=v6.00.a' or greater > --- > V1->V2: > - No need to create a new microblaze specific version check > routine as strverscmp is the correct solution. > V2->V3: > - Changed mcpu define for microblaze isa testsuite examples. > V3->V4: > - Added ChangeLog > V4->V5: > - Added testsuite ChangeLog > V5->V6: > - Updated testsuite ChangeLog to include all files > --- > gcc/ChangeLog | 4 ++++ > gcc/config/microblaze/microblaze.cc | 2 +- > gcc/testsuite/ChangeLog | 22 +++++++++++++++++++ > .../gcc.target/microblaze/isa/bshift.c | 2 +- > gcc/testsuite/gcc.target/microblaze/isa/div.c | 2 +- > .../gcc.target/microblaze/isa/fcmp1.c | 2 +- > .../gcc.target/microblaze/isa/fcmp2.c | 2 +- > .../gcc.target/microblaze/isa/fcmp3.c | 2 +- > .../gcc.target/microblaze/isa/fcmp4.c | 2 +- > .../gcc.target/microblaze/isa/fcvt.c | 2 +- > .../gcc.target/microblaze/isa/float.c | 2 +- > .../gcc.target/microblaze/isa/fsqrt.c | 2 +- > .../microblaze/isa/mul-bshift-pcmp.c | 2 +- > .../gcc.target/microblaze/isa/mul-bshift.c | 2 +- > gcc/testsuite/gcc.target/microblaze/isa/mul.c | 2 +- > .../microblaze/isa/mulh-bshift-pcmp.c | 2 +- > .../gcc.target/microblaze/isa/mulh.c | 2 +- > .../gcc.target/microblaze/isa/nofcmp.c | 2 +- > .../gcc.target/microblaze/isa/nofloat.c | 2 +- > .../gcc.target/microblaze/isa/pcmp.c | 2 +- > .../gcc.target/microblaze/isa/vanilla.c | 2 +- > .../gcc.target/microblaze/microblaze.exp | 2 +- > 22 files changed, 46 insertions(+), 20 deletions(-) Committed. -- Michael Eager